Re: kernel32/tests : try2 added tests for copyfileex

s...@das-labor.org wrote: > OK, but how do I know that the old behavior is broken ? WindowsXp behaves > like msdn quotes while newer windows don't. Do you always assume that the > latest implementation is correct ? Should wine just match the latest > test-results and ignore osversioninfo at all ?

Re: kernel32/tests : try2 added tests for copyfileex

OK, but how do I know that the old behavior is broken ? WindowsXp behaves like msdn quotes while newer windows don't. Do you always assume that the latest implementation is correct ? Should wine just match the latest test-results and ignore osversioninfo at all ?Von: "Dmitry Timoshkov" An: "Patrick

Re: d3dx9: Implement D3DXSHEvalConeLight (resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23862 Your paranoid android

Re: include: flesh out d3d11.idl (try 2)

Austin English wrote: > Try 2: > Remove L suffixes, C++ comment. > +/* Forward declarations */ You've copied too much from the PSDK version, better leave it to someone else, and do it step by step when particular functionality gets implemented. -- Dmitry.

Re: user32: fix non-BOOL returns in BOOL functions

Damjan Jovanovic wrote: > Changelog: > * user32: fix non-BOOL returns in BOOL functions GetClassInfo is special, it actually returns class atom on success, not just a boolean value. So it's better to leave it as it is now. -- Dmitry.

Re: [PATCH 2/4] kernel32/path : try2 implement copyfileexW progressroutine callback

Patrick Rudolph wrote: > try 2: > set progress routine pointer to NULL to disable progress reporting > test osversion and delete destination file on PROGRESS_STOP on vista > and newer This kind of version check is useless in Wine. -- Dmitry.

Re: kernel32/tests : try2 added tests for copyfileex

Patrick Rudolph wrote: > try2: > check the os version in case of PROGRESS_STOP > +ret = GetFileAttributesEx(dest_name, GetFileExInfoStandard, > (void*)&fileInfo); > + > +/* Windows Vista and newer delete the file, while prior versions don't */ > +ok((!ret && info.dwMajorVersion > 5)

Re: [2/2] comctl32/listview: Add a special case for deselect all attempt when nothing is selected

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23861 Your paranoid android

Re: include: flesh out d3d11.idl

On 1/10/2013 22:35, Austin English wrote: Some minor things. +typedef enum D3D11_RESOURCE_DIMENSION +{ +D3D11_RESOURCE_DIMENSION_UNKNOWN = 0, +D3D11_RESOURCE_DIMENSION_BUFFER = 1, +D3D11_RESOURCE_DIMENSION_TEXTURE1D = 2, +D3D11_RESOURCE_DIMENSION_TEXTURE2D = 3, +D3D11_RESOU

Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.

On 10.01.2013 17:13, Matteo Bruni wrote: 2013/1/10 Rico Schüller : --- dlls/d3dx9_36/texture.c | 6 +++--- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(- -DWORD i, v; +DWORD i, v, mask32 = format->bits[c] == 32 ? -1 : ((1 << format->bits[c]) - 1); Usually w

Re: [PATCH 3/3] d3dx9: Use all 32 bits as mask.

2013/1/10 Rico Schüller : > --- > dlls/d3dx9_36/texture.c | 6 +++--- > 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(- > > -DWORD i, v; > +DWORD i, v, mask32 = format->bits[c] == 32 ? -1 : ((1 << > format->bits[c]) - 1); Usually we prefer to use ~0U instead of -1

Re: Truncate MIDI SysEx messages after termination byte

2013/1/10 Johannes Kroll > On Thu, 10 Jan 2013 12:04:02 +0100 > Christian Costa wrote: > > > In your code you stop checking F7 just before the last byte (until > > position lpMidiOutHdr->dwBufferLength-2); > > You can check the last byte as well. This is also valid and simplify the > > condition

Re: Truncate MIDI SysEx messages after termination byte

On Thu, 10 Jan 2013 12:04:02 +0100 Christian Costa wrote: > In your code you stop checking F7 just before the last byte (until > position lpMidiOutHdr->dwBufferLength-2); > You can check the last byte as well. This is also valid and simplify the > condition. > The missing F7 byte case is handled

Re: [PATCH] d3dx9: Shift only as much as needed.

Hi, please don't apply this patch. There are several other occurrences in the same file. I'll send an improved version. Cheers Rico On 10.01.2013 13:55, Rico Schüller wrote: Hi, this patch removes useless shifts, which may result in wrong data when the shift is bigger than 24. Cheers Rico

Re: [2/2] comctl32/listview: Use LVM_SETITEMSTATE directly in tests

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23848 Your paranoid android

Re: Truncate MIDI SysEx messages after termination byte

2013/1/10 Johannes Kroll > On Thu, 10 Jan 2013 01:05:28 +0100 > Johannes Kroll wrote: > > > On Thu, 10 Jan 2013 00:38:06 +0100 > > Christian Costa wrote: > > > > > > > After a better look the changes seem correct. > > > The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary > tough.

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws (try 3)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23842 Your paranoid android

Re: [PATCH 05/17] msvcrt: Added fopen_s test with ccs option

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23834 Your paranoid android

Re: [PATCH 4/5] d3d9/tests: Merge buffer.c into device.c.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23840 Your paranoid android

Re: [PATCH 17/17] msvcrt: Added read tests on unicode files

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23838 Your paranoid android

Re: [PATCH 5/5] d3d9/tests: Merge query.c into device.c.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23841 Your paranoid android

Re: [PATCH 13/17] msvcrt: Added _setmode tests

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23836 Your paranoid android

Re: [PATCH 07/17] msvcrt: Added write tests on unicode files

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23835 Your paranoid android

Problem with editing FAQ and other pages at wiki

Hello! I've tried editing wine FAQ and several other wiki pages, but failed. When I click on "Preview" or "Save" buttons, I always see error message like [Errno 31] Too many links: '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' If you want to report a bug, please save this pa