Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Johannes Kroll
On Thu, 10 Jan 2013 01:05:28 +0100 Johannes Kroll wrote: > On Thu, 10 Jan 2013 00:38:06 +0100 > Christian Costa wrote: > > > > After a better look the changes seem correct. > > The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary tough. > > Without the buffer length check, there

Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Johannes Kroll
On Thu, 10 Jan 2013 00:38:06 +0100 Christian Costa wrote: > After a better look the changes seem correct. > The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary tough. Without the buffer length check, there would be a buffer overflow when an application tries to send a SysEx withou

Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Christian Costa
Le 09/01/2013 19:32, Johannes Kroll a écrit : On Wed, 9 Jan 2013 19:04:03 +0100 Christian Costa wrote: I would say consistency would be 2 spaces or none. You are, of course, entitled to your opinion. If my opinion does not matter as well as code style practices we can found in wine that woul

Re: [PATCH 0/7] Series short description

2013-01-09 Thread Eric Pouech
> Running make test with this series hangs in the hlink.c test, there seems to be a wineconsole process that never terminates. that's because rpcss is started from the hlink test, and is still a child of wineconsole (now) after the test terminated and wineconsole always waits for all its children

Re: [PATCH] crypt32: free the encoded msg (Coverity)

2013-01-09 Thread Juan Lang
In case this was awaiting an ACK from me, this looks good. Thanks. --Juan

Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Johannes Kroll
On Wed, 9 Jan 2013 19:04:03 +0100 Christian Costa wrote: > I would say consistency would be 2 spaces or none. You are, of course, entitled to your opinion. > Using only 1 space for assignment does not seem very common in wine AFAIK. > In general it's better to follow the file style or the func

Re: usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable

2013-01-09 Thread Aric Stewart
Ah, yes, you corrected that in another area also. I will rewrite. -aric On 13/01/09 12:02, Huw Davies wrote: > On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote: >> +typedef struct { >> +WORD LigatureAnchor[1]; >> +} GPOS_ComponentRecord; >> + >> +typedef struct { >> +WORD Com

Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Christian Costa
2013/1/9 Johannes Kroll > On Wed, 9 Jan 2013 16:10:18 +0100 > Christian Costa wrote: > > > 2013/1/9 Johannes Kroll > > > > > On Wed, 09 Jan 2013 10:19:54 +0100 > > > Christian Costa wrote: > > > > > > > Le 09/01/2013 04:26, Johannes Kroll a écrit : > > > > > Hi, > > > > > > > > > > On Wed, 09

Re: usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable

2013-01-09 Thread Huw Davies
On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote: > +typedef struct { > +WORD LigatureAnchor[1]; > +} GPOS_ComponentRecord; > + > +typedef struct { > +WORD ComponentCount; > +GPOS_ComponentRecord ComponentRecord[1]; > +} GPOS_LigatureAttach; > + > +for (

Re: [PATCH (try3)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23822 Your paranoid android

Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Johannes Kroll
On Wed, 9 Jan 2013 16:10:18 +0100 Christian Costa wrote: > 2013/1/9 Johannes Kroll > > > On Wed, 09 Jan 2013 10:19:54 +0100 > > Christian Costa wrote: > > > > > Le 09/01/2013 04:26, Johannes Kroll a écrit : > > > > Hi, > > > > > > > > On Wed, 09 Jan 2013 03:55:25 +0100 > > > > Christian Costa

Re: [PATCH] d3d8/tests: Merge surface.c into device.c.

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23820 Your paranoid android

Re: aclocal: Use -Werror when checking compiler flags (try 2)

2013-01-09 Thread Alexandre Julliard
Per Johansson writes: > ...if supported by compiler. > This makes clang exit with error on unsupported warnings. > --- > aclocal.m4 | 2 +- > configure.ac | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/aclocal.m4 b/aclocal.m4 > index 14cf916..a6d9f12 100644 > --- a/a

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.

2013-01-09 Thread Vincent Povirk
Series looks fine to me. And yes, testbot has been broken for a while now..

Re: [PATCH 5/5] d3d8/tests: Merge surface.c into device.c.

2013-01-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-01-09 17:04, schrieb Alexandre Julliard: > ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p > d3d8_test.exe.so device.c && touch device.ok device.c:4088: Test > failed: Got unexpected hr 0x88760867. device.c:4091: Test failed: > Got

Re: [PATCH 5/5] d3d8/tests: Merge surface.c into device.c.

2013-01-09 Thread Alexandre Julliard
Henri Verbeet writes: > --- > dlls/d3d8/tests/Makefile.in |1 - > dlls/d3d8/tests/device.c| 704 > ++- > dlls/d3d8/tests/surface.c | 653 --- > 3 files changed, 702 insertions(+), 656 deletions(-) > delete

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Jacek Caban
Hi Andrew, On 01/09/13 16:56, Andrew Eikum wrote: > --- > > This should fix the Office 2007 half of Bug 17271. > > try2: Fix test failures on XP by expanding the expected path name. > > dlls/ieframe/navigate.c | 7 +- > dlls/ieframe/tests/webbrowser.c | 56 >

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23818 Your paranoid android

Re: [PATCH] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23816 Your paranoid android

Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Johannes Kroll
On Wed, 09 Jan 2013 10:19:54 +0100 Christian Costa wrote: > Le 09/01/2013 04:26, Johannes Kroll a écrit : > > Hi, > > > > On Wed, 09 Jan 2013 03:55:25 +0100 > > Christian Costa wrote: > > > >> Hi, > >> > >> Please be consistent when using space. 1 space before and after > >> operators (<, ==, =,

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback

2013-01-09 Thread Nikolay Sivov
On 1/9/2013 01:12, Patrick Rudolph wrote: Am 2013-01-08 20:41, schrieb Nikolay Sivov: On 1/8/2013 22:19, Patrick Rudolph wrote: +BOOL progressRoutine_enabled = progressRoutine != 0; Why do you need this? You could always check for callback pointer directly. This is necessary because the

Re: vbscript: Added support for a few more constants

2013-01-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23812 Your paranoid android

Re: Truncate MIDI SysEx messages after termination byte

2013-01-09 Thread Christian Costa
Le 09/01/2013 04:26, Johannes Kroll a écrit : Hi, On Wed, 09 Jan 2013 03:55:25 +0100 Christian Costa wrote: Hi, Please be consistent when using space. 1 space before and after operators (<, ==, =, ...). spaces inserted. HTH. J. That's better. You forgot some occurences in the for loop tho