On Thu, 10 Jan 2013 01:05:28 +0100
Johannes Kroll wrote:
> On Thu, 10 Jan 2013 00:38:06 +0100
> Christian Costa wrote:
>
>
> > After a better look the changes seem correct.
> > The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary tough.
>
> Without the buffer length check, there
On Thu, 10 Jan 2013 00:38:06 +0100
Christian Costa wrote:
> After a better look the changes seem correct.
> The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary tough.
Without the buffer length check, there would be a buffer overflow when
an application tries to send a SysEx withou
Le 09/01/2013 19:32, Johannes Kroll a écrit :
On Wed, 9 Jan 2013 19:04:03 +0100
Christian Costa wrote:
I would say consistency would be 2 spaces or none.
You are, of course, entitled to your opinion.
If my opinion does not matter as well as code style practices we can
found in wine
that woul
> Running make test with this series hangs in the hlink.c test, there
seems to be a wineconsole process that never terminates.
that's because rpcss is started from the hlink test, and is still a
child of wineconsole (now) after the test terminated
and wineconsole always waits for all its children
In case this was awaiting an ACK from me, this looks good. Thanks.
--Juan
On Wed, 9 Jan 2013 19:04:03 +0100
Christian Costa wrote:
> I would say consistency would be 2 spaces or none.
You are, of course, entitled to your opinion.
> Using only 1 space for assignment does not seem very common in wine AFAIK.
> In general it's better to follow the file style or the func
Ah, yes, you corrected that in another area also. I will rewrite.
-aric
On 13/01/09 12:02, Huw Davies wrote:
> On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote:
>> +typedef struct {
>> +WORD LigatureAnchor[1];
>> +} GPOS_ComponentRecord;
>> +
>> +typedef struct {
>> +WORD Com
2013/1/9 Johannes Kroll
> On Wed, 9 Jan 2013 16:10:18 +0100
> Christian Costa wrote:
>
> > 2013/1/9 Johannes Kroll
> >
> > > On Wed, 09 Jan 2013 10:19:54 +0100
> > > Christian Costa wrote:
> > >
> > > > Le 09/01/2013 04:26, Johannes Kroll a écrit :
> > > > > Hi,
> > > > >
> > > > > On Wed, 09
On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote:
> +typedef struct {
> +WORD LigatureAnchor[1];
> +} GPOS_ComponentRecord;
> +
> +typedef struct {
> +WORD ComponentCount;
> +GPOS_ComponentRecord ComponentRecord[1];
> +} GPOS_LigatureAttach;
> +
> +for (
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23822
Your paranoid android
On Wed, 9 Jan 2013 16:10:18 +0100
Christian Costa wrote:
> 2013/1/9 Johannes Kroll
>
> > On Wed, 09 Jan 2013 10:19:54 +0100
> > Christian Costa wrote:
> >
> > > Le 09/01/2013 04:26, Johannes Kroll a écrit :
> > > > Hi,
> > > >
> > > > On Wed, 09 Jan 2013 03:55:25 +0100
> > > > Christian Costa
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23820
Your paranoid android
Per Johansson writes:
> ...if supported by compiler.
> This makes clang exit with error on unsupported warnings.
> ---
> aclocal.m4 | 2 +-
> configure.ac | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/aclocal.m4 b/aclocal.m4
> index 14cf916..a6d9f12 100644
> --- a/a
Series looks fine to me. And yes, testbot has been broken for a while now..
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 2013-01-09 17:04, schrieb Alexandre Julliard:
> ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p
> d3d8_test.exe.so device.c && touch device.ok device.c:4088: Test
> failed: Got unexpected hr 0x88760867. device.c:4091: Test failed:
> Got
Henri Verbeet writes:
> ---
> dlls/d3d8/tests/Makefile.in |1 -
> dlls/d3d8/tests/device.c| 704
> ++-
> dlls/d3d8/tests/surface.c | 653 ---
> 3 files changed, 702 insertions(+), 656 deletions(-)
> delete
Hi Andrew,
On 01/09/13 16:56, Andrew Eikum wrote:
> ---
>
> This should fix the Office 2007 half of Bug 17271.
>
> try2: Fix test failures on XP by expanding the expected path name.
>
> dlls/ieframe/navigate.c | 7 +-
> dlls/ieframe/tests/webbrowser.c | 56
>
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23818
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23816
Your paranoid android
On Wed, 09 Jan 2013 10:19:54 +0100
Christian Costa wrote:
> Le 09/01/2013 04:26, Johannes Kroll a écrit :
> > Hi,
> >
> > On Wed, 09 Jan 2013 03:55:25 +0100
> > Christian Costa wrote:
> >
> >> Hi,
> >>
> >> Please be consistent when using space. 1 space before and after
> >> operators (<, ==, =,
On 1/9/2013 01:12, Patrick Rudolph wrote:
Am 2013-01-08 20:41, schrieb Nikolay Sivov:
On 1/8/2013 22:19, Patrick Rudolph wrote:
+BOOL progressRoutine_enabled = progressRoutine != 0;
Why do you need this? You could always check for callback pointer
directly.
This is necessary because the
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23812
Your paranoid android
Le 09/01/2013 04:26, Johannes Kroll a écrit :
Hi,
On Wed, 09 Jan 2013 03:55:25 +0100
Christian Costa wrote:
Hi,
Please be consistent when using space. 1 space before and after
operators (<, ==, =, ...).
spaces inserted. HTH.
J.
That's better. You forgot some occurences in the for loop tho
23 matches
Mail list logo