Re: Truncate MIDI SysEx messages after termination byte

2013-01-08 Thread Johannes Kroll
Hi, On Wed, 09 Jan 2013 03:55:25 +0100 Christian Costa wrote: > Hi, > > Please be consistent when using space. 1 space before and after > operators (<, ==, =, ...). spaces inserted. HTH. J.>From edd15d7d71e7309937c27dd9e6eab56bf42cc589 Mon Sep 17 00:00:00 2001 From: Johannes Kroll Date: Wed

[PATCH] winspool.drv: Ignore pDevModeInput if fMode not equal DM_IN_BUFFER

2013-01-08 Thread Tatyana Fokina
From 97af74459b6b158f287cb0510bba6e2689a7615b Mon Sep 17 00:00:00 2001 From: tatyana Date: Tue, 8 Jan 2013 17:04:00 +0400 Subject: [PATCH 1/3] winspool.drv: Ignore pDevModeInput if fMode not equal DM_IN_BUFFER. --- dlls/winspool.drv/info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.

2013-01-08 Thread Dmitry Timoshkov
Marvin wrote: > === WINEBUILD (build) === > Patch failed to apply Looks like testbot is broken. -- Dmitry.

Re: [1/2] windowscodecs: Add a test for loading a .bmp file with BITMAPINFOHEADER.

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23802 Your paranoid android

Re: [2/2] windowscodecs: BMP decoder should always return valid image resolution.

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23803 Your paranoid android

Re: Truncate MIDI SysEx messages after termination byte

2013-01-08 Thread Christian Costa
Le 09/01/2013 03:12, Johannes Kroll a écrit : While using the KORG Kontrol Editor software [1] under Wine to configure my nanoPAD2 MIDI controller, I noticed that uploading parameters to the hardware doesn't work. The program displays a timeout message. The program relies on the MIDI driver to r

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback

2013-01-08 Thread Patrick Rudolph
Am 2013-01-08 20:41, schrieb Nikolay Sivov: On 1/8/2013 22:19, Patrick Rudolph wrote: +BOOL progressRoutine_enabled = progressRoutine != 0; Why do you need this? You could always check for callback pointer directly. This is necessary because the called progressRoutine can return PROGRESS

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback

2013-01-08 Thread Nikolay Sivov
On 1/8/2013 22:19, Patrick Rudolph wrote: This should fix bug http://bugs.winehq.org/show_bug.cgi?id=29232 It fixes lots of tests on wine. That's suspicious cause you don't have test diff in this patch.

Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback

2013-01-08 Thread Nikolay Sivov
On 1/8/2013 22:19, Patrick Rudolph wrote: +BOOL progressRoutine_enabled = progressRoutine != 0; Why do you need this? You could always check for callback pointer directly.

Re: kernel32/tests : added tests for copyfileex

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23794 Your paranoid android

Re: [PATCH 0/7] Series short description

2013-01-08 Thread Alexandre Julliard
Eric Pouech writes: > The following series implements a new scheme for managing 'bare' consoles. > We now force every program started without a wine parent to be run under > wineconsole (transparently for the user). > This is done using a new backend in wineconsole called 'line'. This backend > o

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.

2013-01-08 Thread Andrew Eikum
On Tue, Jan 08, 2013 at 05:40:44PM +0400, Nikolay Sivov wrote: > On 1/8/2013 16:34, Tatyana Fokina wrote: > > >+ > >+memset(a, 'a', sizeof(a)); > >+SetLastError(NO_ERROR); > >+ret = CompareStringA(lcid, 0, a, sizeof(a), a, sizeof(a)); > >+error = GetLastError(); > >+ok(!error &

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.

2013-01-08 Thread Nikolay Sivov
On 1/8/2013 16:34, Tatyana Fokina wrote: + +memset(a, 'a', sizeof(a)); +SetLastError(NO_ERROR); +ret = CompareStringA(lcid, 0, a, sizeof(a), a, sizeof(a)); +error = GetLastError(); +ok(!error && ret == CSTR_EQUAL, "ret %d (expected %d), error %d\n", ret, CSTR_EQUAL, error);

Re: [PATCH] [2/2] kernel32/tests: Add test with a large string for CompareStringA.

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23793 Your paranoid android

Re: [2/3] xmllite: Report value for PI nodes

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23792 Your paranoid android

Re: [1/3] xmllite: Report node value for comment nodes

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23791 Your paranoid android

Re: [PATCH 4/5] d3d8/tests: Merge d3d8_main.c into device.c.

2013-01-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23788 Your paranoid android