Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread jordan
> This might also end up being generally useful for programs that are realtime > and make a lot of wineserver calls. I believe > the mutexes were taking too > long to access because they were going through wineserver, which was already > handling a > lot of other calls in serial. Basically, it w

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread André Hentschel
On 04.01.2013 22:33, Louis Gorenfeld wrote: > Hi! > I'm really happy that some of our patches are making it into WINE! If I > could chime in... > 0005-Expand-dos-has-entropy-in-order-to-make-collision-le.patch Not sure why this is needed? >>> >>> I'm not sure why either, but i

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread Louis Gorenfeld
Hi! I'm really happy that some of our patches are making it into WINE! If I could chime in... >>> 0005-Expand-dos-has-entropy-in-order-to-make-collision-le.patch >>> Not sure why this is needed? >> >> I'm not sure why either, but i am guessing it improves things in a >> linux-rt/VST se

Re: [1/4] windowscodecs: Introduce 24bppRGB PixelFormat

2013-01-04 Thread Vincent Povirk
The series looks good to me. Of course, we can already read 8-bit tiffs just fine, but I guess your app makes use of the 8bpp RGB format. We could probably avoid a double conversion between rgb and bgr when reading an 8-bit tiff as rgb, by implementing and using the IWICBitmapSourceTransform inter

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread jordan
> We at Muse Research are happy help move our patches from custom one-offs to > the main fork. Background info below... > -- Michael Ost > Muse Research and Development Hi Michael, I recognize your name from years ago on various (linux-related) lists. I hope you don't mind that i took the initia

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread Michael Ost
Hi, list. We at Muse Research are happy help move our patches from custom one-offs to the main fork. Background info below... The original patches/sources (that i have based my version on, are found here: http://www.museresearch.com/support/receptor-faq.php ...at the bottom of the page / las

Re: [3/4] windowscodecs: Test conversions of the 24bpp PixelFormats

2013-01-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23739 Your paranoid android

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread jordan
Also, as a general note Marcus (and any other wine-developer who may be reading this). If you guys ever happen to come accross patches that may fix issues for me, but aren't suitable for upstream ~ please contact me and pass them along. since i am targeting a much smaller audience with 'particula

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread jordan
>> The original patches/sources (that i have based my version on, are >> found here: http://www.museresearch.com/support/receptor-faq.php >> >> ...at the bottom of the page / last link: >> http://www.museresearch.com/support/receptor-faq.php >> >> these patches fix Wine problems (in most areas) for

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread Marcus Meissner
On Thu, Jan 03, 2013 at 05:22:14PM -0500, jordan wrote: > Hi, > > I have been experimenting with some patchsets for Wine -> based on an > implementation of Wine originally developed By Muse Research. It has > improved support for a bunch of stuff, fixes (most) bottlenecks for > Linux proaudio fol

Re: windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory. Take 2.

2013-01-04 Thread Vincent Povirk
This looks good to me (and it's hard for me to stick to my preference for IWICBitmapLock, given how little code is needed here to accomplish the same thing). The remaining todo is an unrelated bug that's my fault, and I'll resend my patch for it if this one is accepted.

Re: [PATCH] d3dx9_36: Implement ID3DXFileImpl_RegisterTemplates + tests. (resend)

2013-01-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23733 Your paranoid android

Re: windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory. Take 2.

2013-01-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23734 Your paranoid android