Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)

2012-12-28 Thread Dmitry Timoshkov
Stefan Leichter wrote: > First of all: The issues your are pointing out have been in the previous > version of the patch too. Why didn't you complain in your first review. To my > understanding this is a wast of my time complaining about two issues and > keeping the rest secret for the next ve

Re: [PATCH] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character.

2012-12-28 Thread Alexandre Julliard
Akihiro Sagawa writes: > --- > dlls/gdi32/freetype.c | 20 +-- > dlls/gdi32/tests/font.c | 85 > +++ > 2 files changed, 102 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../..

Re: [3/9] server: Use the same object type for both ends of a named pipe. (try 2)

2012-12-28 Thread Alexandre Julliard
Adam Martinson writes: > From 8eb230b505ddd986b689caf96510fbe016d721a7 Mon Sep 17 00:00:00 2001 > From: Adam Martinson > Date: Thu, 20 Dec 2012 19:55:13 -0600 > Subject: [PATCH 3/9] server: Use the same object type for both ends of a > named pipe. > > Makes either end of a named pipe is readabl

Re: wine-1.5.20 regression compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole

2012-12-28 Thread Alan W. Irwin
On 2012-12-28 13:45+0100 Frédéric Delanoy wrote: Other users have issues with wine but they don't generally complain as loudly as you did. It is possible I was not cautious enough with my tone, but let's leave it like this. Wine-1.5.20 has introduced an obvious regression for an important Wind

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)

2012-12-28 Thread Stefan Leichter
Monday 17 December 2012 Dmitry Timoshkov > Stefan Leichter wrote: > > +BYTE buffer[MAX_PATH]; > > This should be WCHAR if you decided to test unicode version of the API > (although testing ANSI variant would be much easier), that will help > to avoid all those casts, and protect from insuff

Re: [PATCH] advapi32: do not use invalid pSD value (Coverity)

2012-12-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23641 Your paranoid android

Re: wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole

2012-12-28 Thread Frédéric Delanoy
On Fri, Dec 28, 2012 at 11:54 AM, Alan W. Irwin wrote: > On 2012-12-28 10:44+0100 Frédéric Delanoy wrote: > >> On Mon, Dec 24, 2012 at 8:58 AM, Alan W. Irwin >> wrote: >>> >>> On 2012-12-23 21:25-0600 Austin English wrote: >>> On Dec 23, 2012 7:22 PM, "Alan W. Irwin" wrote: > >

Re: wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole

2012-12-28 Thread Alan W. Irwin
On 2012-12-28 10:44+0100 Frédéric Delanoy wrote: On Mon, Dec 24, 2012 at 8:58 AM, Alan W. Irwin wrote: On 2012-12-23 21:25-0600 Austin English wrote: On Dec 23, 2012 7:22 PM, "Alan W. Irwin" wrote: The subject line pretty much says it all. Running MinGW/gcc under wineconsole for any simp

Re: wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole

2012-12-28 Thread Frédéric Delanoy
On Mon, Dec 24, 2012 at 8:58 AM, Alan W. Irwin wrote: > On 2012-12-23 21:25-0600 Austin English wrote: > >> On Dec 23, 2012 7:22 PM, "Alan W. Irwin" >> wrote: >>> >>> The subject line pretty much says it all. Running MinGW/gcc under >>> wineconsole for any simple test programme should demonstrat