re: Clang static analyzer results / wine-1.5.19-186-g1cd0c4a

2012-12-21 Thread Dan Kegel
I had a look at a couple warnings, e.g. file:///home/dank/Downloads/scan-build-2012-12-18-1/report-z07lcL.html#EndPath file:///home/dank/Downloads/scan-build-2012-12-18-1/report-9D2p5I.html#EndPath They're hard to follow, but mostly look like garbage :-( Too bad there's no web interface for marki

dsound: use event based threads, v2

2012-12-21 Thread Joerg-Cyril.Hoehle
Hi, Maarten Lankhorst answered: >> [...] I wonder why you >> insist on using GetStreamLatency as the basis of your timeout >> computations instead of GetDevicePeriod. >Because I'm using it later on in the rework to tell how much to queue. Ah. But why not use the correct tool for the correct job

Re: Need help to install Xlib/xfree86 devlopnemt packeg in ubuntu 10 LTS

2012-12-21 Thread Frédéric Delanoy
On Thu, Dec 20, 2012 at 6:25 AM, Hamid Lohar wrote: > I am installing it from source file (wine 1.5.x.tar.bz2) by running > wine install i get error "x support not found, wine can not fount x, > please instal xlib/xfree86 devlopment files". > That is the error. > You need to install your X develop

Re: msvcrt: fix prototypes ov _execvp, _wexecvp, _execvpe and _wexecvpe

2012-12-21 Thread Alexandre Julliard
Jérôme Gardou writes: > --- > dlls/msvcrt/process.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) You should also fix the corresponding headers and remove the typecasts. -- Alexandre Julliard julli...@winehq.org

Re: jscript: Added null and undefined values support to to_object

2012-12-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23578 Your paranoid android

Re: [PATCH 2/2] msvcr100: Added _aligned_msize implementation

2012-12-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23573 Your paranoid android

Re: [1/2] wineps.drv: Add an ability to select device resolution from UI.

2012-12-21 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Actually I did that, but then tested under Russian Windows7 and it's 'dpi' > there, so I'd assume that it's either considered as a common term, or it's > driver dependent (although all remaining driver UIs are in Russian here). > If you still think that it should be tra

Re: [1/2] wineps.drv: Add an ability to select device resolution from UI.

2012-12-21 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > @@ -224,10 +229,13 @@ typedef struct > > static INT_PTR CALLBACK PSDRV_PaperDlgProc(HWND hwnd, UINT msg, > > WPARAM wParam, LPARAM lParam) > > { > > + static const WCHAR resW[] = {'%','d',' ','d','p','i',0}; > > + stati

Re: [PATCH] loader: Use a volatile pointer in wld_memset().

2012-12-21 Thread Alexandre Julliard
Charles Davis writes: > This prevents Clang from optimizing the loop into a memset(3) call. Something like -fno-builtin would be preferable. -- Alexandre Julliard julli...@winehq.org

Re: [1/2] wineps.drv: Add an ability to select device resolution from UI.

2012-12-21 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -224,10 +229,13 @@ typedef struct > static INT_PTR CALLBACK PSDRV_PaperDlgProc(HWND hwnd, UINT msg, > WPARAM wParam, LPARAM lParam) > { > + static const WCHAR resW[] = {'%','d',' ','d','p','i',0}; > + static const WCHAR

Re: winepulse test data review

2012-12-21 Thread Arun Raghavan
On Thu, 2012-12-20 at 13:34 +0100, Maarten Lankhorst wrote: > Op 04-12-12 14:28, joerg-cyril.hoe...@t-systems.com schreef: > > Hi, > > > > Maarten Lankhorst wrote: > >> Actually in winepulse, sleep / 12000 (8 ms I guess?) ms would work, no > >> sleep at all works too, > > Yes, I wanted to go no fu

Re: winepulse test data review

2012-12-21 Thread Maarten Lankhorst
Op 04-12-12 14:28, joerg-cyril.hoe...@t-systems.com schreef: > Hi, > > Maarten Lankhorst wrote: >> Actually in winepulse, sleep / 12000 (8 ms I guess?) ms would work, no sleep >> at all works too, > Yes, I wanted to go no further than 8ms below the 10ms period limit. > >> it was just the mixing of

dsound: use event based threads, v2

2012-12-21 Thread Joerg-Cyril.Hoehle
Maarten, > +hres = IAudioClient_GetStreamLatency(device->client, &period); > +device->sleeptime = period_ms * 5 / 2; > + ret = WaitForSingleObject(dev->sleepev, dev->sleeptime); Although it's a minor point, as we're solely discussing the case of the timeout when mmdevapi d

mmdevapi: Avoid lock contention after SetEvent.

2012-12-21 Thread Joerg-Cyril.Hoehle
Andrew Eikum asked: >Is it true that SetEvent() causes a context switch? Looking at +tid log files, I've seen switches happen after SetEvent often enough. That motivated some changes to winmm notification in the last years, i.e. call SetEvent after all local work is finished and objects are in a