Re: oleaut32: Indentation fix (Try 2)

2012-12-20 Thread Andrew Talbot
Sorry, I should have labelled this patch as "Try 2". -- Andy.

Fwd: [PATCH 3/8] winemac: Implement GetDeviceCaps().

2012-12-20 Thread Per Johansson
Forgot to include list somehow... On Mon, Dec 17, 2012 at 9:16 PM, Alexandre Julliard wrote: > > My main reason for using it is to test the Mac builds before pushing > commits, so not being able to build the Mac driver on it is a serious > problem (and no, it can't be upgraded apparently). I'll

Re: [PATCH 2/2] gdi32: Ensure a fixed-pitch full-width character has double width of a half-width character.

2012-12-20 Thread Alexandre Julliard
Akihiro Sagawa writes: > @@ -5866,10 +5867,22 @@ static DWORD get_glyph_outline(GdiFont > *incoming_font, UINT glyph, UINT format, > return GDI_ERROR; > } > > +if (!font->orientation) { > +TEXTMETRICW tm; > +double advance = (ft_face->glyph->metrics.horiAdvanc

Re: dsound: use event based threads, v2

2012-12-20 Thread Andrew Eikum
Looks good to me, no problems with any of the drivers. I think it'd be good to get it in on Monday, as release day is tomorrow, but that's not my call. Andrew On Wed, Dec 19, 2012 at 10:30:04AM +0100, Maarten Lankhorst wrote: > Use a thread instead of a timer for greater precision. > > Changes s

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

2012-12-20 Thread Alexandre Julliard
Dmitry Timoshkov writes: > There are 9 elements of 2 bytes in size each, 18 bytes in total, > the compiler will align this structure to 4 bytes, making its > size 20 bytes. No it won't. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

2012-12-20 Thread Huw Davies
On Thu, Dec 20, 2012 at 11:26:36PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > The size is irrelevant - it's variable sized anyway. We just care > > about the offsets of the elements. > > Anyway, in order to avoid any confusion or bugs in future with allocating > an array of such stru

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

2012-12-20 Thread Dmitry Timoshkov
Huw Davies wrote: > > There are 9 elements of 2 bytes in size each, 18 bytes in total, > > the compiler will align this structure to 4 bytes, making its > > size 20 bytes. > > The size is irrelevant - it's variable sized anyway. We just care > about the offsets of the elements. Anyway, in orde

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

2012-12-20 Thread Huw Davies
On Thu, Dec 20, 2012 at 11:05:48PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > > > typedef struct { > > > > +WORD PosFormat; > > > > +WORD Coverage; > > > > +WORD ValueFormat1; > > > > +WORD ValueFormat2; > > > > +WORD ClassDef1; > > > > +WORD ClassDef2; > >

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

2012-12-20 Thread Dmitry Timoshkov
Huw Davies wrote: > > > typedef struct { > > > +WORD PosFormat; > > > +WORD Coverage; > > > +WORD ValueFormat1; > > > +WORD ValueFormat2; > > > +WORD ClassDef1; > > > +WORD ClassDef2; > > > +WORD Class1Count; > > > +WORD Class2Count; > > > +WORD Class1Record[1

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

2012-12-20 Thread Huw Davies
On Thu, Dec 20, 2012 at 10:12:38PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > typedef struct { > > +WORD PosFormat; > > +WORD Coverage; > > +WORD ValueFormat1; > > +WORD ValueFormat2; > > +WORD ClassDef1; > > +WORD ClassDef2; > > +WORD Class1Count; > > +

Re: mmdevapi: Avoid lock contention after SetEvent.

2012-12-20 Thread Andrew Eikum
On Thu, Dec 20, 2012 at 02:03:06PM +0100, joerg-cyril.hoe...@t-systems.com wrote: > what's up with this patch? > > I wrote: > >SetEvent is one of those calls with a high probability that the > >Linux scheduler will switch to another thread, e.g. the one receiving > >the event. As the critical se

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

2012-12-20 Thread Dmitry Timoshkov
Huw Davies wrote: > typedef struct { > +WORD PosFormat; > +WORD Coverage; > +WORD ValueFormat1; > +WORD ValueFormat2; > +WORD ClassDef1; > +WORD ClassDef2; > +WORD Class1Count; > +WORD Class2Count; > +WORD Class1Record[1]; > +} GPOS_PairPosFormat2; Shouldn't

mmdevapi: Avoid lock contention after SetEvent.

2012-12-20 Thread Joerg-Cyril.Hoehle
Hi, what's up with this patch? I wrote: >SetEvent is one of those calls with a high probability that the >Linux scheduler will switch to another thread, e.g. the one receiving >the event. As the critical section is still hold, it'll prevent the >receiver from invoking mmdevapi, e.g. GetCurrentPa

Re: msxml3: Add custom handling for DISPID_VALUE for node map

2012-12-20 Thread Jacek Caban
Hi Nikolay, On 12/20/12 11:29, Nikolay Sivov wrote: > On 12/19/2012 17:22, Jacek Caban wrote: >> On 12/19/12 08:24, Nikolay Sivov wrote: >>> Add custom handling for DISPID_VALUE for node map >> If this has to be done for all IDispatchEx objects with DISPID_VALUE, it >> may be worth considering cha

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib (Try 3, resend)

2012-12-20 Thread Nikolay Sivov
On 12/20/2012 14:50, Tatyana Fokina wrote: Hi, Tatyana. Main problem is that your test will crash if run without patch 2/2, that's not how it should be done. You need to merge these patches together to keep tests working or send implementation fix first, so next test patch will work. +h

Re: oleaut32: Indentation Fix

2012-12-20 Thread Alexandre Julliard
Andrew Talbot writes: > Changelog: > oleaut32: Indentation Fix. Please avoid reformatting hundreds of lines for no reason. Only fix the parts where the indentation is actually incorrect. -- Alexandre Julliard julli...@winehq.org

Re: msxml3: Add custom handling for DISPID_VALUE for node map

2012-12-20 Thread Nikolay Sivov
On 12/19/2012 17:22, Jacek Caban wrote: On 12/19/12 08:24, Nikolay Sivov wrote: Add custom handling for DISPID_VALUE for node map If this has to be done for all IDispatchEx objects with DISPID_VALUE, it may be worth considering changing dispex.c. Something like: if(id == DISPID_VALUE && wFlags