Re: dsound: change mix rate of primary buffer

2012-12-18 Thread Andrew Eikum
On Tue, Dec 18, 2012 at 08:08:03PM +0100, sebastien chev wrote: > Thank you for the tips. I will look at these. > I guess you're probably also thinking about the mix buffer in dsound itself. That does always mix to float, and there isn't a way to change it right now. What are you planning to use

Clang static analyzer results / wine-1.5.19-186-g1cd0c4a

2012-12-18 Thread Austin English
Now that http://source.winehq.org/git/wine.git/commitdiff/4adfb787f4e8c36a37ce1d53a7e6df16d03ecd8a is in (and clang has improved), several wine/clang bugs are fixed. For those curious, there is one remaining test failure on my machine, with clang instead of gcc: http://bugs.winehq.org/show_bug.cg

winealsa: Separate read and write pointers.

2012-12-18 Thread Joerg-Cyril.Hoehle
Andrew Eikum wrote: >This [lock-less] seems to be the main goal of the patch. It'll not be bad to fix the capture bug independently. >and maybe we can get that into Wine after the next release? That requires agreement on the lock-less protocol. Basis: atomic 32bit updates. Do we want distinguish

Re: winealsa: Separate read and write pointers.

2012-12-18 Thread Andrew Eikum
On Mon, Dec 17, 2012 at 05:01:29PM +0100, joerg-cyril.hoe...@t-systems.com wrote: > Furthermore, this patch eases integration of my lock-less code, which > I'll not release for now, by cleanly separating read and write > pointers during playback and capture. No more adding of two volatile > entit

Re: dsound: change mix rate of primary buffer

2012-12-18 Thread Andrew Eikum
On Sun, Dec 16, 2012 at 11:56:46AM +0100, sebastien chev wrote: > It seems that no matter what the Windows side program choose for > DirectSoundCreate, the DSound subsystem initialize itself with the higher > spec sound available (for example 48Khz Float32, or 48kHz Int16 if no > Float32 available)

Re: mmdevapi: Prevent race condition upon Start.

2012-12-18 Thread Joerg-Cyril.Hoehle
>>Since This->started was not set yet[...] >This doesn't make sense, there's a critical section. You are right, this one patch is only needed for my lock-less code, which I'll not submit for now. Good catch. (The minimal dueTime would benefit current code nevertheless, since critical section cont

Re: mmdevapi: Prevent race condition upon Start.

2012-12-18 Thread Alexandre Julliard
writes: > What happened every so often, even on a single-core machine(!), is > that CreateTimerQueue(dueTime=0=immediate) would see the timer thread > created and the callback invoked before the function returns. Since > This->started was not set yet, our callback would return immediately, > in

Re: oleaut32: Dont output an error when the typelib cannot be found

2012-12-18 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > index fa9b050..04914e0 100644 > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -2544,9 +2544,11 @@ static HRESULT TLB_PEFile_Open(LPCWSTR path, INT > index, LPVOID *ppBase, DWORD