Hello,
On Thu, Dec 6, 2012 at 3:42 PM, Dmitry Timoshkov wrote:
>
> 'face' and 'family' are leaked here. Also returning FALSE at this point
> is too late since both 'face' and 'family' are already in the linked lists.
Thanks for point out this! I'll investigate more.
--
Regards,
Qian Hong
-
Sen
Qian Hong wrote:
> -GetEnumStructs( face, &elf, &ntm, &type );
> +if (!get_enum_structs( face, &elf, &ntm, &type )) return FALSE;
> free_family( family );
'face' and 'family' are leaked here. Also returning FALSE at this point
is too late since both 'face' and 'family' are already i
2012/12/5 Alexandre Julliard :
> You have nowhere near enough tests to make such a claim. When I said to
> write more tests, I didn't mean one or two more. You'd probably need at
> least 100 tests to have decent coverage of all the interesting cases.
It's not as much of a technical problem as it i
From c785203469fe96df081c5b0812d64699ec8f4f2f Mon Sep 17 00:00:00 2001
From: Vincent Povirk
Date: Wed, 5 Dec 2012 13:15:25 -0600
Subject: [PATCH 3/4] gdiplus: Always use AlphaBlend to draw to 32-bit DIB's.
---
dlls/gdiplus/gdiplus_private.h |1 +
dlls/gdiplus/graphics.c| 19 ++
Dmitry Timoshkov writes:
> Andrew Eikum wrote:
>
>> There is an implied test which is that the tests do not crash. Without
>> the change to , the tests you object to will
>> crash. With the change, they do not crash. This is the behavior being
>> tested.
>
> I think that Alexandre said several t
Andrew Eikum wrote:
> There is an implied test which is that the tests do not crash. Without
> the change to , the tests you object to will
> crash. With the change, they do not crash. This is the behavior being
> tested.
I think that Alexandre said several times that the tests for crashes are
u
On Thu, Dec 06, 2012 at 12:14:53AM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
>
> > > > The call is only supposed to return TRUE or FALSE, so I guess it's
> > > > checking that the return value isn't 3 or something. Not very useful,
> > > > sure, but it looked odd to just have a series
Andrew Eikum wrote:
> > > The call is only supposed to return TRUE or FALSE, so I guess it's
> > > checking that the return value isn't 3 or something. Not very useful,
> > > sure, but it looked odd to just have a series of sndPlaySound calls in
> > > a row without ok() calls. The real test is to
On Wed, Dec 05, 2012 at 11:21:39PM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
> > The call is only supposed to return TRUE or FALSE, so I guess it's
> > checking that the return value isn't 3 or something. Not very useful,
> > sure, but it looked odd to just have a series of sndPlaySound
Andrew Eikum wrote:
> > > > > +br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
> > > > > SND_ALIAS_ID|SND_SYNC);
> > > > > +ok(br == TRUE || br == FALSE, "sndPlaySound gave strange return:
> > > > > %u\n", br);
> > > >
> > > > This kind of test is broken.
> > > >
> > >
> > > Car
On Wed, Dec 05, 2012 at 11:06:48PM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
>
> > > > +br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
> > > > SND_ALIAS_ID|SND_SYNC);
> > > > +ok(br == TRUE || br == FALSE, "sndPlaySound gave strange return:
> > > > %u\n", br);
> > >
>
Andrew Eikum wrote:
> > > +br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
> > > SND_ALIAS_ID|SND_SYNC);
> > > +ok(br == TRUE || br == FALSE, "sndPlaySound gave strange return:
> > > %u\n", br);
> >
> > This kind of test is broken.
> >
>
> Care to elaborate? Being this terse hel
On Wed, Dec 05, 2012 at 11:59:01AM +0800, Dmitry Timoshkov wrote:
> Andrew Eikum wrote:
>
> > +br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
> > SND_ALIAS_ID|SND_SYNC);
> > +ok(br == TRUE || br == FALSE, "sndPlaySound gave strange return:
> > %u\n", br);
>
> This kind of test is
On 5 December 2012 05:35, Francois Gouget wrote:
> The --directory option is not meant to specify where the Git repository lives.
> ---
>
> I'm not sure how it worked before. Maybe this use of the --directory
> option worked by chance but git changed and broke it.
>
Alternatively you could set GIT
Alex Henrie writes:
> Far from not addressing any of these issues, I feel that I have
> addressed all of them. More importantly, my implementation is correct;
> it matches Windows XP exactly.
You have nowhere near enough tests to make such a claim. When I said to
write more tests, I didn't mean
On 05.12.2012 09:07, Nozomi Kodama wrote:
Hello
any problems with the patches
http://source.winehq.org/patches/data/91986
http://source.winehq.org/patches/data/91985
http://source.winehq.org/patches/data/91984
Best regards,
Nozomi
91985/6:
+for (i = 0; i < order; i++)
+{
+s
David Laight wrote:
> > I think encoding and decoding in UTF-7 arbitrary binary data was
> > considered a "feature" in Windows XP. As MSDN said, "Code written in
> > earlier versions of Windows that rely on this behavior to encode
> > random non-text binary data might run into problems." So I'm s
Hello
any problems with the patches
http://source.winehq.org/patches/data/91986
http://source.winehq.org/patches/data/91985
http://source.winehq.org/patches/data/91984
Best regards,
Nozomi
On Tue, Dec 04, 2012 at 08:30:55PM -0700, Alex Henrie wrote:
> 2012/12/4 Fr?d?ric Delanoy :
> > The above MSDN comment indicates pre-Vista versions are buggy, so it's
> > probably not a good idea to match that behaviour.
>
> I think encoding and decoding in UTF-7 arbitrary binary data was
> consid
19 matches
Mail list logo
