Re: [PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-12-04 Thread Alex Henrie
Correction: Item 3 should have been "Put the code in kernel32." -Alex

Re: [PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-12-04 Thread Alex Henrie
2012/12/4 Alexandre Julliard : > Alex Henrie writes: > >> My implementation is modeled after Windows XP (Wine's default target >> Windows version), which encodes and decodes arbitrary character >> sequences without normalization. I saw that my submission has already >> been marked "rejected"--was

Re: [PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-12-04 Thread Alex Henrie
2012/12/4 Frédéric Delanoy : > The above MSDN comment indicates pre-Vista versions are buggy, so it's > probably not a good idea to match that behaviour. I think encoding and decoding in UTF-7 arbitrary binary data was considered a "feature" in Windows XP. As MSDN said, "Code written in earlier ve

Re: [PATCH] winmm: Don't mask out SND_ALIAS_ID or SND_FILENAME in sndPlaySound

2012-12-04 Thread Dmitry Timoshkov
Andrew Eikum wrote: > +br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK, > SND_ALIAS_ID|SND_SYNC); > +ok(br == TRUE || br == FALSE, "sndPlaySound gave strange return: %u\n", > br); This kind of test is broken. -- Dmitry.

[PATCH] dsound: Use event based threads

2012-12-04 Thread Joerg-Cyril.Hoehle
Hi, Maarten Lankhorst wrote: >Alsa's native period is ~ 22ms (1024 samples / 44100 or 48000) with dmix >despite claiming it to be otherwise.. What I don't understand is why you talk about ALSA at this level. DSound talks to mmdevapi and that's DSound's underlying API, not ALSA. So if Wine's mmd

Re: [2/3] gdiplus: If a 32-bit dib is selected in an hdc, use the dib directly.

2012-12-04 Thread Alexandre Julliard
Vincent Povirk writes: > Does that mean there's no way to access the bits directly given a DIB object? If you don't know how it was created, then no. > I think we do it line by line so that we don't rely on > GdipCreateBitmapFromScan0 to create the bitmap with a particular > stride. I guess we

Re: [2/3] gdiplus: If a 32-bit dib is selected in an hdc, use the dib directly.

2012-12-04 Thread Vincent Povirk
>>> you won't get a negative height with GetObject, >> >> Hmm, is GdipCreateBitmapFromHBITMAP doing it right, then? It assumes >> all DIB objects have positive stride. > > No, that's wrong. It should most likely just do a GetDIBits (in one go, > not line by line like it currently does). Does that

Re: [2/3] gdiplus: If a 32-bit dib is selected in an hdc, use the dib directly.

2012-12-04 Thread Alexandre Julliard
Vincent Povirk writes: >> you won't get a negative height with GetObject, > > Hmm, is GdipCreateBitmapFromHBITMAP doing it right, then? It assumes > all DIB objects have positive stride. No, that's wrong. It should most likely just do a GetDIBits (in one go, not line by line like it currently do

Re: [2/3] gdiplus: If a 32-bit dib is selected in an hdc, use the dib directly.

2012-12-04 Thread Vincent Povirk
> It assumes all DIB objects have positive stride. Sorry, I misread, that's assuming a negative stride.

Re: [2/3] gdiplus: If a 32-bit dib is selected in an hdc, use the dib directly.

2012-12-04 Thread Vincent Povirk
> you won't get a negative height with GetObject, Hmm, is GdipCreateBitmapFromHBITMAP doing it right, then? It assumes all DIB objects have positive stride. > you won't get DIB info at all for DDBs. I don't think it makes sense to do this for DDBs, as I can't draw them directly and don't expect

Re: mshtml: Added support for converting (some) argument types in builtin function calls using script engine

2012-12-04 Thread Jacek Caban
Hi Marvin, On 12/04/12 15:14, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, Yeah, I can see that... > so I might be wrong, but could you please double-check? Sure, there you go:

Re: mshtml: Added support for converting (some) argument types in builtin function calls using script engine

2012-12-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23216 Your paranoid android

winepulse test data review

2012-12-04 Thread Joerg-Cyril.Hoehle
Hi, Maarten Lankhorst wrote: >Actually in winepulse, sleep / 12000 (8 ms I guess?) ms would work, no sleep >at all works too, Yes, I wanted to go no further than 8ms below the 10ms period limit. > it was just the mixing of various levels of sleep that was failing. Not sure > why though, > might

winepulse test data review

2012-12-04 Thread Joerg-Cyril.Hoehle
Maarten Lankhorst wrote: >> That was about the relationship between GCP and GetPosition. Now what >> about GetPosition and wall time (as seen by the HighPerformanceTimer)? >> The largest delta is 8ms, which suggests that your GetPosition is not >> particularly regular, but as it stays below one 1

Re: [PATCH 1/5] [WineHelp]: added basic infrastructure for a new wineconsole mode: line

2012-12-04 Thread Frédéric Delanoy
On Mon, Dec 3, 2012 at 10:12 PM, Eric Pouech wrote: > diff --git a/programs/wineconsole/line.c b/programs/wineconsole/line.c > new file mode 100644 > index 000..4b7fd29 > --- /dev/null > +++ b/programs/wineconsole/line.c > @@ -0,0 +1,334 @@ > +/* > + * a GUI application for displaying a consol

Re: [2/3] gdiplus: If a 32-bit dib is selected in an hdc, use the dib directly.

2012-12-04 Thread Alexandre Julliard
Vincent Povirk writes: > @@ -2264,6 +2266,41 @@ GpStatus WINGDIPAPI GdipCreateFromHDC2(HDC hdc, HANDLE > hDevice, GpGraphics **gra > if(graphics == NULL) > return InvalidParameter; > > +hbm = GetCurrentObject(hdc, OBJ_BITMAP); > +if (hbm && GetObjectW(hbm, sizeof(dib), &d

Re: [PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-12-04 Thread Alexandre Julliard
Alex Henrie writes: > My implementation is modeled after Windows XP (Wine's default target > Windows version), which encodes and decodes arbitrary character > sequences without normalization. I saw that my submission has already > been marked "rejected"--was this why? It was rejected because you

Re: wshom: Basic support for REG_SZ values in RegRead() (try2)

2012-12-04 Thread Jacek Caban
Hi Nikolay, On 12/04/12 10:33, Nikolay Sivov wrote: > +if (name[len] != '\\') > +return HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND); > +/* skip '\' after root name */ > +len++; > + > +/* at this point we have at least one '\' in path */ > +val = strrchrW(name, '\\'); > +

Re: wshom: Basic support for REG_SZ values in RegRead()

2012-12-04 Thread Nikolay Sivov
On 12/3/2012 15:42, Jacek Caban wrote: Hi Nikolay, On 12/03/12 12:29, Nikolay Sivov wrote: +/* skip '\' after root name */ +if (name[len] == '\\') len++; It looks like if name[len] != '\\', then name should be considered invalid. + +val = strlenW(name); +while (name[--val] !=

Re: [PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-12-04 Thread Frédéric Delanoy
On Tue, Dec 4, 2012 at 5:30 AM, Alex Henrie wrote: > 2012/12/2 Dmitry Timoshkov : >> Also you probably need to add support for composition/ >> surrogates like other implementations do. > > MSDN states: > > "Starting with Windows Vista, this function fully conforms with the > Unicode 4.1 specificat

Re: [PATCH] ddraw: Create a dynamic buffer if DDLOCK_DISCARDCONTENTS is used

2012-12-04 Thread Rico Schüller
On 03.12.2012 23:11, Stefan Dösinger wrote: +DWORD pool = buffer->Caps & D3DVBCAPS_SYSTEMMEMORY ? WINED3D_POOL_SYSTEM_MEM : WINED3D_POOL_DEFAULT; ... +return wined3d_buffer_create_vb(buffer->ddraw->wined3d_device, +buffer->size, usage, pool, buffer, &ddraw_null_wined3d_parent_o