Re: [PATCH] cabarc: Display message when extracting cab like in native.

2012-11-30 Thread Alexandre Julliard
Christian Costa writes: > Ok. I will use WINE_TRACE instead. So that would be better to remove > -v > option and turn all printf > dependant of this option to WINE_TRACE, right ? Of course not. Debug options are for debugging the app, -v is for normal users who want to see the details of what i

Re: [PATCH] cabarc: Display message when extracting cab like in native.

2012-11-30 Thread Christian Costa
Le 30/11/2012 23:12, Alexandre Julliard a écrit : Christian Costa writes: Le 30/11/2012 11:58, Alexandre Julliard a écrit : Christian Costa writes: @@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] ) argv[--argc] = NULL; } } -retur

Re: [PATCH] cabarc: Display message when extracting cab like in native.

2012-11-30 Thread Alexandre Julliard
Christian Costa writes: > Le 30/11/2012 11:58, Alexandre Julliard a écrit : >> Christian Costa writes: >> >>> @@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] ) >>> argv[--argc] = NULL; >>> } >>> } >>> -return extract_cabinet( buffer ); >>

Re: [PATCH] cabarc: Display message when extracting cab like in native.

2012-11-30 Thread Christian Costa
Le 30/11/2012 11:58, Alexandre Julliard a écrit : Christian Costa writes: @@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] ) argv[--argc] = NULL; } } -return extract_cabinet( buffer ); +WINE_MESSAGE("Extracting file(s) from cabin

Re: kernel32: Implement SetFileValidData.

2012-11-30 Thread Alexandre Julliard
Hans Leidekker writes: > --- > configure.ac |1 + > dlls/kernel32/file.c | 12 +++- > dlls/kernel32/tests/file.c | 136 > > dlls/ntdll/file.c | 27 + > include/ddk/ntddk.h|5 ++ > include/winb

Re: [PATCH] dsound: Use event based threads

2012-11-30 Thread Andrew Eikum
On Thu, Nov 29, 2012 at 12:50:20PM +0100, Maarten Lankhorst wrote: > Op 21-11-12 19:16, Maarten Lankhorst schreef: > > Signed-off-by: Maarten Lankhorst > > > Bump, anything wrong with this patch? > Been spending my "Wine time" on Bug 32297 this week. I'll take a look at this shortly. Andrew

Re: [PATCH 4/6] jscript: Added support for DontDelete attribute and use it for arguments object

2012-11-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23168 Your paranoid android

Re: [PATCH 1/6 try2] jscript: Alias arguments properties to real values

2012-11-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23167 Your paranoid android

Re: [PATCH 6/6] jscript: Added support for indexed string access

2012-11-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23169 Your paranoid android

Re: [PATCH] cabarc: Display message when extracting cab like in native.

2012-11-30 Thread Alexandre Julliard
Christian Costa writes: > @@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] ) > argv[--argc] = NULL; > } > } > -return extract_cabinet( buffer ); > +WINE_MESSAGE("Extracting file(s) from cabinet %s\n", > wine_dbgstr_a(cab_file)); > +