Perhaps I should add that the list is of caseS/defaultS that may be fallen
through to, rather than out from.
Unfortunately,because I produced it in a hurry, it does contain the odd
copy-and-paste error for case names (e.g., the case for dmusic/collection.c
line 409 should be default:, not case 8:,
André Hentschel wrote:
> diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c
> index c670731..f66d858 100644
> --- a/dlls/ntdll/tests/info.c
> +++ b/dlls/ntdll/tests/info.c
> @@ -1336,7 +1336,8 @@ static void test_mapprotection(void)
> status = pNtQueryVirtualMemory( GetCurrentPro
Vincent Povirk wrote:
> It might be useful to post a listing of the files where unmarked
> fall-throughs (falls-through?) appear, and I could see if any of them
> are on my turf.
Here is a rough-and-ready list of where they are.
dlls/msvcp100/exception.c (line 498) case EXCEPTION:
dlls/msvcp100/
Jacek Caban wrote:
> It's probably better to change the macro to require the semicolon.
>
> Jacek
The reason I did it that way was because there are two variants of the
DEFINE_CXX_DATA macro, surrounded by an #ifndef construct: one comprising
three struct declarations, all ending in semicolons,
It might be useful to post a listing of the files where unmarked
fall-throughs (falls-through?) appear, and I could see if any of them
are on my turf.
On 11/26/12 8:42 PM, Andrew Talbot wrote:
Changelog:
msvcp60: Remove superfluous semicolons.
diff --git a/dlls/msvcp60/exception.c b/dlls/msvcp60/exception.c
index 761075e..b8c6921 100644
--- a/dlls/msvcp60/exception.c
+++ b/dlls/msvcp60/exception.c
@@ -137,7 +137,7 @@ void * __thiscall MSV
Frédéric Delanoy wrote:
> For every wine version, static checkers (like coverity) detect cases
> where a switch case automatically falls-through to the next case.
>
> Shouldn't be there a rule that such cases are always marked with a
> "fall-through comment"?
> With the possible exception of case
"Erich E. Hoover" writes:
> This particular patch implements SetNamedSecurityInfoW by layering it
> on top of SetSecurityInfo, which permits the creation of tests for
> part 2 (GetNamedSecurityInfoW). This version has been updated to fix
> a bad return value and includes a test indicating the co
On Mon, Nov 26, 2012 at 8:54 AM, Nikolay Sivov wrote:
> On 11/26/2012 01:01, Frédéric Delanoy wrote:
>>
>> ---
>> dlls/ole32/filemoniker.c | 44
>> ++--
>> 1 file changed, 18 insertions(+), 26 deletions(-)
>>
>> diff --git a/dlls/ole32/filemoniker.c b/dll
