Re: [PATCH 4/5] [kernel] Support opening of console for read (try 2)

On 20 November 2012 12:31, Alexandre Julliard wrote: > > That doesn't guarantee that it's the process console, console handles > can be passed across processes. > > So apologies if this is an ignorant question, I dont really understand this console logic properly so I was researching the options.

Re: imm32: use SendMessage not PostMessage for the Default IME winproc

On 12/11/06 9:38, Henri Verbeet wrote: > On 6 November 2012 15:41, Aric Stewart wrote: >> >> This allows the calling program to properly get the return codes from the >> messages when they need them. >> Also prevent all of the calls for IME messages in that windproc from falling >> back through

Re: [PATCH 4/5] [kernel] Support opening of console for read (try 2)

Le 20/11/2012 13:31, Alexandre Julliard a écrit : Eric Pouech writes: That doesn't look right. There's no guarantee that the handle is for the current process console. in fact, it's guaranted, because we check before (in the function calling this helper) that the handle is really a console ha

Re: [PATCH 2/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida.

Hello, On Wed, Nov 21, 2012 at 2:53 AM, Alexandre Julliard wrote: > Still no luck I'm afraid: > Sorry for the failure, I guess there are some fonts installed on your system but not on my system, could you run the test in interactive mode and send the full log to me so I can see on what font it fa

Re: [PATCH 2/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida.

Qian Hong writes: > - No change from try 4. > > --- > dlls/usp10/tests/usp10.c | 156 > ++ > 1 file changed, 156 insertions(+) Still no luck I'm afraid: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && tou

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

Jacek Caban writes: > Yeah, that's why I hope at some point we will obsolete NT4 just like > we did with Win9x, but that's a subject for separated discussion. Let's > concentrate on skipping individual tests for now. We can probably retire NT4 when we switch to the new testbot. -- Alexandre Ju

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

On 11/20/12 16:00, Ann and Jason Edmeades wrote: > On 20 November 2012 12:15, Jacek Caban > wrote: > > On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote: > > (I'll make this change in try 2, as I need to fix the broken > NT4 stuff from patch 1 any

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

On 20 November 2012 12:15, Jacek Caban wrote: > On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote: > >> (I'll make this change in try 2, as I need to fix the broken NT4 stuff >> from patch 1 anyway) >> > > I think it's time to consider skipping all cmd tests on NT4. Adding > @or_broken@ for NT4

Re: wineqtdecoder: properly clean up splitter and loader threads on QTSplitter destruction

On 12/11/20 5:29, Alexandre Julliard wrote: > Aric Stewart writes: > >> @@ -495,9 +518,14 @@ static DWORD WINAPI QTSplitter_loading_thread(LPVOID >> data) >> to try to minimize that. >>*/ >> >> -while(GetMovieLoadState(This->pQTMovie) < kMovieLoadStateComplet

Re: [PATCH 2/2] winmm: Fix handling of mmio file buffers.

Akihiro Sagawa writes: > This fix bug 19566 and 32013. > --- > dlls/winmm/mmio.c | 31 +-- > dlls/winmm/tests/mmio.c | 16 > 2 files changed, 21 insertions(+), 26 deletions(-) It doesn't work on 64-bit: ../../../../wine/tools/runtest -q -P

Re: [PATCH 4/5] [kernel] Support opening of console for read (try 2)

Eric Pouech writes: >> That doesn't look right. There's no guarantee that the handle is for the >> current process console. > in fact, it's guaranted, because we check before (in the function > calling this helper) that the handle is really a console handler and > that it's in bare mode > one cou

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote: (I'll make this change in try 2, as I need to fix the broken NT4 stuff from patch 1 anyway) I think it's time to consider skipping all cmd tests on NT4. Adding @or_broken@ for NT4 mostly pollutes those tests. Jacek

Re: [PATCH 4/5] [kernel] Support opening of console for read (try 2)

> That doesn't look right. There's no guarantee that the handle is for the > current process console. in fact, it's guaranted, because we check before (in the function calling this helper) that the handle is really a console handler and that it's in bare mode one could make it clearer by adding a c

Re: wineqtdecoder: properly clean up splitter and loader threads on QTSplitter destruction

Aric Stewart writes: > @@ -495,9 +518,14 @@ static DWORD WINAPI QTSplitter_loading_thread(LPVOID > data) > to try to minimize that. > */ > > -while(GetMovieLoadState(This->pQTMovie) < kMovieLoadStateComplete) > +while(This->pQTMovie && GetMovieLoadState(T

Re: [PATCH 4/5] [kernel] Support opening of console for read (try 2)

Ann and Jason Edmeades writes: > +BOOL WINAPI write_console_input( HANDLE handle, const INPUT_RECORD *buffer, > + DWORD count, LPDWORD written ) > +{ > +BOOL result = WriteConsoleInputW(handle, buffer, count, written); > + > +/* If this fails with access de