Re: [PATCH 1/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida (try 3).

2012-11-16 Thread Qian Hong
Hello, On Sat, Nov 17, 2012 at 1:03 AM, Alexandre Julliard wrote: > The test fails: > > ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p > usp10_test.exe.so usp10.c && touch usp10.ok > usp10.c:1958: Test failed: wgBlank tmBreakChar 0020 > usp10.c:1958: Test failed: wgBlank

Re: [PATCH 2/7] advapi: Implement SetNamedSecurityInfoW on top of SetSecurityInfo (resend 3).

2012-11-16 Thread Alexandre Julliard
"Erich E. Hoover" writes: > +hfile = CreateFileW( pObjectName, access, > FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, > + NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, 0 > ); > +if (hfile == INVALID_HANDLE_VALUE) > +return FALSE; FALSE doesn't

Re: [PATCH 1/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida (try 3).

2012-11-16 Thread Alexandre Julliard
Qian Hong writes: > - Merge tests functions. > > --- > dlls/usp10/tests/usp10.c | 156 > ++ > 1 file changed, 156 insertions(+) > The test fails: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp1

Re: [2/2] msxml3: Stub support for external entity resolver

2012-11-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22981 Your paranoid android

Re: msi: Fix a couple of leaks (coverity)

2012-11-16 Thread Hans Leidekker
On Fri, 2012-11-16 at 11:50 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/files.c b/dlls/msi/files.c > index 11913ef..98d7513 100644 > --- a/dlls/msi/files.c > +++ b/dlls/msi/files.c > @@ -336,6 +336,7 @@ UINT ACTION_InstallFiles(MSIPACKAGE *package) > if (rc != ERROR_SUCCESS) >

Re: [PATCH 2/4] kernel32: Partial implement CreateHardLinkTransactedA/W

2012-11-16 Thread Alexandre Julliard
Detlef Riekenberg writes: > transaction is ignored for now I don't think that's a good idea, particularly not for DeleteFile. -- Alexandre Julliard julli...@winehq.org