Re: [PATCH] amstream: Initialize correctly AM_MEDIA_TYPE struct.

2012-11-15 Thread Christian Costa
Le 16/11/2012 00:24, Michael Stefaniuc a écrit : Hello Christian, On 11/15/2012 09:43 AM, Christian Costa wrote: Fixes bug 32185. --- dlls/amstream/mediastreamfilter.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilte

Re: [PATCH] amstream: Initialize correctly AM_MEDIA_TYPE struct.

2012-11-15 Thread Michael Stefaniuc
Hello Christian, On 11/15/2012 09:43 AM, Christian Costa wrote: > Fixes bug 32185. > --- > dlls/amstream/mediastreamfilter.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/amstream/mediastreamfilter.c > b/dlls/amstream/mediastreamfilter.c > index 9b2bd8e..d5388e5 100644 > --

Re: [PATCH 1/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida (try 2).

2012-11-15 Thread Qian Hong
Hello, On Fri, Nov 16, 2012 at 3:09 AM, Alexandre Julliard wrote: > There's no need to have two separate tests functions. Thanks for comment, will merge them. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Re: [PATCH 1/2] usp10/tests: Added tests for wgBlank, wgDefault, wgInvalid and wgKashida (try 2).

2012-11-15 Thread Alexandre Julliard
Qian Hong writes: > @@ -3038,6 +3203,7 @@ START_TEST(usp10) > test_ScriptPlace(hdc); > > test_ScriptGetFontProperties(hdc); > +test_ScriptGetFontProperties2(hdc); There's no need to have two separate tests functions. -- Alexandre Julliard julli...@winehq.org

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-15 Thread Hans Leidekker
On Thu, 2012-11-15 at 09:41 +0100, Stefan Leichter wrote: > i have to say sorry, this answer is rude. > > But i don't like to do unnecessary iteration on source code especially when > the "complain" has been in the previous version too. Source code usually does > not get better from iteration to

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-15 Thread Stefan Leichter
Wednesday 14 November 2012 Stefan Leichter > Wednesday 14 November 2012 Hans Leidekker > > > On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote: > > > @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, > > > unsigned int len, char *buf ) > > > > > > char c0, c1, c2, c3