Re: wined3d: Use backup swapchain DC for devices created with desktop window. (try 2)

2012-11-14 Thread Jeff Cook
Hello Is there a status update on this patch? I am curious to know if it will be merged, and if not, what correction is needed to make it mergeable. Thanks Jeff On Mon, Sep 3, 2012 at 1:51 PM, Adam Jakubek wrote: > On Mon, Sep 3, 2012 at 6:29 PM, Stefan Dösinger > wrote: >> >> I skimmed bug #1

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-14 Thread Stefan Leichter
Wednesday 14 November 2012 Hans Leidekker > On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote: > > @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, > > unsigned int len, char *buf ) > > > > char c0, c1, c2, c3; > > const WCHAR *p = cred; > > > > +TRACE("%s\n

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-14 Thread Hans Leidekker
On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote: > @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, unsigned > int len, char *buf ) > char c0, c1, c2, c3; > const WCHAR *p = cred; > > +TRACE("%s\n", debugstr_wn(cred,len)); This string is already traced i

Re: fix a too small buffer in CredUnmarshalCredentialW

2012-11-14 Thread Stefan Leichter
Wednesday 14 November 2012 Hans Leidekker > On Wed, 2012-11-14 at 09:48 +0100, Stefan Leichter wrote: > > +char buffer[6]; > > +unsigned int buflen, *size = (unsigned int*) buffer; > > > > -if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || > > !size || size % si

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
On 11/14/2012 10:15 AM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury wrote: > >> Would calculating the total number of 'row' calls and reading each row >> as a 'block in turn be an alternate implementation? > > No, your terminology (what is a "row" in PNG?) shows lack of undertsanding > of wha

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > Would calculating the total number of 'row' calls and reading each row > as a 'block in turn be an alternate implementation? No, your terminology (what is a "row" in PNG?) shows lack of undertsanding of what is a block, or what that APIs are supposed to return. Star

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
On 11/14/2012 09:38 AM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury wrote: > These are currently returning 'not implemented'. Would it make sense to have 'GetCount' always return '1' and have the indexed read simply read in the whole thing? >>> >>> Looks like you don't unde

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > >> These are currently returning 'not implemented'. > >> > >> Would it make sense to have 'GetCount' always return '1' and have the > >> indexed read simply read in the whole thing? > > > > Looks like you don't understand what those APIs do. What's that 'the whole >

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
On 11/14/2012 07:03 AM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury wrote: > >> These are currently returning 'not implemented'. >> >> Would it make sense to have 'GetCount' always return '1' and have the >> indexed read simply read in the whole thing? > > Looks like you don't understand what

Re: Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > These are currently returning 'not implemented'. > > Would it make sense to have 'GetCount' always return '1' and have the > indexed read simply read in the whole thing? Looks like you don't understand what those APIs do. What's that 'the whole thing'? -- Dmitry.

Implementation of PNG 'Get Count' and indexed reads...

2012-11-14 Thread Max TenEyck Woodbury
These are currently returning 'not implemented'. Would it make sense to have 'GetCount' always return '1' and have the indexed read simply read in the whole thing?

Re: fix a too small buffer in CredUnmarshalCredentialW

2012-11-14 Thread Hans Leidekker
On Wed, 2012-11-14 at 09:48 +0100, Stefan Leichter wrote: > +char buffer[6]; > +unsigned int buflen, *size = (unsigned int*) buffer; > > -if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || !size > || size % sizeof(WCHAR)) > +if (len < 9 || !cred_decode(

Re: [PATCH] netapi32/tests: Fix workstation test failures on XP

2012-11-14 Thread Saulius Krasuckas
* On Tue, 13 Nov 2012, Detlef Riekenberg wrote: > The workstation service might not running > > http://test.winehq.org/data/b5d96da32f955357b7d9341ee9fca68108078dce/xp_s2-sp2-nosnd/netapi32:wksta.html Indeed it isn't. I've disabled serveral services on this box. > --- a/dlls/netapi32/tests/wks