Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient. (try 3)

2012-11-13 Thread Christian Costa
Le 13/11/2012 23:07, Marvin a écrit : Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDet

Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient. (try 3)

2012-11-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22927 Your paranoid android

Re: [PATCH 2/2] usp10: Fixed wgBlank, wgDefault, wgInvalid and wgKashida.

2012-11-13 Thread Qian Hong
Hello, Thanks for comment too! On Wed, Nov 14, 2012 at 3:25 AM, Nikolay Sivov wrote: > I think it's better to avoid macros if possible. >> Got it. >> +if (!sc->sfnt) >> +{ >> +if (GetTextMetricsW(hdc, &tmW)) >> +sc->sfp.wgBlank = tmW.tmBreakChar; >> +else >>

Re: [PATCH 2/2] usp10: Fixed wgBlank, wgDefault, wgInvalid and wgKashida.

2012-11-13 Thread Qian Hong
Hello, On Wed, Nov 14, 2012 at 2:22 AM, Alexandre Julliard wrote: > There's no reason to add #defines for that kind of thing, just put the > values in the string directly. Thanks for comment, will remove these #defines. -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Re: [PATCH 2/2] usp10: Fixed wgBlank, wgDefault, wgInvalid and wgKashida.

2012-11-13 Thread Nikolay Sivov
On 11/13/2012 18:20, Qian Hong wrote: Thanks Aric! --- dlls/usp10/usp10.c | 133 +-- dlls/usp10/usp10_internal.h |1 + 2 files changed, 128 insertions(+), 6 deletions(-) I think it's better to avoid macros if possible. +if (!sc->sfn

Re: [PATCH 2/2] usp10: Fixed wgBlank, wgDefault, wgInvalid and wgKashida.

2012-11-13 Thread Alexandre Julliard
Qian Hong writes: > +static inline void set_cache_invalid_char(const HDC hdc, ScriptCache *sc) > +{ > +#define Zero_width_space 0x200b /* Zero Width Space */ > +#define Invalid_char3 0xf71b /* Unknow, found by black box testing */ > +#define NON_EXIST_INDEX 0x /* Default non exist char in

Re: Missing dependencies on static libraries

2012-11-13 Thread Alexandre Julliard
Francois Gouget writes: > On Mon, 12 Nov 2012, Alexandre Julliard wrote: >> In theory yes, but that would have to be auto-generated. In practice >> only strmbase should matter. > > I'm not sure how to auto-generate it. Would something that looks like > this be ok: > > In Makefile.in: > > STATICI

Re: [PATCH 3/6] dsound: create a primary_pwfx separately from pwfx

2012-11-13 Thread Maarten Lankhorst
Hey, Op 19-10-12 15:29, Andrew Eikum schreef: > Patches 1 and 2 in this series look fine. > > I have a series of patches similar to this one in my dsound > multichannel branch. This patch seems to do too much at once. > > When I did this cleanup, I split it up into four patches: > 1) Allocate the

Re: Missing dependencies on static libraries

2012-11-13 Thread Francois Gouget
On Mon, 12 Nov 2012, Alexandre Julliard wrote: [...] > > Would somthing like the patch below be acceptable? > > Should it be generalized to all the dependencies on uuid, dxguid, etc? > > In theory yes, but that would have to be auto-generated. In practice > only strmbase should matter. I'm not su

Re: [PATCH 2/2] gdi32: Added GetGlyphOutlineW tests on glyph that contains empty contour (try3)

2012-11-13 Thread Alexandre Julliard
Piotr Caban writes: > On 11/13/12 13:10, Dmitry Timoshkov wrote: >> Piotr Caban wrote: >> >>>create mode 100644 dlls/gdi32/tests/test_empty_contour.sfd >>>create mode 100644 dlls/gdi32/tests/test_empty_contour.ttf >> >> Is it possible to add the desired glyph to an already existing test

Re: [PATCH 2/2] gdi32: Added GetGlyphOutlineW tests on glyph that contains empty contour (try3)

2012-11-13 Thread Piotr Caban
On 11/13/12 13:10, Dmitry Timoshkov wrote: Piotr Caban wrote: create mode 100644 dlls/gdi32/tests/test_empty_contour.sfd create mode 100644 dlls/gdi32/tests/test_empty_contour.ttf Is it possible to add the desired glyph to an already existing test font? Yes, I was adding it first to w

Re: [PATCH 2/2] gdi32: Added GetGlyphOutlineW tests on glyph that contains empty contour (try3)

2012-11-13 Thread Dmitry Timoshkov
Piotr Caban wrote: > create mode 100644 dlls/gdi32/tests/test_empty_contour.sfd > create mode 100644 dlls/gdi32/tests/test_empty_contour.ttf Is it possible to add the desired glyph to an already existing test font? -- Dmitry.

Re: Any advice please... Console input issue

2012-11-13 Thread Eric Pouech
> I tested the following > HANDLE hConRW = CreateFileA("CONIN$" > , GENERIC_READ | GENERIC_WRITE, > FILE_SHARE_READ, NULL, OPEN_EXISTING, > FILE_ATTRIBUTE_NORMAL, 0); > if (hConRW == INVALID_H

Re: [PATCH] wininet: handle failing create_netconn_socket (Coverity)

2012-11-13 Thread Alexandre Julliard
Marcus Meissner writes: > A failing here will free the netconn structure and we should > not use it afterwards. It probably shouldn't free it, this can break in other places too. -- Alexandre Julliard julli...@winehq.org