Re: gdiplus image blitting performance status

2012-11-12 Thread Vincent Povirk
I should've known you'd have an app where it matters. > I suspect that generating an intermediate RGBA image in the process > of drawing should be avoided when source or destination bitmaps have no > alpha. I think we can get away with that if the source has no alpha, which isn't the case for ind

Re: gdiplus image blitting performance status

2012-11-12 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I'm still primarily concerned with getting all of the features in > place and behaving correctly first. Performance isn't a concern for > me, but if someone points out a real app where it is an issue then I > may be more interested. I have an application which generates t

Re: [PATCH 7/9] ieframe: Forward more DocHost::Exec calls to embedders

2012-11-12 Thread Alexandre Julliard
Francois Gouget writes: > We can potentially change the criteria that TestBot uses to decide > whether to skip. But what should these be here? Also, do they really > belong in WineTestBot, which would likely require duplicating that code > to WineTest too, or should the skipping really be done

Re: Any advice please... Console input issue

2012-11-12 Thread Ann and Jason Edmeades
Hi Eric, Thanks for taking the time to reply The issue is that WriteConsoleInputW requires GENERIC_WRITE access, but the >> CON device (\\.\CON) was opened as GENERIC_READ (and in fact fails if I try >> to open it with GENERIC_WRITE). > > You said... > - you're using a bare console, ie didn't run

Re: wine.inf: Set the FontSmoothingGamma value.

2012-11-12 Thread Hans Leidekker
On Mon, 2012-11-12 at 21:16 +0100, Alexandre Julliard wrote: > > Fixes a crash in the .NET 4 runtime which queries this value via > > SystemParametersInfo(SPI_GETFONTSMOOTHINGCONTRAST). > > It shouldn't need the registry key to behave sanely. Does b5d96da32f > help? Yes.

Re: wine.inf: Set the FontSmoothingGamma value.

2012-11-12 Thread Alexandre Julliard
Hans Leidekker writes: > Fixes a crash in the .NET 4 runtime which queries this value via > SystemParametersInfo(SPI_GETFONTSMOOTHINGCONTRAST). It shouldn't need the registry key to behave sanely. Does b5d96da32f help? -- Alexandre Julliard julli...@winehq.org

Re: We're in at FOSDEM!

2012-11-12 Thread Jeremy White
> We should stay in the same hotel if possible to ease gathering. > Did someone already choose one? Could You make a special arrangement again > (like in Paris, IIRC)? No, we haven't yet picked a hotel. I was poking around a bit; looks like it's not obvious. I see that other projects have varyi

Re: [advapi32/tests] fix possible NULL pointer dereference

2012-11-12 Thread Alexandre Julliard
Stefan Leichter writes: > fixes the crash > http://test.winehq.org/data/1262f07609e6722a841f511445f145d941848800/linux_arm- > sle85276/advapi32:cred.html That's not supposed to happen, please fix the code instead. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 2/2] gdi32: Added GetGlyphOutlineW tests on glyph that contains empty contour (try2)

2012-11-12 Thread Alexandre Julliard
Piotr Caban writes: > @@ -23,6 +23,8 @@ > /* @makedep: wine_test.ttf */ > wine_test.ttf RCDATA wine_test.ttf > > - > /* @makedep: vertical.ttf */ > vertical.ttf RCDATA vertical.ttf > + > +/* @makedep: test_ttf.ttf */ > +test_ttf.ttf RCDATA test_ttf.ttf Please choose a more meaningful name

Re: Wine and multiarch on Debian Testing

2012-11-12 Thread Francois Gouget
On Mon, 12 Nov 2012, Nicolas Le Cam wrote: [...] > #677885, #678040, #678070, #678895 and #678898 already contains trivial > patches, I did check packages on every offered architectures to see if file > differs, I can recheck if necessary. Yes. It's thanks to your work either checking that there's

Re: mciavi: Fix player deadlock when starting to play.

2012-11-12 Thread Andrew Eikum
Seems reasonable to me. Thanks for working on this old code. On Thu, Nov 08, 2012 at 10:51:08AM +0100, joerg-cyril.hoe...@t-systems.com wrote: >

Re: gdiplus image blitting performance status

2012-11-12 Thread Vincent Povirk
I'm still primarily concerned with getting all of the features in place and behaving correctly first. Performance isn't a concern for me, but if someone points out a real app where it is an issue then I may be more interested. I agree that image drawing is far enough along that we can start to opt

Re: [PATCH 7/9] ieframe: Forward more DocHost::Exec calls to embedders

2012-11-12 Thread Francois Gouget
On Mon, 12 Nov 2012, Jacek Caban wrote: > On 11/12/12 13:21, Marvin wrote: [...] > > === W2KPROSP4 (32 bit webbrowser) === > > webbrowser.c:2596: Test failed: expected GetOverridesKeyPath > > webbrowser.c:2601: Test failed: expected Invoke_SETSECURELOCKICON > > webbrowser.c:2602: Test failed: expe

Re: Wine and multiarch on Debian Testing

2012-11-12 Thread Nicolas Le Cam
2012/11/12 Francois Gouget > On Wed, 17 Oct 2012, Erich E. Hoover wrote: > > > I just upgraded to 12.04, until they fix the "32-bit headers problem" > > you'll have to manually create the symbolic links for the "-dev" > > package behavior: > > I ran into pretty much the same set of problems with

Re: [PATCH 7/9] ieframe: Forward more DocHost::Exec calls to embedders

2012-11-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22897 Your paranoid android

Re: [PATCH 9/9] ieframe: Added IWebBrowser2::Refresh tests

2012-11-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22898 Your paranoid android

Re: [PATCH 7/9] ieframe: Forward more DocHost::Exec calls to embedders

2012-11-12 Thread Jacek Caban
On 11/12/12 13:21, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: Missing dependencies on static libraries

2012-11-12 Thread Alexandre Julliard
Francois Gouget writes: > strmbase is a static library which is used by amstream, qcap, quartz and > others. This means functions defined in strmbase end up being included > in amstream.dll.so and other places. > > However modifying the strmbase code does not result in a relink of the > dlls t

gdiplus image blitting performance status

2012-11-12 Thread Dmitry Timoshkov
Hi all, I've written a simple test application to measure gdiplus performace. Although currently it tests only GdipDrawImage() it could be easily extended to test anything else if desired. I'm attaching the test source with results running 32-bit test binary with gdiplus=b and gdiplus=n (taken fr

Re: user32: Initialize string buffer

2012-11-12 Thread Alistair Leslie-Hughes
Hi Nikolay, On 12/11/2012 8:39 PM, Nikolay Sivov wrote: On 11/12/2012 11:33, Alistair Leslie-Hughes wrote: Hi, Should fix http://bugs.winehq.org/show_bug.cgi?id=28797 Changelog: user32: Initialize string buffer I think it could be GetWindowText problem actually, if it succeeded and left

Re: user32: Initialize string buffer

2012-11-12 Thread Nikolay Sivov
On 11/12/2012 11:33, Alistair Leslie-Hughes wrote: Hi, Should fix http://bugs.winehq.org/show_bug.cgi?id=28797 Changelog: user32: Initialize string buffer I think it could be GetWindowText problem actually, if it succeeded and left buffer uninitialized that could be a real bug here, so ne

Re: [PATCH] includes: always add __force_align_arg_pointer__ for i386

2012-11-12 Thread David Laight
On Mon, Nov 12, 2012 at 09:25:57AM +0800, Dmitry Timoshkov wrote: > Maarten Lankhorst wrote: > > > Fixes flstudio installer on my system, which breaks otherwise in > > strcasestr_sse42_nonascii > > due to stack being misaligned. > > That's a compiler bug: http://bugs.winehq.org/show_bug.cgi?id=