Re: shell32: Increase dde_connect res value

> http://bugs.winehq.org/show_bug.cgi?id=26830 is easily solved by > http://bugs.winehq.org/attachment.cgi?id=34184 but I don't know if this will > break anything. I cannot find a reference as to why it needs to be set to > 256, but there must be a reason for this. The correct solution would be to

Re: scrrun: Implement IDictionary get_HashVal (try 3)

On 11/8/2012 18:44, Piotr Caban wrote: On 11/8/2012 12:31, Alistair Leslie-Hughes wrote: +static LONG create_hash_val(BSTR name) +{ +LONG hash = 0; The create_hash_val function should do the computations on unsigned variable. On 11/08/12 15:26, Nikolay Sivov wrote: On 11/8/2012 12:31, Ali

Re: gdiplus: Store transformation matrix directly in the objects.

Apparently GpMatrix as value type is a thing now. Patch looks good to me.

Re: scrrun: Implement IDictionary get_HashVal (try 3)

On 11/8/2012 12:31, Alistair Leslie-Hughes wrote: +static LONG create_hash_val(BSTR name) +{ +LONG hash = 0; The create_hash_val function should do the computations on unsigned variable. On 11/08/12 15:26, Nikolay Sivov wrote: On 11/8/2012 12:31, Alistair Leslie-Hughes wrote: +static LONG

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

> >>> I was just saying removing the interface name was not a good thing imo > >>> or am I missing something? > >> Right, the interface name needs to be there as it matches the COBJMACROS > >> name. Basically the C macro with a prefix. > > Why? If you really want to keep interface name the better w

Re: [PATCH 2/2] oleaut32: If pointers (ppTLib or pIndex in ITypeInfo2_fnGetContainingTypeLib) are null, we simply ignore it.[resend]

On Thu, Nov 08, 2012 at 06:13:33PM +0400, Tatyana Fokina wrote: > +if(ppTLib) > +{ > *ppTLib = (ITypeLib *)&This->typelib->ITypeLib2_iface; > ICreateTypeLib_AddRef((ICreateTypeLib*)This->typelib); > +} > + > +if(pIndex) > *pIndex = This->typeinfo->typekind >> 16; Ple

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib [try 2]

On Thu, Nov 08, 2012 at 06:13:28PM +0400, Tatyana Fokina wrote: > +hr = CreateTypeLib2(SYS_WIN32, jsdeb, (ICreateTypeLib2 **)&ctl2); > +ok_ole_success(hr, CreateTypeLib2); > + > +hr = ICreateTypeLib2_CreateTypeInfo(ctl2, jsname, TKIND_DISPATCH, &cti); > +ok_ole_success(hr, ICreateTy

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

> > > > >> I was just saying removing the interface name was not a good thing imo >>> or am I missing something? >>> >> Right, the interface name needs to be there as it matches the COBJMACROS >> name. Basically the C macro with a prefix. >> > Why? If you really want to keep interface name the bet

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 11/08/2012 03:44 PM, Christian Costa wrote: > > > 2012/11/8 Michael Stefaniuc > > > On 11/08/2012 01:13 PM, Christian Costa wrote: > > > > > > 2012/11/8 Henri Verbeet

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 11/08/2012 02:50 PM, Nikolay Sivov wrote: > On 11/8/2012 15:41, Michael Stefaniuc wrote: >> On 11/08/2012 01:13 PM, Christian Costa wrote: >>> >>> 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> >>> >>> On 8 November 2012 00:22, Michael Stefaniuc >> > wr

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012/11/8 Michael Stefaniuc > On 11/08/2012 01:13 PM, Christian Costa wrote: > > > > > > 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> > > > > On 8 November 2012 00:22, Michael Stefaniuc > > wrote: > > > But using just the capitalized letters from th

Re: scrrun: Implement IDictionary get_HashVal (try 3)

On 11/8/2012 12:31, Alistair Leslie-Hughes wrote: Hi, Thanks Piotr for your help. Changelog: scrrun: Implement IDictionary get_HashVal +static LONG create_hash_val_float(float fval) +{ +TRACE("val = %f\n", fval); + +if(isinf(fval)) +return 0; + +return (*((DWORD*)&fval)

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 11/8/2012 15:41, Michael Stefaniuc wrote: On 11/08/2012 01:13 PM, Christian Costa wrote: 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> On 8 November 2012 00:22, Michael Stefaniuc mailto:mstef...@redhat.com>> wrote: > But using just the capitalized letters from the name of th

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 11/08/2012 01:13 PM, Christian Costa wrote: > > > 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> > > On 8 November 2012 00:22, Michael Stefaniuc > wrote: > > But using just the capitalized letters from the name of the COM > class as > > a

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 8 November 2012 13:13, Christian Costa wrote: > dmloader_IDirectMusicLoader_Method or dmloader_Method? E.g. "dmloader_QueryInterface()". > I was just saying removing the interface name was not a good thing imo Yeah, I'm just disagreeing.

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012/11/8 Henri Verbeet > On 8 November 2012 00:22, Michael Stefaniuc wrote: > > But using just the capitalized letters from the name of the COM class as > > a prefix and skipping the "Impl" would be in hindsight the better > > standard. There are still 170+ COM interfaces to clean up which is a

Re: [PATCH 1/2] winmm/tests: Add more mmioSeek tests.

On Thu, 8 Nov 2012 11:12:04 +0100, Joerg-Cyril.Hoehle wrote: Hi Jörg, Thank you for your suggestions. I'll improve my patches. > >[PATCH 2/2] winmm: Fix SEEK_END direction of mmio files without buffering. > It's always good in a patch submission to mention what bug it fixes. > Does yours fix bug

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012/11/8 Michael Stefaniuc > On 11/07/2012 06:40 PM, Christian Costa wrote: > > 2012/11/7 Michael Stefaniuc > > > > On 11/07/2012 02:50 PM, Christian Costa wrote: > > > I didn't write this code and I don't like the current name either > > but a > > >

[PATCH 1/2] winmm/tests: Add more mmioSeek tests.

Sagawa San, it's nice to see somebody contribute to winmm! +return; +} That return is line noise. +hmmio = mmioOpen(NULL, &mmio, MMIO_READ); +if (hmmio == NULL) { +win_skip("mmioOpen error %u\n", mmio.wErrorRet); +return; +} AFAIK mmioOpen has

[PATCH 1/3] winmm: Prefer using MMSYSERR_* over AUDCLNT_E_* from mmdevapi. (resend)

Hi, what's up with this patch series? Regards, Jörg Höhle

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

Hello, On Thu, Nov 8, 2012 at 5:53 PM, Dmitry Timoshkov wrote: > What's wrong with having a .reg file with unicode file names and feed > it to reg.exe? Then there is no any need for custom wine.inf patches. Then we have to feed it to reg.exe every time when a new wineprefix created, or did I mis

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 8 November 2012 00:22, Michael Stefaniuc wrote: > But using just the capitalized letters from the name of the COM class as > a prefix and skipping the "Impl" would be in hindsight the better > standard. There are still 170+ COM interfaces to clean up which is a > sizable number regardless of it

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

Qian Hong writes: > Since Wine1.4 we added the 'font replacement' feature to Wine, and > leave the 'font replacement' setting to distribution folks, for > example, Ubuntu's Wine packager has a patch like > 0001-tools-wine.inf.in-Added-font-name-replacement.txt A better approach would be to do th

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

Qian Hong wrote: > I mean, after splitting into two parts, commit the first part to > upstream Wine, and leave the second part to the distribution folks, > just like what we do for > 0001-tools-wine.inf.in-Added-font-name-replacement.txt right now. What's wrong with having a .reg file with unico

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

On Thu, Nov 8, 2012 at 4:04 PM, Qian Hong wrote: > My idea is split the second patch into two parts, the first part is > 0001-tools-wine.inf.in-Added-UTF8-bom-header.txt, the second part is > adding english and localized font name replacement settings without > changing the encoding of wine.inf.in

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

Hello, On Thu, Nov 8, 2012 at 3:25 AM, Alexandre Julliard wrote: > > It's here to support Unicode data in wine.inf, as you noted. However, I > don't think it makes sense to add the BOM unless we actually have > Unicode keys in there. Thanks for explain! Let me make a summary of Bug 32136: Sinc