Re: msi: Fix some leaks (coverity)

On Thu, 2012-11-08 at 01:32 +0100, Frédéric Delanoy wrote: > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index f9ab550..8a6c952 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -5809,7 +5809,16 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, > LPVOID param) > { >

shell32: Increase dde_connect res value

Evening all, http://bugs.winehq.org/show_bug.cgi?id=26830 is easily solved by http://bugs.winehq.org/attachment.cgi?id=34184 but I don't know if this will break anything. I cannot find a reference as to why it needs to be set to 256, but there must be a reason for this. Anyone any ideas? Th

[PATCH 2/2] oleaut32: If pointers (ppTLib or pIndex in ITypeInfo2_fnGetContainingTypeLib) are null, we simply ignore it.

From c4bc53b10a531e389dc36fb29d1f308051f10b49 Mon Sep 17 00:00:00 2001 From: tatyana Date: Wed, 7 Nov 2012 12:24:50 +0400 Subject: [PATCH 5/5] oleaut32: If pointers (ppTLib or pIndex) are null, we simply ignore it (eterbug #8365) --- dlls/oleaut32/typelib2.c | 5 + 1 file changed, 5 inser

Re: [PATCH 2/2] mstask/tests: Add tests for SetTargetComputer [try 2]

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22825 Your paranoid android

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 11/07/2012 06:40 PM, Christian Costa wrote: > 2012/11/7 Michael Stefaniuc > > On 11/07/2012 02:50 PM, Christian Costa wrote: > > I didn't write this code and I don't like the current name either > but a > > method name does not mean anything if you do

Re: [PATCH 1/5] ddraw: Avoid LPDIRECTDRAW.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22823 Your paranoid android

Re: ntdll: Fixed some heap allocation stalls

Steaphan Greene writes: > On 11/03/2012 10:28 AM, Matteo Bruni wrote: >> Speaking of which, it might be a nice followup patch to add some free >> lists usage stats, to get some idea of what different applications do >> in that regard. > > Well, my code instrumentation consisted of fprintf()s, whi

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

Qian Hong writes: > However, in git log I see such a commit: > commit 31ade1eb67e6b55f1b0c09ef7a806cd53652b1e2 > Author: Alexandre Julliard > Date: Wed Mar 21 13:52:43 2007 +0100 > > setupapi: Add support for .inf files in utf-8 format. > > Did I miss anything or was there a reason to add

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012/11/7 Michael Stefaniuc > On 11/07/2012 02:50 PM, Christian Costa wrote: > > > > > > 2012/11/7 Nikolay Sivov bungleh...@gmail.com>> > > > > On 11/7/2012 01:05, Christian Costa wrote: > > > > Le 06/11/2012 22:38, Michael Stefaniuc a écrit : > > > > On 11/06/2012 08:51

Re: [PATCH 1/2] winmm/tests: Add more mmioSeek tests.

Akihiro Sagawa wrote: > +static void test_mmioSeek(void) > +{ > +HMMIO hmmio; > +MMIOINFO mmio; > +LONG end, pos, size = sizeof(RIFF_buf), offset = 16; > +char test_file[MAX_PATH]; > +MMRESULT res; > + > +{ > +/* test memory file */ Please avoid creating nested bl

LPJUNK for COM Interfaces (Was: Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.)

On 11/06/2012 11:05 PM, Christian Costa wrote: >> Sure, separate patch to remove the duplicate name is fine. Just start >> with that as it makes the subsequent COM cleanup patch shorter as it >> cleans up the function header (whitespace and LPJUNK). > That's what I try to do altough I don't clearly

Re: Bug#566351: libgcrypt11: should not change user id as a side effect

On Wed, Nov 7, 2012 at 3:22 AM, Dan Kegel wrote: > After gstreamer, gcrypt is also dropping support for alternative > thread libraries. > Good thing secur32/schannel_gnutls.c doesn't use it. (Right?) > Right. If someone were motivated, we could begin to transition winhttp and wininet to schann

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

Hi Dmitry, On Wed, Nov 7, 2012 at 11:25 AM, Dmitry Timoshkov wrote: > So, how is this supposed to work under Windows? I wrote a test case, to my surprise, Windows doesn't support UTF8 .inf file, no matter with or without BOM. However, Windows support Little-endian UTF-16 Unicode .inf file. The t

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

On 11/07/2012 02:50 PM, Christian Costa wrote: > > > 2012/11/7 Nikolay Sivov mailto:bungleh...@gmail.com>> > > On 11/7/2012 01:05, Christian Costa wrote: > > Le 06/11/2012 22:38, Michael Stefaniuc a écrit : > > On 11/06/2012 08:51 PM, Christian Costa wrote: > >

Re: gdiplus: Avoid GdipCloneMatrix calls for the the graphics transformation matrix.

I won't comment on whether using GpMatrix as a value type within gdiplus generally is a good idea, but semantically this looks correct to me.

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012/11/7 Nikolay Sivov > On 11/7/2012 01:05, Christian Costa wrote: > >> Le 06/11/2012 22:38, Michael Stefaniuc a écrit : >> >>> On 11/06/2012 08:51 PM, Christian Costa wrote: >>> Le 06/11/2012 20:26, Nikolay Sivov a écrit : > On 11/6/2012 20:47, Christian Costa wrote: > What I

Fwd: Bug#566351: libgcrypt11: should not change user id as a side effect

After gstreamer, gcrypt is also dropping support for alternative thread libraries. Good thing secur32/schannel_gnutls.c doesn't use it. (Right?) - Dan -- Forwarded message -- From: Werner Koch Date: Wed, Nov 7, 2012 at 1:31 AM Subject: Re: Bug#566351: libgcrypt11: should not cha

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22807 Your paranoid android

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib

On 11/7/2012 11:36, Tatyana Fokina wrote: Hi, Tatyana. Some comments: dlls/oleaut32/tests/Makefile.in | 1 + dlls/oleaut32/tests/typelib2.c | 69 + 2 files changed, 70 insertions(+) create mode 100644 dlls/oleaut32/tests/typelib2.c You don't nee