> Yes, that's a good suggestion, but the tests currently won't pass anyway,
> so adding a test would not prove anything. As I said, the only way to test
> the result at this point is a visual test (which I have here).
It would at least verify and document the correct behavior on windows.
Vincent Povirk wrote:
> >> Without tests, I can only guess, but I think it's more likely that
> >> this matrix transform should be applied before the world->device
> >> transform.
> >>
> >> Apart from questions of whether this is correct behavior, the patch
> >> looks good to me.
> >
> > I have w
>> Without tests, I can only guess, but I think it's more likely that
>> this matrix transform should be applied before the world->device
>> transform.
>>
>> Apart from questions of whether this is correct behavior, the patch
>> looks good to me.
>
> I have written a graphical test application to t
Vincent Povirk wrote:
> Without tests, I can only guess, but I think it's more likely that
> this matrix transform should be applied before the world->device
> transform.
>
> Apart from questions of whether this is correct behavior, the patch
> looks good to me.
I have written a graphical test
> @@ -6337,6 +6345,11 @@ GpStatus WINGDIPAPI GdipMeasureDriverString(GpGraphics
> *graphics, GDIPCONST UINT
> pt[2].X = 0.0;
> pt[2].Y = 1.0;
> GdipTransformPoints(graphics, CoordinateSpaceDevice,
> CoordinateSpaceWorld, pt, 3);
> +if (matrix)
> +{
> +GpMatrix xform
On Wed, Oct 31, 2012 at 12:34:49PM +0100, Jacek Caban wrote:
> Did you see those failures on Windows? test.winehq.org shows only some
> Linux failures, which suggests that the problem is in implementation,
> not tests.
Hi Jacek,
You're right. The current tests all pass on my Windows box with the
Hi Huw,
On 10/31/12 12:04, Huw Davies wrote:
> ---
> dlls/vbscript/tests/api.vbs | 17 +
> 1 files changed, 9 insertions(+), 8 deletions(-)
Did you see those failures on Windows? test.winehq.org shows only some
Linux failures, which suggests that the problem is in implementatio
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22625
Your paranoid android
Christian Costa writes:
> Use parentesis is more common in Wine code and this makes all sizeof conform
> to file style anyway.
You can clean this up if you are changing the code for other reasons,
but otherwise there's no reason to do this.
--
Alexandre Julliard
julli...@winehq.org
Frédéric Delanoy writes:
> @@ -27,9 +27,13 @@ int WINAPI WinMain(HINSTANCE hInst, HINSTANCE hPrevInst,
> LPSTR cmdline, int cmds
>
> HMODULE hModule;
> DOWINMAIN *doWinMain;
> +int res;
>
> hModule = LoadLibraryA("hhctrl.ocx");
> doWinMain = (DOWINMAIN*) GetProcAddres
2012/10/31 Dmitry Timoshkov
> Christian Costa wrote:
>
> > Based ont a patch of Rico Schuller.
>
> I'd suggest to make sure that the test with appropriate todo_wine
> statements is accepted first,
It it can help the process, I'll do that.
> and only then start thinking about
> a proper fix,
Scott Ritchie writes:
> Is libgettextpo0 (in 32 and 64 bit) sufficient? Or do we need the
> sort of utilities in the gettext-base package?
The gettext tools are only needed at build time. libgettextpo is also
only needed at build time, and then only if you are a developer who
wants to rebuild p
Christian Costa wrote:
> Based ont a patch of Rico Schuller.
I'd suggest to make sure that the test with appropriate todo_wine
statements is accepted first, and only then start thinking about
a proper fix, or even leave creating the fix to someone else.
--
Dmitry.
13 matches
Mail list logo
