What parts of gettext does Wine need at runtime?

2012-10-30 Thread Scott Ritchie
Is libgettextpo0 (in 32 and 64 bit) sufficient? Or do we need the sort of utilities in the gettext-base package? I'm trying to fix https://bugs.launchpad.net/ubuntu/precise/+source/gettext/+bug/954029 which was largely caused by my overcautiousness here.

Re: [PATCH 3/4] msvcp90: in istream<>::tellg don't use sentry

2012-10-30 Thread Piotr Caban
On 10/30/12 10:16 PM, Daniel Lehman wrote: +tpos.pos = 0xdeadbeefdeadbeef; Long long constants are not supported in C89. You can use 0xdeadbeef here.

Re: xapofx1_3.dll?

2012-10-30 Thread Austin English
On Tue, Oct 30, 2012 at 6:11 AM, wrote: > Hi, > > why does Wine include a stub xapofx1_1.dll but no xapofx1_3.dll? > > Installing Wallace & Gromit 102 "The Last Resort" / "Urlaub unter Tage" > adds xapofx1_3.dll XAudio2_4.dll and X3DAudio1_6.dll > to system32 (though IIRC I asked the installer no

Re: scrrun: Add basic IDictionary getHasVal support

2012-10-30 Thread Piotr Caban
Hi, On 10/30/12 09:51, Alistair Leslie-Hughes wrote: +static LONG create_hash_val(BSTR name) +{ +LONG hash = 0; +int len = SysStringLen(name); +int i; + +for(i =0; i < len; i++) +{ + hash += name[i]; +} + +return hash; +} This hashing function will have lots of c

Re: ntdll: Do not execute callbacks past DeleteTimer(INVALID_HANDLE_VALUE)

2012-10-30 Thread Alexandre Julliard
writes: > You know this patch from March this year. Initially, this patch was > the first of 2-3. I decided to release it on its own after finding > out yesterday that in July, Fran,cois Gouget added a todo_wine for a > bug that I fixed monthes earlier! Now I had to augment my patch > with a o

xapofx1_3.dll?

2012-10-30 Thread Joerg-Cyril.Hoehle
Hi, why does Wine include a stub xapofx1_1.dll but no xapofx1_3.dll? Installing Wallace & Gromit 102 "The Last Resort" / "Urlaub unter Tage" adds xapofx1_3.dll XAudio2_4.dll and X3DAudio1_6.dll to system32 (though IIRC I asked the installer not to care about DirectX). This app loads none of thes

Re: [PATCH 4/5] include: Don't add d3d8 LP* interface typedefs for __WINESRC__.

2012-10-30 Thread Jacek Caban
On 10/30/12 12:01, Alexandre Julliard wrote: > Henri Verbeet writes: > >> We can certainly generate some more d3d headers from idl, and we >> probably should anyway, but I'm not sure how that's going to make the >> mechanism any more generic. I suppose we could do something like >> "DECL_WINELIB_T

Re: [PATCH 4/5] include: Don't add d3d8 LP* interface typedefs for __WINESRC__.

2012-10-30 Thread Alexandre Julliard
Henri Verbeet writes: > We can certainly generate some more d3d headers from idl, and we > probably should anyway, but I'm not sure how that's going to make the > mechanism any more generic. I suppose we could do something like > "DECL_WINELIB_TYPE(struct IDirect3D8, *LPDIRECT3D8);", if that's mu

Re: [PATCH 4/5] include: Don't add d3d8 LP* interface typedefs for __WINESRC__.

2012-10-30 Thread Henri Verbeet
On 30 October 2012 10:41, Alexandre Julliard wrote: > I don't think we want to do that sort of thing, otherwise we'll end up > with ifdef __WINESRC__ all over the standard headers. If we really want > to disable interface typedefs this should be done in a generic way, > preferably when generating

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Christian Costa
2012/10/30 Hans Leidekker > On Tue, 2012-10-30 at 09:50 +0100, Christian Costa wrote: > > Just by curiosity. What the difference with strncmpW? > > strncmp tests the first string for null termination. You should really > determine that by yourself though :-) > > > >> Do you have a concrete exampl

Re: [PATCH 4/5] include: Don't add d3d8 LP* interface typedefs for __WINESRC__.

2012-10-30 Thread Alexandre Julliard
Henri Verbeet writes: > @@ -1128,6 +1105,21 @@ DECLARE_INTERFACE_(IDirect3DDevice8,IUnknown) > #define IDirect3DDevice8_DeletePatch(p,a) > (p)->DeletePatch(a) > #endif > > +#ifndef __WINESRC__ > +typedef struct IDirect3D8 *LPDIRECT3D8; > +typedef struct IDirect3DDevi

Re: vbscript: Added support for more builtin constants

2012-10-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22595 Your paranoid android

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Hans Leidekker
On Tue, 2012-10-30 at 09:50 +0100, Christian Costa wrote: > Just by curiosity. What the difference with strncmpW? strncmp tests the first string for null termination. You should really determine that by yourself though :-) > >> Do you have a concrete example that does not work with this implement

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Christian Costa
Le 30/10/2012 09:18, Hans Leidekker a écrit : On Tue, 2012-10-30 at 08:42 +0100, Christian Costa wrote: This is almost the same as your first try. You're testing a trivial case only - ASCII range. I feel like it should behave more like memcmp for case insensitive comparison, that's what document

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Hans Leidekker
On Tue, 2012-10-30 at 08:42 +0100, Christian Costa wrote: > > This is almost the same as your first try. You're testing a trivial > > case only - ASCII range. > > I feel like it should behave more like memcmp for case insensitive > > comparison, > > that's what documentation mildly suggests. > >

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Nikolay Sivov
On 10/30/2012 10:42, Christian Costa wrote: Le 30/10/2012 08:21, Nikolay Sivov a écrit : On 10/30/2012 01:43, Christian Costa wrote: Try 2: - Don't use CompareStringEx. - Add tests --- dlls/kernel32/kernel32.spec |1 + dlls/kernel32/locale.c | 28 dlls/

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Christian Costa
Le 30/10/2012 08:21, Nikolay Sivov a écrit : On 10/30/2012 01:43, Christian Costa wrote: Try 2: - Don't use CompareStringEx. - Add tests --- dlls/kernel32/kernel32.spec |1 + dlls/kernel32/locale.c | 28 dlls/kernel32/tests/locale.c | 60 +