Hello,
Is this patch not good enough to be commited?
Nozomi
Rico Schüller wrote:
> Well the app may initialize some resources (some of them fail with out
> of memory) and run half an hour. If it accesses the invalid pointer it
> crashes. Do you see the problem from the backtrace? The real problem
> happened half an hour ago and the err message doesn't
Hiroshi Miura wrote:
> Evernote windows client on Wine/OpenSSL 1.0.1/Ubuntu12.04/12.10 cannot
> connect
> its server.
> It is caused by server is only support TLS1.0/SSL3.0,
> but client ask TLS1.1/1.2 and then server returns that session is fails.
>
> A wininet in Microsoft Windows7 implementati
On 10/24/2012 02:18 PM, Vincent Povirk wrote:
>> I found some code that reads a generic chunk. I see where the size
>> and type are read, where a correctly sized record is allocated and
>> where the data is read into the record.
>
> That code is unused for reading and writing PNG images right
On 10/24/2012 05:16 AM, Maarten Lankhorst wrote:
I'm not sure yet how dsound should be fixed on bigger periods, I believe using
IAudioClock for reporting position *might* be the correct answer, but it's not
properly test yet on behavior, so I chose for the simple solution of directly
reporting ne
> I found some code that reads a generic chunk. I see where the size
> and type are read, where a correctly sized record is allocated and
> where the data is read into the record.
That code is unused for reading and writing PNG images right now,
sorry for the confusion. Libpng has its own code
On 24.10.2012 19:39, Nikolay Sivov wrote:
On 10/24/2012 19:02, Rico Schüller wrote:
On 24.10.2012 16:33, Dmitry Timoshkov wrote:
Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
REFIID riid, void **ret_iface)
+{
+TRACE("(%p)->(%s, %p)\n", ifa
On 24.10.2012 18:18, Dmitry Timoshkov wrote:
Rico Schüller wrote:
+if (!object)
+{
+ERR("Out of memory\n");
+return E_OUTOFMEMORY;
+}
The ERR() is useless here, just return E_OUTOFMEMORY in such situations.
It's done this way in many places in wine.
Then tha
Le 24/10/2012 19:39, Nikolay Sivov a écrit :
On 10/24/2012 19:02, Rico Schüller wrote:
On 24.10.2012 16:33, Dmitry Timoshkov wrote:
Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile
*iface,
REFIID riid, void **ret_iface)
+{
+TRACE("(%p)->(%s, %p)\n",
Le 24/10/2012 17:53, Dmitry Timoshkov a écrit :
Christian Costa wrote:
Well, that would have been better to spot this *much* earlier.
More generally about coding style or rules, that would be *much* better to
write a wiki page about this and point to it
along with code style comments. I don't
On 10/24/2012 12:02 PM, Rico Schüller wrote:
> On 24.10.2012 16:33, Dmitry Timoshkov wrote:
>> Christian Costa wrote:
>>
> +if (!object)
> +{
> +ERR("Out of memory\n");
> +return E_OUTOFMEMORY;
> +}
The ERR() is useless here, just return E_
On 10/24/2012 19:02, Rico Schüller wrote:
On 24.10.2012 16:33, Dmitry Timoshkov wrote:
Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
REFIID riid, void **ret_iface)
+{
+TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid),
ret_iface);
+
+
Hi,
Evernote windows client on Wine/OpenSSL 1.0.1/Ubuntu12.04/12.10 cannot connect
its server.
It is caused by server is only support TLS1.0/SSL3.0,
but client ask TLS1.1/1.2 and then server returns that session is fails.
A wininet in Microsoft Windows7 implementation has a behavior
to re-try by
Op 24-10-12 12:52, joerg-cyril.hoe...@t-systems.com schreef:
> Hi,
>
> Maarten Lankhorst wrote:
>> For example Skyrim with a 36 ms stream latency will just buffer in more data
>> to
>> compensate instead. But it can't do it if you report that it's fine to feed
>> data every 5 ms.
> Please elabora
Rico Schüller wrote:
> +if (!object)
> +{
> +ERR("Out of memory\n");
> +return E_OUTOFMEMORY;
> +}
> >>>
> >>> The ERR() is useless here, just return E_OUTOFMEMORY in such situations.
> >>>
> >>>
> >>>
> >> It's done this way in many places in
Background: I am trying to improve the performance/reliability of
GuildWars2 under wine. In particular, PNG handling seems very
slow, so I am looking at windowscodecs and I seem to be
misunderstanding some things. I have read the PNG spec.
First: The CRC check. The spec says that a 'chunk' c
On 24.10.2012 16:33, Dmitry Timoshkov wrote:
Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
REFIID riid, void **ret_iface)
+{
+TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface);
+
+if (IsEqualGUID(riid, &IID_IUnknown) ||
+
Christian Costa wrote:
> Well, that would have been better to spot this *much* earlier.
>
> More generally about coding style or rules, that would be *much* better to
> write a wiki page about this and point to it
> along with code style comments. I don't mind following rules or adopt "nice
> to
2012/10/24 Dmitry Timoshkov
> Christian Costa wrote:
>
> > > > +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
> > > REFIID riid, void **ret_iface)
> > > > +{
> > > > +TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid),
> ret_iface);
> > > > +
> > > > +if (IsEqual
Christian Costa wrote:
> > > +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
> > REFIID riid, void **ret_iface)
> > > +{
> > > +TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface);
> > > +
> > > +if (IsEqualGUID(riid, &IID_IUnknown) ||
> > > +IsE
On Wed, Oct 24, 2012 at 5:38 AM, Alexandre Julliard wrote:
> What I'm actually saying is that you should stop playing games with the
> compiler and implement this in assembler...
Thanks for the cleartext.
Dan Kegel writes:
> I don't think he's saying that.
> It suffices that taking the address of the fourth parameter saves it
> to the stack.
> We are lucky in this case that there are already three
> non-varargs parameter, so after taking the address of the fourth
> parameter, all the varargs param
Hello Jörg,
On 10/24/2012 12:36 PM, joerg-cyril.hoe...@t-systems.com wrote:
> I'm not happy with Wine's DSound+WinMM->mmdevapi. That may be a good
> move for MS, but it's a bad move for Wine. Wine's audio drivers don't
what would you do instead? Go back to the old way and have dsound and
winmm d
On Wed, Oct 24, 2012 at 3:26 AM, wrote:
> Alexandre Julliard wrote:
>> +void WINAPIV _vcomp_fork(BOOL ifval, int nargs, void *wrapper, ...)
>> +__ms_va_list valist;
>>
>>it's ugly to use varargs only as a hack to get a pointer to the first
>>argument.
>
> Would taking the address of &wrapper
2012/10/24 Nikolay Sivov
> On 10/24/2012 11:33, Christian Costa wrote:
>
>
>
> 2012/10/24 Dmitry Timoshkov
>
>> Christian Costa wrote:
>>
>> > BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
>> > {
>> > +DWORD error = GetLastError();
>> > +
>> > +if (!hwnd)
>> > +{
>> > +
Hi,
Maarten Lankhorst wrote:
>For example Skyrim with a 36 ms stream latency will just buffer in more data to
>compensate instead. But it can't do it if you report that it's fine to feed
>data every 5 ms.
Please elaborate. Every now and then I wish you used more words to
explain your observatio
On 10/24/2012 11:04 AM, Ken Thomases wrote:
> On Oct 24, 2012, at 3:24 AM, Michael Stefaniuc wrote:
>
>> @@ -1330,9 +1330,6 @@ static HICON CURSORICON_LoadFromFile( LPCWSTR filename,
>> }
>>
>> dir = (const CURSORICONFILEDIR*) bits;
>> -if ( filesize < sizeof(*dir) )
>> -goto e
Hi,
Maarten Lankhorst wrote:
>only oss4 and (maybe, just guessing?) coreaudio don't support float
MacOS' CoreAudio supports floats. Actually, given that it's an entire
audio pipeline like quartz, I bet it even prefers floats.
>I also refer you to GetStreamLatency where I was getting the period
Hi,
Alexandre Julliard wrote:
> +void WINAPIV _vcomp_fork(BOOL ifval, int nargs, void *wrapper, ...)
> +__ms_va_list valist;
>it's ugly to use varargs only as a hack to get a pointer to the first
>argument.
Would taking the address of &wrapper (as in asm("...","r=&wrapper") or
any C code lik
2012/10/24 Dmitry Timoshkov
> Christian Costa wrote:
>
> > +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
> REFIID riid, void **ret_iface)
> > +{
> > +TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface);
> > +
> > +if (IsEqualGUID(riid, &IID_IUnknown)
On Oct 24, 2012, at 3:24 AM, Michael Stefaniuc wrote:
> @@ -1330,9 +1330,6 @@ static HICON CURSORICON_LoadFromFile( LPCWSTR filename,
> }
>
> dir = (const CURSORICONFILEDIR*) bits;
> -if ( filesize < sizeof(*dir) )
> -goto end;
> -
> if ( filesize < (sizeof(*dir) +
> size
On 10/24/2012 11:33, Christian Costa wrote:
2012/10/24 Dmitry Timoshkov mailto:dmi...@baikal.ru>>
Christian Costa mailto:titan.co...@gmail.com>> wrote:
> BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
> {
> +DWORD error = GetLastError();
> +
> +if (!h
2012/10/24 Dmitry Timoshkov
> Christian Costa wrote:
>
> > BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
> > {
> > +DWORD error = GetLastError();
> > +
> > +if (!hwnd)
> > +{
> > +SetLastError( ERROR_INVALID_WINDOW_HANDLE );
> > +return FALSE;
> > +}
>
33 matches
Mail list logo
