Re: [PATCH] user32: Fix error handling in MapWindowPoints, ClientToScreen and ScreenToClient and add tests for them. (try 3)

2012-10-23 Thread Dmitry Timoshkov
Christian Costa wrote: > BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt ) > { > +DWORD error = GetLastError(); > + > +if (!hwnd) > +{ > +SetLastError( ERROR_INVALID_WINDOW_HANDLE ); > +return FALSE; > +} > + > +SetLastError( 0xdeadbeef ); > MapWind

Re: [PATCH 1/5] d3dx9_36: Implement D3DXFileCreate. (try 3)

2012-10-23 Thread Dmitry Timoshkov
Christian Costa wrote: > +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface, REFIID > riid, void **ret_iface) > +{ > +TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface); > + > +if (IsEqualGUID(riid, &IID_IUnknown) || > +IsEqualGUID(riid, &IID_ID3DX

Re: d3dx9_36/tests: Fix sizeof to be more portable (coverity)

2012-10-23 Thread André Hentschel
Am 24.10.2012 02:32, schrieb Henri Verbeet: > On 24 October 2012 02:05, André Hentschel wrote: >> face_remap = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, >> - tc[i].num_faces*sizeof(face_remap)); >> + tc[i].num_faces*sizeof(DW

Re: d3dx9_36/tests: Fix sizeof to be more portable (coverity)

2012-10-23 Thread Henri Verbeet
On 24 October 2012 02:05, André Hentschel wrote: > face_remap = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > - tc[i].num_faces*sizeof(face_remap)); > + tc[i].num_faces*sizeof(DWORD*)); > I'm don't know what Coverity actually s

We're in at FOSDEM!

2012-10-23 Thread Jeremy White
I'm stoked - we've been approved for a dev room at FOSDEM on Saturday, February 2nd, in Brussels. It is just the one day, but I figure we can find ways to gather on Friday night and/or Sunday as well. I really think this will be a fun change of pace for us. If it doesn't work out, we'll just go

Re: [PATCH 3/3] ntdll: Add NULL test for NtQuerySystemInformation with SystemProcessInformation.

2012-10-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22435 Your paranoid android

Re: [PATCH 3/3] mshtml: Added HTML comments in VBScript code tests

2012-10-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22431 Your paranoid android

Re: [PATCH 1/3] ntdll: Implement nanosecond precision file time storage (try 2).

2012-10-23 Thread Alexandre Julliard
"Erich E. Hoover" writes: > @@ -2048,17 +2048,26 @@ NTSTATUS WINAPI NtSetInformationFile(HANDLE handle, > PIO_STATUS_BLOCK io, > > if (info->LastAccessTime.QuadPart || > info->LastWriteTime.QuadPart) > { > +#ifdef HAVE_FUTIMENS > +struct timespec tv[2

Re: [PATCH 5/5] d3dx9_36: Implement ID3DXFileDataImpl_GetType. (try 2)

2012-10-23 Thread Rico Schüller
On 22.10.2012 23:57, Christian Costa wrote: -static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData *iface, GUID* guid) +static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData *iface, GUID *guid) -ID3DXFileDataImpl* object; +ID3DXFileDataImpl *object; One minor thing: I'd