On 22 October 2012 23:19, Christian Costa wrote:
> Le 22/10/2012 22:55, Jacek Caban a écrit :
>> Christian, there were some informal attempts to limit usage of stuff like
>> LPVOID (and really any LP* types). It would be nice if you could avoid it
>> in your patches.
>>
>> Jacek
>>
> I don't min
Christian Costa wrote:
> >> +object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> >> sizeof(ID3DXFileDataImpl));
> > I'd use sizeof(*object), but that's probably only a matter of taste.
> >
> I use to do it this way but I don't have particular taste. If
> sizeof(*object) is the Wine pre
Le 22/10/2012 22:29, Rico Schüller a écrit :
On 22.10.2012 21:28, Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData
*iface, GUID* guid)
Spacing. msdn says "const GUID *pType" see
http://msdn.microsoft.com/en-us/library/windows/desktop/bb205843%28v=vs.85%29.as
Le 22/10/2012 22:55, Jacek Caban a écrit :
On 10/22/12 10:13 PM, Rico Schüller wrote:
On 22.10.2012 21:27, Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
REFIID riid, LPVOID *ret_iface)
+ID3DXFileImpl *This = impl_from_ID3DXFile(iface);
+I
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
this patch is causing CS:GO (Counter Strike: Global Offensive) to exit
silently on startup.
(Commit: 5fae649bdf14fb63b8d44984eda6edd1094a3314)
- -Chris
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mo
On 22.10.2012 22:55, Jacek Caban wrote:
On 10/22/12 10:13 PM, Rico Schüller wrote:
On 22.10.2012 21:27, Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
REFIID riid, LPVOID *ret_iface)
+ID3DXFileImpl *This = impl_from_ID3DXFile(iface);
+ID3D
On 10/22/12 10:13 PM, Rico Schüller wrote:
> On 22.10.2012 21:27, Christian Costa wrote:
>> +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface,
REFIID riid, LPVOID *ret_iface)
>> +ID3DXFileImpl *This = impl_from_ID3DXFile(iface);
>> +ID3DXFileImpl* object;
> Please be a b
Le 22/10/2012 22:29, Rico Schüller a écrit :
On 22.10.2012 21:28, Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData
*iface, GUID* guid)
Spacing. msdn says "const GUID *pType" see
http://msdn.microsoft.com/en-us/library/windows/desktop/bb205843%28v=vs.85%29.as
On 22.10.2012 21:28, Christian Costa wrote:
static HRESULT WINAPI ID3DXFileDataImpl_Unlock(ID3DXFileData *iface)
{
+
FIXME("(%p)->(): stub\n", iface);
Why?
On 22.10.2012 21:28, Christian Costa wrote:
} ID3DXFileImpl;
-
static inline ID3DXFileImpl *impl_from_ID3DXFile(ID3DXFile *iface)
It doesn't make much sense to add an empty line and remove it in the
next patch.
On 22.10.2012 21:28, Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData *iface, GUID*
guid)
Spacing. msdn says "const GUID *pType" see
http://msdn.microsoft.com/en-us/library/windows/desktop/bb205843%28v=vs.85%29.aspx.
Is it a bug in msdn?
+ID3DXFileDa
On 22.10.2012 21:27, Christian Costa wrote:
+static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface, REFIID
riid, LPVOID *ret_iface)
+ID3DXFileImpl *This = impl_from_ID3DXFile(iface);
+ID3DXFileImpl* object;
Please be a bit more consistent across your patch... There are
> Have you verified that this works correctly on all the platforms you are
> changing?
>
> --
> Alexandre Julliard
> julli...@winehq.org
Having another look, some of the BSDs are lacking or gained support
only somewhat recently. I had thought the BSDs weren't so different.
For Apple we need 10.4
Le 22/10/2012 20:35, Alexandre Julliard a écrit :
Christian Costa writes:
@@ -236,20 +236,32 @@ BOOL WINAPI GetClientRect( HWND hwnd, LPRECT rect )
/***
- * ClientToScreen (USER32.@)
+ * ClientToSc
This patch super-seeds my previous attempt ID 91173. This time I used
do_cpuid from ntdll / wbemprox. If cpuid is not available, the default
"Intel Pentium 4" string is used. I modified get_processor_name to
remove leading white-spaces. I also updated the code for Identifier
REG_SZ. This applie
Christian Costa writes:
> @@ -236,20 +236,32 @@ BOOL WINAPI GetClientRect( HWND hwnd, LPRECT rect )
>
>
> /***
> - * ClientToScreen (USER32.@)
> + * ClientToScreen (USER32.@)
> */
> BOOL WINAPI ClientToS
Op 19-10-12 15:54, Andrew Eikum schreef:
> Mostly good cleanup in this one. Some thoughts below...
>
> On Tue, Oct 16, 2012 at 02:06:29PM +0200, Maarten Lankhorst wrote:
>> diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h
>> index feef787..7817b88 100644
>> --- a/dlls/dsound
Op 22-10-12 17:42, Andrew Eikum schreef:
> On Sat, Oct 20, 2012 at 12:03:55AM +0200, Maarten Lankhorst wrote:
>> Op 19-10-12 15:54, Andrew Eikum schreef:
>>> Mostly good cleanup in this one. Some thoughts below...
>>>
>>> On Tue, Oct 16, 2012 at 02:06:29PM +0200, Maarten Lankhorst wrote:
diff
On Sat, Oct 20, 2012 at 12:13:08AM +0200, Maarten Lankhorst wrote:
> Hey,
>
> Op 19-10-12 15:29, Andrew Eikum schreef:
> > Patches 1 and 2 in this series look fine.
> >
> > I have a series of patches similar to this one in my dsound
> > multichannel branch. This patch seems to do too much at once.
On Sat, Oct 20, 2012 at 12:03:55AM +0200, Maarten Lankhorst wrote:
> Op 19-10-12 15:54, Andrew Eikum schreef:
> > Mostly good cleanup in this one. Some thoughts below...
> >
> > On Tue, Oct 16, 2012 at 02:06:29PM +0200, Maarten Lankhorst wrote:
> >> diff --git a/dlls/dsound/dsound_private.h b/dlls/
On Fri, Oct 19, 2012 at 11:33:22PM +0200, Maarten Lankhorst wrote:
> Op 19-10-12 15:40, Andrew Eikum schreef:
> > I'm a big fan of error checking (or at least reporting), so these
> > unchecked calls make me nervous. They'll probably never fail, but if
> > they do, I think they should fail loudly.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22392
Your paranoid android
Am 21.10.2012 02:51, schrieb James Eder:
> I've been kicking this patch set around in my local git tree for a
> while and I want to get it out there for comments and maybe even
> inclusion in Wine. Seeing some comments in another thread about
> wineboot made me think I should get these patches out
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22384
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22386
Your paranoid android
Christian Costa writes:
> @@ -599,7 +599,7 @@ static HRESULT WINAPI
> IDirectXFileDataImpl_GetId(IDirectXFileData* iface, LPGUID
>if (!pGuid)
> return DXFILEERR_BADVALUE;
>
> - memcpy(pGuid, &This->pobj->class_id, 16);
> + memcpy(pGuid, &This->pobj->class_id, sizeof(GUID));
Using n
Michael Stefaniuc writes:
> I'm removing CONST in the lines I touch so +1 on a concerted effort to
> eradicate it. Though at 1.2k lines Alexandre might consider it too spammy.
Yes, that's too much for a large scale cleanup.
--
Alexandre Julliard
julli...@winehq.org
James Eder writes:
> @@ -1010,6 +1010,16 @@ static inline void get_cpuinfo(SYSTEM_CPU_INFORMATION*
> info)
> */
> void fill_cpu_info(void)
> {
> +long num;
> +
> +num = sysconf(_SC_NPROCESSORS_ONLN);
> +if (num < 1)
> +{
> +num = 1;
> +WARN("Failed to detect t
On 10/22/2012 11:21 AM, Henri Verbeet wrote:
> On 22 October 2012 09:06, Rico Schüller wrote:
>> On 19.10.2012 13:15, Nozomi Kodama wrote:
>>>
>>> This patch adds tests for the patch sent by Rico for D3DXSHRotateZ.
>>>
>>> Moreover, I changed const in CONST in the declaration of the function in
>>
On 22 October 2012 09:06, Rico Schüller wrote:
> On 19.10.2012 13:15, Nozomi Kodama wrote:
>>
>> This patch adds tests for the patch sent by Rico for D3DXSHRotateZ.
>>
>> Moreover, I changed const in CONST in the declaration of the function in
>> order to uniformize with the file.
>
>
>> +cons
On 19.10.2012 13:15, Nozomi Kodama wrote:
This patch adds tests for the patch sent by Rico for D3DXSHRotateZ.
Moreover, I changed const in CONST in the declaration of the function in
order to uniformize with the file.
> +const FLOAT angle[] = ...
I'd prefer "const" because it is used a lit
31 matches
Mail list logo
