Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread David Laight
On Sun, Oct 21, 2012 at 04:16:04PM -0600, James Eder wrote: > Hmmm... the GCC docs say: > > http://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Type-Attributes.html#Type-Attributes > > "Note that the alignment of any given struct or union type is required > by the ISO C standard to be at least a perfect

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread James Eder
Hmmm... the GCC docs say: http://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Type-Attributes.html#Type-Attributes "Note that the alignment of any given struct or union type is required by the ISO C standard to be at least a perfect multiple of the lowest common multiple of the alignments of all of the m

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread David Laight
On Sun, Oct 21, 2012 at 10:56:51AM -0600, James Eder wrote: > static inline void save_fpux( CONTEXT *context ) > { > #ifdef __GNUC__ > /* we have to enforce alignment by hand */ > char buffer[sizeof(XMM_SAVE_AREA32) + 16]; > XMM_SAVE_AREA32 *state = (XMM_SAVE_AREA32 *)(((ULONG_PTR)buffe

Re: [PATCH] services: Fix some weird sizeof usages.

2012-10-21 Thread Christian Costa
Le 21/10/2012 20:27, Dan Kegel a écrit : Christian Costa wrote: ... --- a/programs/services/rpc.c +++ b/programs/services/rpc.c ... @@ -952,7 +952,7 @@ BOOL service_send_command( struct service_entry *service, HANDLE pipe, } r = GetOverlappedResult( pipe, &overlapped, &count,

re: [PATCH] services: Fix some weird sizeof usages.

2012-10-21 Thread Dan Kegel
Christian Costa wrote: ... --- a/programs/services/rpc.c +++ b/programs/services/rpc.c ... @@ -952,7 +952,7 @@ BOOL service_send_command( struct service_entry *service, HANDLE pipe, } r = GetOverlappedResult( pipe, &overlapped, &count, FALSE ); } -if (!r || count != sizeo

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread James Eder
Gah... hit the wrong reply button so here we go again for some. On Sun, Oct 21, 2012 at 10:06 AM, Joris Huizer wrote: > On 10/21/2012 05:49 PM, James Eder wrote: >> >> On Sat, Oct 20, 2012 at 7:06 PM, Chris Robinson >> wrote: >>> >>> On 10/20/2012 05:40 PM, James Eder wrote: +/* In

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread David Laight
On Sun, Oct 21, 2012 at 06:06:56PM +0200, Joris Huizer wrote: > I would think the construct is necessary when allocating memory (the > allocation functions don't allow to require a certain alignment as far > as I know) > That might be where you saw this being done? A conformant malloc() should r

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread Joris Huizer
On 10/21/2012 05:49 PM, James Eder wrote: On Sat, Oct 20, 2012 at 7:06 PM, Chris Robinson wrote: On 10/20/2012 05:40 PM, James Eder wrote: +/* Intel says we need a zeroed 16-byte aligned buffer */ +char buffer[512 + 16]; +XMM_SAVE_AREA32 *state = (XMM_SAVE_AREA32 *)(((ULONG_PTR)buf

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread James Eder
On Sat, Oct 20, 2012 at 7:06 PM, Chris Robinson wrote: > On 10/20/2012 05:40 PM, James Eder wrote: >> >> +/* Intel says we need a zeroed 16-byte aligned buffer */ >> +char buffer[512 + 16]; >> +XMM_SAVE_AREA32 *state = (XMM_SAVE_AREA32 *)(((ULONG_PTR)buffer + 15) >> & ~15); >> +mem

Re: [PATCH 2/2] d3dxof: Use sizeof(GUID) instead of hardcoding the value.

2012-10-21 Thread Christian Costa
Le 21/10/2012 16:21, Rico Schüller a écrit : Why is there a "static guid" used in GetType? What happens if you query: hr = IDirectXFileData_GetType(lpDirectXFileData, &clsid_type); hr = IDirectXFileData_GetType(lpDirectXFileData2, &clsid_type2); Are thy both containing the value to clsid_type2 th

Re: [PATCH 2/2] d3dxof: Use sizeof(GUID) instead of hardcoding the value.

2012-10-21 Thread Rico Schüller
Why is there a "static guid" used in GetType? What happens if you query: hr = IDirectXFileData_GetType(lpDirectXFileData, &clsid_type); hr = IDirectXFileData_GetType(lpDirectXFileData2, &clsid_type2); Are thy both containing the value to clsid_type2 then? Do clsid_type and clsid_type2 match in th

Re: [PATCH] user32: Fix error handling in MapWindowPoints, ClientToScreen and ScreenToClient and add tests for them. (try 2)

2012-10-21 Thread Christian Costa
I don't mind working on this issue or let you do it but it's not worth working both on or review very different versions of the patch that are not converging. The fact the patch gets in does not prevent to add further tests afterwards. Note that in the version I sent based on your work I group

Re: [PATCH 1/1] d3dx9/tests: Move device creation to main func.

2012-10-21 Thread Rico Schüller
On 21.10.2012 14:17, Henri Verbeet wrote: 2012/10/21 Rico Schüller : --- We've generally been moving in the opposite direction for the D3D tests, having each set of tests create its own device, window, etc. instead. This makes the tests much more self-contained, which in turn makes it much easi

Re: [PATCH 1/1] d3dx9/tests: Move device creation to main func.

2012-10-21 Thread Henri Verbeet
2012/10/21 Rico Schüller : > --- We've generally been moving in the opposite direction for the D3D tests, having each set of tests create its own device, window, etc. instead. This makes the tests much more self-contained, which in turn makes it much easier to debug if you have failures on some set

Re: [PATCH] user32: Fix error handling in MapWindowPoints, ClientToScreen and ScreenToClient and add tests for them. (try 2)

2012-10-21 Thread Rico Schüller
Well, I just like to add my favorite version for now. It handles only ClientToScreen and ScreenToClient and fixes the return values. It doesn't touch MapWindowPoints and it doesn't check for the comment on msdn. I think those both extra points belong into separate patches. Feedback is welcome.