Le 20/10/2012 03:59, Dmitry Timoshkov a écrit :
Christian Costa wrote:
-BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
+BOOL WINAPI ClientToScreen( HWND wnd, LPPOINT point )
{
-MapWindowPoints( hwnd, 0, lppnt, 1 );
+DWORD error = GetLastError();
+
+if (!wnd)
+{
+
Le 20/10/2012 04:06, Dmitry Timoshkov a écrit :
Christian Costa wrote:
-BOOL WINAPI ScreenToClient( HWND hwnd, LPPOINT lppnt )
+BOOL WINAPI ScreenToClient( HWND wnd, LPPOINT point )
Please stick to commonly used 'hwnd' for a window handle, renaming 'lppnt'
to 'point' is also not justified.
I
Christian Costa wrote:
> -BOOL WINAPI ScreenToClient( HWND hwnd, LPPOINT lppnt )
> +BOOL WINAPI ScreenToClient( HWND wnd, LPPOINT point )
Please stick to commonly used 'hwnd' for a window handle, renaming 'lppnt'
to 'point' is also not justified.
--
Dmitry.
Christian Costa wrote:
> -BOOL WINAPI ClientToScreen( HWND hwnd, LPPOINT lppnt )
> +BOOL WINAPI ClientToScreen( HWND wnd, LPPOINT point )
> {
> -MapWindowPoints( hwnd, 0, lppnt, 1 );
> +DWORD error = GetLastError();
> +
> +if (!wnd)
> +{
> +SetLastError( ERROR_INVALID_WIN
Hey,
Op 19-10-12 15:29, Andrew Eikum schreef:
> Patches 1 and 2 in this series look fine.
>
> I have a series of patches similar to this one in my dsound
> multichannel branch. This patch seems to do too much at once.
>
> When I did this cleanup, I split it up into four patches:
> 1) Allocate the
Op 19-10-12 15:40, Andrew Eikum schreef:
> I like it. Before I can give a sign-off, I need to run it through my
> usual battery of tests on all the platforms. I'll do that after patch
> 3 gets figured out.
>
> Some thoughts below...
>
> On Tue, Oct 16, 2012 at 02:06:28PM +0200, Maarten Lankhorst wr
Be nice if you could split this up and squash it into the previous
patches.
Andrew
On Tue, Oct 16, 2012 at 02:06:30PM +0200, Maarten Lankhorst wrote:
> From: Maarten Lankhorst
>
> No longer influence anything, so zap them.
> ---
> dlls/dsound/dsound_main.c| 17 -
> dlls/dso
Mostly good cleanup in this one. Some thoughts below...
On Tue, Oct 16, 2012 at 02:06:29PM +0200, Maarten Lankhorst wrote:
> diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h
> index feef787..7817b88 100644
> --- a/dlls/dsound/dsound_private.h
> +++ b/dlls/dsound/dsound_priv
I like it. Before I can give a sign-off, I need to run it through my
usual battery of tests on all the platforms. I'll do that after patch
3 gets figured out.
Some thoughts below...
On Tue, Oct 16, 2012 at 02:06:28PM +0200, Maarten Lankhorst wrote:
> + /* ALSA is retarded, add a timeo
2012/10/19 Henri Verbeet :
> On 19 October 2012 15:20, Matteo Bruni wrote:
>> 2012/10/18 Henri Verbeet :
>>> ---
>>> dlls/wined3d/glsl_shader.c |3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c
>>> index 5
On 19 October 2012 15:20, Matteo Bruni wrote:
> 2012/10/18 Henri Verbeet :
>> ---
>> dlls/wined3d/glsl_shader.c |3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c
>> index 57119e1..993b547 100644
>> --- a/dlls
Patches 1 and 2 in this series look fine.
I have a series of patches similar to this one in my dsound
multichannel branch. This patch seems to do too much at once.
When I did this cleanup, I split it up into four patches:
1) Allocate the device format in the Device struct
2) Load the default form
2012/10/18 Henri Verbeet :
> ---
> dlls/wined3d/glsl_shader.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c
> index 57119e1..993b547 100644
> --- a/dlls/wined3d/glsl_shader.c
> +++ b/dlls/wined3d/glsl_shader.
On 10/16/12 13:21, Jacek Caban wrote:
>> How exactly? Do you know more details / urls?
>>
>> Does it return -n ... +n values? Like the memcmp optimization that caused
>> mysql security issue?
>> In that case my patch should work.
> From what I know following call crashes:
> strncasecmp("", "", 1);
Dan Kegel writes:
> +void WINAPIV _vcomp_fork(BOOL ifval, int nargs, void *wrapper, ...)
> +{
> +__ms_va_list valist;
> +TRACE("(%d, %d, %p, ...)\n", ifval, nargs, wrapper);
> +__ms_va_start(valist, wrapper);
> +_vcomp_fork_call_wrapper(wrapper, nargs, valist);
> +__ms_va_end(
"Erich E. Hoover" writes:
> This series of patches provides a fix for Bug #31858 (Netflix Internet
> Connection Problem). With this particular patch the POSIX.1-2008
> futimens() function is used to replace the BSD futimes() function,
> allowing for nanosecond precision of recorded file times.
On Thu, Oct 18, 2012 at 7:49 PM, Saulius Krasuckas wrote:
> The post:
> http://www.linuxforums.org/forum/coffee-lounge/192526-survey-about-gaming-linux.html
>
> The results containing one item about using Wine:
> https://docs.google.com/spreadsheet/viewanalytics?formkey=dEI5dEx1SGw5TEJMWi1RUnBUX09
17 matches
Mail list logo
