My bad.
My patch pass the tests but not yours. Can you check these facts?
Nozomi
>Hi Nozomi,
>
>the huge arrays, the loop, it looks a bit ugly. Your implementation makes the
>D3DXSHRotateZ function a >bit more compatible. What comes into my mind is:
>D3DXSHRotateZ(out, y, 1,25f, in);
>D3DX
On Tue, Oct 16, 2012 at 7:40 PM, Ken Thomases wrote:
> Beyond that, perhaps the scaling should be put into the ICNS encoder rather
> than convert_to_native_icon(). That is, if it's handed a size that doesn't
> fit properly into one of the predefined slots, it would scale down to the
> next low
Hi
Both your patch and mine fail to pass the attached tests. More thoughts are
needed.
Nozomi
>Hi Nozomi,
>
>the huge arrays, the loop, it looks a bit ugly. Your implementation makes the
>D3DXSHRotateZ function a >bit more compatible. What comes into my mind is:
>D3DXSHRotateZ(out, y, 1,25f
On 10/16/12 7:40 PM, Ken Thomases wrote:
> On Oct 16, 2012, at 2:15 PM, Aric Stewart wrote:
>
>> @@ -1052,6 +1079,7 @@ static inline int size_to_slot(int size)
>> case 16: return 0;
>> case 32: return 1;
>> case 48: return 2;
>> +case 64: return 2; /* Class
On Oct 16, 2012, at 2:15 PM, Aric Stewart wrote:
> @@ -1052,6 +1079,7 @@ static inline int size_to_slot(int size)
> case 16: return 0;
> case 32: return 1;
> case 48: return 2;
> +case 64: return 2; /* Classic Mode */
> case 128: return 3;
> ca
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22275
Your paranoid android
On Mon, 15 Oct 2012, Christian Costa wrote:
[...]
> >> Why not if I can make it run the test after the extraction.
> >> That said why not improving test bot download extra files? Is there a
> >> specific reason for that?
> > I'm not against improving the testbot, it was just a suggestion.
> >
> It'
Le 16/10/2012 21:31, Rico Schüller a écrit :
On 16.10.2012 20:21, Henri Verbeet wrote:
On 16 October 2012 20:12, Christian Costa wrote:
+//SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom /
2, 0);
C99 comment.
I don't think these are very interesting cases though, it's probably
Le 16/10/2012 20:21, Henri Verbeet a écrit :
On 16 October 2012 20:12, Christian Costa wrote:
+//SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom / 2, 0);
C99 comment.
I don't think these are very interesting cases though, it's probably
more interesting what happens with e.g. a d
Le 16/10/2012 20:15, Austin English a écrit :
On Tue, Oct 16, 2012 at 11:12 AM, Christian Costa wrote:
...
+wnd = CreateWindowA("static", NULL, 0, 0, 0, rect.right / 2, rect.bottom /
2, 0, 0, 0, 0);
+//SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom / 2, 0);
Leftover debug c
On 16.10.2012 20:21, Henri Verbeet wrote:
On 16 October 2012 20:12, Christian Costa wrote:
+//SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom / 2, 0);
C99 comment.
I don't think these are very interesting cases though, it's probably
more interesting what happens with e.g. a dest
Aric Stewart writes:
> I can but i feel like it would be more esoteric.
> Something like if numIndices is greater than 1... Would that be more
> preferable?
No, but there's no reason that icon scaling would be Mac-specific, it
just needs a general mechanism for specifying destination size or
so
I can but i feel like it would be more esoteric.
Something like if numIndices is greater than 1... Would that be more preferable?
-aric
On 10/16/12 1:39 PM, Alexandre Julliard wrote:
> Aric Stewart writes:
>
>> @@ -403,6 +404,13 @@ static HRESULT convert_to_native_icon(IStream *icoFile,
>> in
Akihiro Sagawa writes:
> @@ -244,7 +244,8 @@ WCHAR *WCMD_fgets(WCHAR *buf, DWORD noChars, HANDLE h)
>
>if (!WCMD_is_console_handle(h) && i != charsRead) {
> /* Sets file pointer to the start of the next line, if any */
> -filepos.QuadPart += i + 1 + (buf[i] == '\r' ? 1 : 0);
> +
Aric Stewart writes:
> @@ -403,6 +404,13 @@ static HRESULT convert_to_native_icon(IStream *icoFile,
> int *indices, int numInd
> WINE_ERR("error 0x%08X creating IWICBitmapDecoder\n", hr);
> goto end;
> }
> +#ifdef __APPLE__
> +hr = IWICImagingFactory_CreateBitmapScaler
On 16 October 2012 20:12, Christian Costa wrote:
> +//SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom / 2, 0);
C99 comment.
I don't think these are very interesting cases though, it's probably
more interesting what happens with e.g. a destroyed window, or a
fullscreen window.
Forget my user32 patch. MapWindowPoints tests are wrong.
On Tue, Oct 16, 2012 at 11:12 AM, Christian Costa wrote:
...
> +wnd = CreateWindowA("static", NULL, 0, 0, 0, rect.right / 2, rect.bottom
> / 2, 0, 0, 0, 0);
> +//SetWindowPos(wnd, NULL, 0, 0, rect.right / 2, rect.bottom / 2, 0);
Leftover debug code.
Cheers,
Austin
Ehh, this patch should have been called something like "wined3d:
Improve a Nvidia GPU recognition fallback.", but well...
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22264
Your paranoid android
Jacek Caban writes:
> That wasn't the original reason for writing this patch. It seems like
> some distros (well, at least some Gentoo installations) have broken
> strncasecmp.
There are many places in Wine that use strncasecmp, we don't want to
change them all just because of some Gentoo screwu
On 10/16/12 13:16, Marcus Meissner wrote:
> On Tue, Oct 16, 2012 at 01:12:50PM +0200, Jacek Caban wrote:
>> On 10/16/12 13:08, Marcus Meissner wrote:
>>> On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote:
---
dlls/ntdll/string.c | 12 +++-
dlls/ntdll/tests/
On Tue, Oct 16, 2012 at 01:12:50PM +0200, Jacek Caban wrote:
> On 10/16/12 13:08, Marcus Meissner wrote:
> > On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote:
> >> ---
> >> dlls/ntdll/string.c | 12 +++-
> >> dlls/ntdll/tests/string.c | 33 +
On 10/16/12 13:08, Marcus Meissner wrote:
> On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote:
>> ---
>> dlls/ntdll/string.c | 12 +++-
>> dlls/ntdll/tests/string.c | 33 +
>> 2 files changed, 44 insertions(+), 1 deletions(-)
>>
>>
>> dif
On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote:
> ---
> dlls/ntdll/string.c | 12 +++-
> dlls/ntdll/tests/string.c | 33 +
> 2 files changed, 44 insertions(+), 1 deletions(-)
>
>
> diff --git a/dlls/ntdll/string.c b/dlls/ntdll/strin
On 10/16/2012 10:29, Dmitry Timoshkov wrote:
Nikolay Sivov wrote:
+static const WCHAR arialW[] = {'A','r','i','a','l',0};
Please don't use fonts which Wine doesn't provide. Testing Tahoma is fine.
Makes sense, thanks.
Nikolay Sivov wrote:
> +static const WCHAR arialW[] = {'A','r','i','a','l',0};
Please don't use fonts which Wine doesn't provide. Testing Tahoma is fine.
--
Dmitry.
On 10/16/2012 04:10, danielfsan...@att.net wrote:
ScreenToClient should return zero if the operation fails, but is always
returning TRUE. This patch corrects the problem and solves a crash bug
in Lord of the Rings Online (bug #31979)
Credit for this patch goes to some one else, as yet unidentif
28 matches
Mail list logo
