Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-14 Thread Dan Kegel
On Sat, Oct 13, 2012 at 4:40 PM, Max TenEyck Woodbury wrote: > ... There are criteria beyond the two you mentioned, > but it is rare to see them come into play. Few people know enough to > even recognize such problems. While far from an expert on such matters, > I have enough background to recog

Re: ole32/tests: Add tests for IRunnableObject_Run call.

2012-10-14 Thread Dmitry Timoshkov
Roman Dadkov wrote: > +hr = CLSIDFromProgID(WordApp, &clsid); > +if (SUCCEEDED(hr)) > +{ > +hr = CoCreateInstance(&clsid, NULL, CLSCTX_ALL, &IID_IUnknown, (void > **)&pUnknown); > +ok_ole_success(hr, "CoCreateInstance"); > + > +hr = IUnknown_QueryInterface(pUn

Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-14 Thread Max TenEyck Woodbury
On 10/14/2012 05:33 AM, GOUJON Alexandre wrote: > On 10/14/2012 01:40 AM, Max TenEyck Woodbury wrote: >> Dan: >> >> AJ and DT can both speak for themselves, and have just done so. It >> is now AJs decision. There are criteria beyond the two you mentioned, >> but it is rare to see them come into p

Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-14 Thread GOUJON Alexandre
On 10/14/2012 01:40 AM, Max TenEyck Woodbury wrote: Dan: AJ and DT can both speak for themselves, and have just done so. It is now AJs decision. There are criteria beyond the two you mentioned, but it is rare to see them come into play. Few people know enough to even recognize such problems.