Re: [1/2] dinput/tests: Test for DIPROP_INSTANCENAME and DIPROP_GUIDANDPATH

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22112 Your paranoid android

Re: wined3d: recognize Radeon HD 6670

On Fri, Oct 5, 2012 at 6:54 PM, Henri Verbeet wrote: > On 5 October 2012 22:12, Austin English wrote: >> Fixes http://bugs.winehq.org/show_bug.cgi?id=31891 >> > That doesn't look right (and doesn't do what you think it does > anyway), did you verify this against the Windows driver? It probably >

Re: shell32/tests: Test ShellExecute()'s URL handling.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22103 Your paranoid android

Re: shell32: Standardize on the ShellExecuteEx() terminology.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22104 Your paranoid android

Re: gdi32: use HandleToULong inline function to convert handle to index instead of casting

Daniel Lehman wrote: > 0x26a8 becomes 0xc9aa instead of just 0x9aa It can't, the code explicitly casts handle to unsigned before the shift. -- Dmitry.

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

"Vincas Miliūnas" wrote: > * Renamed DUMMYUNIONNAME to u. ... > +typedef struct _FILE_ID_DESCRIPTOR { > +DWORDdwSize; > +FILE_ID_TYPE Type; > +union { > +LARGE_INTEGER FileId; > +GUID ObjectId; > +} u; > +} FILE_ID_DESCRIPTOR, *LPFILE_ID_DESCRIPTOR

Re: vbscript: Fixed tests on some non-English configs (without '.' as decimal point)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22091 Your paranoid android

Re: [PATCH] vbscript: Undefined variables resolve as EMPTY without Option Explicit

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22090 Your paranoid android

Re: shell32/tests: Simplify shlexec's test_directory() and add some more tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22078 Your paranoid android

Re: shell32: Fix ShellExecute()'s handling of file URLs.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22079 Your paranoid android

Re: d3dx9_36 [patch 5/5, try 3]: Implement D3DXSHEvalSphericalLight

On 10.10.2012 09:49, Nozomi Kodama wrote: math.c:2994: Test failed: Red: case 9, order 7: expected[10] = 0.00, received -134495294795062701298349336420239278080.00 math.c:2994: Test failed: Red: case 9, order 7: expected[15] = 0.00, received -131556728585661638158151798785793064960.00

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

On Wed, Oct 10, 2012 at 10:42:53AM +0200, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > David Laight wrote: > > >Better to code as: > >status = wmm->dwStatus; > >if (...) > Incidentally, that's what I did tonight in patch 20/25 try 2. > > >but even then I think the compiler

Re: msvcp90: in codecvt::do_out, copy local buffer to *to_next

On 10/10/12 19:42, Daniel Lehman wrote: +memcpy_s(*to_next, MB_LEN_MAX, buf, size); You may use memory after to_end in this code. to_next buffer size should be probably following: memcpy_s(*to_next, to_end-to_next, buf, size); Cheers, Piotr

Re: [PATCH 5/5] kernel32: Added implementation for OpenFileById.

"Vincas Miliūnas" wrote: > >> +objectName.Buffer = (WCHAR > >> *)&lpFileID->DUMMYUNIONNAME.FileId; > > This doesn't look right. > That's how the pointer to the fileid is transported, see the > file_id_to_unix_file_name function in ntdll/directory.c I meant DUMMYUNIONNAME. -- D

Re: [PATCH 3/3] vbscript: Added RTrim implementation

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22088 Your paranoid android

Re: [PATCH 5/5] kernel32: Added implementation for OpenFileById.

On 10/10/2012 05:45 AM, Dmitry Timoshkov wrote: > "Vincas Miliūnas" wrote: > >> +objectName.Buffer = (WCHAR >> *)&lpFileID->DUMMYUNIONNAME.FileId; > This doesn't look right. That's how the pointer to the fileid is transported, see the file_id_to_unix_file_name function in ntdll/di

Re: [4/4] windowscodecs: Test GIF metadata using a specially created GIF image with a bunch of extensions.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22045 Your paranoid android

Re: [PATCH 25/25] mciseq: MCI tempo is expressed in beats per minute, not microseconds.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22031 Your paranoid android

Re: [2/4] windowscodecs: Add a bunch of tests for GIF Comment Extenstion metadata reader.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22044 Your paranoid android

Re: oledb32: Add IDBProperties support in IDBInitialize

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22030 Your paranoid android

Re: [1/4] gdiplus: Add a font transformation test.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22043 Your paranoid android

Re: [2/4] shell32/tests: Improve the shell_execute{_ex}() tracing.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22055 Your paranoid android

Re: gdiplus: Add more font transformation tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22066 Your paranoid android

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22064 Your paranoid android

Re: [PATCH 2/2] jscript: Added support for pstrFormalParams argument in ParseProcedureText

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22063 Your paranoid android

Re: [4/4] shell32/tests: Some more type consistency fixes for the ShellExecute() return value checks.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22057 Your paranoid android

Re: [3/4] shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22056 Your paranoid android

Re: [1/4] shell32/tests: Fix test_one_cmdline() and add a few more tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22054 Your paranoid android

Re: [PATCH 1/5] d3d10: Handle blend state in d3d10_effect_object_apply().

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22053 Your paranoid android

Re: mshtml: Return dispinterface from PHEventSink::QueryInterface

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22047 Your paranoid android

Re: vbscript: Added CStr implementation

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22046 Your paranoid android

Re: [6/6] dwrite: Implement GetString()

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22042 Your paranoid android

Re: [5/6] dwrite: Implement GetStringLength method

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22041 Your paranoid android

Re: [3/6] dwrite: Added IDWriteFontFace stub

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22040 Your paranoid android

Re: [2/6] dwrite: Added IDWriteLocalizedStrings stub

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22039 Your paranoid android

Re: [1/6] dwrite: Store font family name in IDWriteFontFamily implementation

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22038 Your paranoid android

Re: [PATCH 17/25] winmm/tests: Add initial set of MCI MIDI tests (incl. DeleteFile)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22026 Your paranoid android

Re: [PATCH 18/25] winmm/tests: Add more MCI MIDI tests (auto-open).

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22027 Your paranoid android

Re: [PATCH 17/25] winmm/tests: Add initial set of MCI MIDI tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22025 Your paranoid android

Re: [3/3] shell32/tests: Greatly expand the test_argify() tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22024 Your paranoid android

Re: [2/3] shell32/tests: Merge shlexec's test_exes_long() with the other parameter passing tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22023 Your paranoid android

Re: [4/4] ole32: Implement StgConvertVariantToProperty.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22019 Your paranoid android

Re: [2/4] ole32: Add tests for StgConvertVariantToProperty.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22018 Your paranoid android

Re: [2/4] winemaker: Generate def file from spec file with winebuild (try 2)

André Hentschel writes: > @@ -2569,6 +2570,7 @@ sub generate_project_files($) > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) > \$(${canon}_MODULE:.dll=.def)\n"; >} elsif (@$target[$T_TYPE] == $TT_DLL) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS)

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

On 10/10/2012 10:42 AM, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > David Laight wrote: > >> Better to code as: >>status = wmm->dwStatus; >>if (...) > Incidentally, that's what I did tonight in patch 20/25 try 2. > >> but even then I think the compiler is allowed to perform

Re: d3dx9_36 [patch 2/5, try 3]: Implement D3DXSHEvalHemisphereLight

On 10.10.2012 09:44, Nozomi Kodama wrote: +if ( green_out ) Same as last time: I'd use "if (x == y)" without spaces on all occurrences... there are a couple of them in the patch! Please make all consistent in the patch.

Re: d3dx9_36 [patch 3/5, try 3]: Implement handy computations for small orders in D3DXSHRotate

On 10.10.2012 09:45, Nozomi Kodama wrote: +CONST FLOAT coeff[]={ +out[7] -= (matrix->u.m[1][0] * matrix->u.m[0][2] + matrix->u.m[1][2] * matrix->u.m[0][0]) * in[4]; + +out[7] += (matrix->u.m[1][0] * matrix->u.m[2][2] + matrix->u.m[1][2] * matrix->u.m[2][0]) * in[5]; Em

[PATCH 10/25] mciseq: Limit concurrency when starting to play.

Hi, David Laight wrote: >Better to code as: >status = wmm->dwStatus; >if (...) Incidentally, that's what I did tonight in patch 20/25 try 2. >but even then I think the compiler is allowed to perform extra reads. >It might, for example, do so if the condition was complicayted and