Re: [PATCH 5/5] kernel32: Added implementation for OpenFileById.

2012-10-09 Thread Dmitry Timoshkov
"Vincas Miliūnas" wrote: > +objectName.Buffer = (WCHAR > *)&lpFileID->DUMMYUNIONNAME.FileId; This doesn't look right. > +if (status) > +{ > +SetLastError( RtlNtStatusToDosError( status ) ); > +return INVALID_HANDLE_VALUE; > +} > +else if (!result

Re: [PATCH 1/5] include: Added definitions used by GetFileInformationByHandleEx.

2012-10-09 Thread Dmitry Timoshkov
"Vincas Miliūnas" wrote: > +typedef struct _FILE_ID_DESCRIPTOR { > +DWORDdwSize; > +FILE_ID_TYPE Type; > +union { > +LARGE_INTEGER FileId; > +GUIDObjectId; > +#if (_WIN32_WINNT >= 0x0602) > +EXT_FILE_ID_128 ExtendedFileId; > +#endif > +

Re: Wine test bot

2012-10-09 Thread Christian Costa
Le 06/10/2012 06:13, Christian Costa a écrit : Hi, Is there a problem with Wine test bost? Jobs seem to be stuck and some VMs show problem of memory. Christian Wine test bost is still stuck. Any plan to fix that problem?

Re: wbemprox: support for getting methods from WBEM objects

2012-10-09 Thread Hans Leidekker
On Tue, 2012-10-09 at 20:30 +0200, Daniel Jelinski wrote: > diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c > index c414aa9..71c62c8 100644 > --- a/dlls/wbemprox/table.c > +++ b/dlls/wbemprox/table.c > @@ -63,6 +63,7 @@ UINT get_type_size( CIMTYPE type ) > return sizeof(INT64);

Re: Updated Wine Wiki Repo

2012-10-09 Thread André Hentschel
Am 09.10.2012 06:22, schrieb Kyle Auble: > On Mon, Oct 8, 2012 at 5:17 PM, André Hentschel wrote: > >> Am 08.10.2012 01:06, schrieb Kyle Auble: >>> Just wanted to let everyone know I've created a >>> git repo for the Wine Wiki from the CVS one at >>> SourceForge. You can find it at: >>> https://bi

Re: ole32: Fix dwClsContext parameter of a CoCreateInstance call in DefaultHandler_Run. (try 2)

2012-10-09 Thread Austin English
On Tue, Oct 9, 2012 at 4:27 AM, Roman Dadkov wrote: > This patch change dwClsContext parameter of a CoCreateInstance call in > function DefaultHandler_Run. > Because even if there is some clsid in the registry, the function will not > be able to run the newly created object. > Unfortunately, the t

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-09 Thread David Laight
On Tue, Oct 09, 2012 at 04:05:09PM +0200, Alexandre Julliard wrote: ... > >> Also there's no such thing as > >>"conceptually volatile", unless you add explicit memory barriers. > > Forget about "conceptually volatile". I meant to express the idea > > that some variable may be updated from another

Re: d3dx9_36 [patch 5/5]: Implement D3DXSHEvalSphericalLight

2012-10-09 Thread Rico Schüller
On 09.10.2012 09:50, Nozomi Kodama wrote: +CONST FLOAT coeff[6] = { +2.0f * sqrtf(D3DX_PI), 2.0f * sqrtf(D3DX_PI / 3.0f), 0.4f * sqrtf(5.0f * D3DX_PI), +2.0f * sqrtf(D3DX_PI / 7.0f), 2.0f / 3.0f * sqrtf(D3DX_PI), 2.0f * sqrt (D3DX_PI / 11.0f) }; Pretty much the same commen

Re: d3dx9_36 [patch 4/5]: Implement D3DXSHEvalConeLight

2012-10-09 Thread Rico Schüller
On 09.10.2012 09:50, Nozomi Kodama wrote: +static void CapIntegrale(FLOAT *out, FLOAT order, FLOAT angle) +{ I'd use a lower case name. +if (order == 5) +return; Indentation. If you break to a new line, please indent 8 spaces (in the case for ok(...)). +2.0f * sqrtf(D3DX_PI

Re: d3dx9_36 [patch 3/5]: Implement handy computations for small orders in D3DXSHRotate

2012-10-09 Thread Rico Schüller
On 09.10.2012 09:49, Nozomi Kodama wrote: +FLOAT temp[25]; +CONST FLOAT coeff[]={ +matrix->u.m[1][0] * matrix->u.m[0][0], matrix->u.m[1][1] * matrix->u.m[0][1], +matrix->u.m[1][1] * matrix->u.m[2][1], matrix->u.m[1][0] * matrix->u.m[2][0], +ma

Re: gdiplus: Add more font transformation tests.

2012-10-09 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > +todo_wine > > +expectf(133.203125, bounds.Height); > > Should we have this level of precision in our font tests? We have already, and it works pretty well. There are cases when it's not practical, but this is not the case I believe. -- Dmitry.

Re: d3dx9_36 [patch 2/5]: Implement D3DXSHEvalHemisphereLight

2012-10-09 Thread Rico Schüller
On 09.10.2012 09:49, Nozomi Kodama wrote: +HRESULT WINAPI D3DXSHEvalHemisphereLight(UINT order, CONST D3DXVECTOR3 *dir, D3DXCOLOR top, D3DXCOLOR bottom, FLOAT *rout, FLOAT *gout, FLOAT *bout) The number of columns used for the code seems to be a little high again. +if (j >= 4

Re: gdiplus: Add more font transformation tests.

2012-10-09 Thread Vincent Povirk
> +todo_wine > +expectf(133.203125, bounds.Height); Should we have this level of precision in our font tests?

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-09 Thread Alexandre Julliard
writes: > Alexandre Julliard wrote: > >>This makes no sense, you can't make assumptions about the generated code >>from the shape of the if statements. > Don't || and && impose an evaluation order? Only if there are side effects. >> Also there's no such thing as >>"conceptually volatile", unles

[PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-09 Thread Joerg-Cyril.Hoehle
Alexandre Julliard wrote: >This makes no sense, you can't make assumptions about the generated code >from the shape of the if statements. Don't || and && impose an evaluation order? > Also there's no such thing as >"conceptually volatile", unless you add explicit memory barriers. Forget about "co

Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-09 Thread Henri Verbeet
On 9 October 2012 11:26, Alistair Leslie-Hughes wrote: > Changelog: > scrrun: Implement IDictionary_Add and Count > Actually, does it ever make sense to use a linked list at all to implement a dictionary? It seems to me that if you only ever have a handful of entries a simple array would be b

Re: Updated Wine Wiki Repo

2012-10-09 Thread Henri Verbeet
On 9 October 2012 00:17, André Hentschel wrote: > Am 08.10.2012 01:06, schrieb Kyle Auble: >> Just wanted to let everyone know I've created a >> git repo for the Wine Wiki from the CVS one at >> SourceForge. You can find it at: >> https://bitbucket.org/kauble/wine-wiki-migration > > Not sure if bi

Re: [3/3] winemaker: Generate def file from spec file with winebuild

2012-10-09 Thread Alexandre Julliard
André Hentschel writes: > @@ -2576,7 +2577,9 @@ sub generate_project_files($) >if (@$target[$T_TYPE] == $TT_DLL && (@$project_settings[$T_FLAGS] & > $TF_HASDEF)) { > print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) > \$(${canon}_MODULE:.dll=.def)\n"; >} elsif (@$t