Re: Help getting amd64 assembly patch into wine?

2012-10-04 Thread Dan Kegel
On Thu, Oct 4, 2012 at 1:52 PM, Kyle Auble wrote: > I'm just wondering is assembly definitely needed? > This is just based on some googling and skimming > through StackOverflow, but it sounds like you can > still use va_list on amd64. It just takes some > tweaking: > http://stackoverflow.com/quest

Re: Help getting amd64 assembly patch into wine?

2012-10-04 Thread Kyle Auble
On 10/03/2012 09:49 PM, Dan Kegel wrote: > The main challenge was figuring out how to get the variable > list of arguments off the stack, and then put them back onto > the stack when calling the provided function pointer. > This bit of varargs hackery can't be done in pure C as far as I > can tell

Re: [PATCH 2/2] mshtml: Added ActiveX event binding test

2012-10-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22013 Your paranoid android

Re: [PATCH 2/2] mshtml: Added ActiveX event binding test

2012-10-04 Thread Jacek Caban
On 10/04/12 15:02, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: [PATCH 5/5] winex11: Don't send SC_RESTORE when a maximized window switches to fullscreen.

2012-10-04 Thread Dmitry Timoshkov
Henri Verbeet wrote: > -if (style & WS_MAXIMIZE) > +if ((style & WS_MAXIMIZE) && (style & WS_CAPTION) == WS_CAPTION) Probably you should test for WS_MAXIMIZEBOX instead. -- Dmitry.

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.

2012-10-04 Thread Christian Costa
2012/10/4 Thomas Faber > On 2012-10-04 13:07, Christian Costa wrote: > > 2012/10/4 Paul Chitescu > >> AFAIK the structure differs for each major version of Windows and some > SP > >> too. > >> > >> > > I was expecting something like this. :( > > > > > >> At the minimum I saw some drivers expecti

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.

2012-10-04 Thread Thomas Faber
On 2012-10-04 13:07, Christian Costa wrote: > 2012/10/4 Paul Chitescu >> AFAIK the structure differs for each major version of Windows and some SP >> too. >> >> > I was expecting something like this. :( > > >> At the minimum I saw some drivers expecting that at the returned pointer >> to be >> a

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.

2012-10-04 Thread Christian Costa
2012/10/4 Paul Chitescu > On Thursday 04 October 2012 08:25:13 am Dmitry Timoshkov wrote: > > Christian Costa wrote: > > > PEPROCESS WINAPI IoGetCurrentProcess(void) > > > { > > > -FIXME("() stub\n"); > > > -return NULL; > > > +TRACE("()\n"); > > > + > > > +/* Return current pr

Re: [PATCH] reg.exe: comparing the names of registry keys

2012-10-04 Thread Jacek Caban
On 10/04/12 08:03, Mieczyslaw Nalewaj wrote: > +static BOOL strings_equal(LPWSTR lpString1, const WCHAR *lpString2) > +{ > +int cchCount; Please avoid Hungarian style variable names. Also is seems like the function not exactly compares strings, so something like is_subkey could be more appropr

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.

2012-10-04 Thread Paul Chitescu
On Thursday 04 October 2012 08:25:13 am Dmitry Timoshkov wrote: > Christian Costa wrote: > > PEPROCESS WINAPI IoGetCurrentProcess(void) > > { > > -FIXME("() stub\n"); > > -return NULL; > > +TRACE("()\n"); > > + > > +/* Return current process id since PEPROCESS is opaque and drive

Re: user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

2012-10-04 Thread Alexandre Julliard
André Hentschel writes: > @@ -5173,10 +5173,10 @@ const struct builtin_class_descr EDIT_builtin_class = > editW,/* name */ > CS_DBLCLKS | CS_PARENTDC, /* style */ > WINPROC_EDIT, /* proc */ > -#ifdef __i386__ > -sizeof(EDITSTATE *) + sizeof(WORD), /* e

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

2012-10-04 Thread Qian Hong
Hello, On Thu, Oct 4, 2012 at 3:34 PM, Dmitry Timoshkov wrote: > I just tested with japanese locale, I don't have a localized japanese > Windows here. Hello, Now I tested on my Chinese Windows, change the locale to Japanese as the steps from http://windows.microsoft.com/en-US/windows-vista/Cha

Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.

2012-10-04 Thread Christian Costa
Le 04/10/2012 07:28, Dmitry Timoshkov a écrit : Christian Costa wrote: +/* Read memory from the client process memory */ +if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), mdl->ByteCount, &byte

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

2012-10-04 Thread Dmitry Timoshkov
Qian Hong wrote: > What version of Japanese Windows did you test last time? I just tested with japanese locale, I don't have a localized japanese Windows here. -- Dmitry.

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

2012-10-04 Thread Qian Hong
Hello, On Thu, Oct 4, 2012 at 3:19 PM, Dmitry Timoshkov wrote: > I wouldn't pay too much attention to the XP results, what about results > on newer Windows versions? I don't have Japanese version of Vista or Win7, there seems no Japanese Vista or Japanese Win7 in our winehq testbots. I tested on

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

2012-10-04 Thread Dmitry Timoshkov
Qian Hong wrote: > On Thu, Oct 4, 2012 at 3:03 PM, Dmitry Timoshkov wrote: > > On what system do you see broken results? I'm asking because i did run > > this test with japanese locale at the time I touched it last time. > > Please see https://testbot.winehq.org/JobDetails.pl?Key=21902#k207 ( >

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

2012-10-04 Thread Qian Hong
Hello, On Thu, Oct 4, 2012 at 3:03 PM, Dmitry Timoshkov wrote: > On what system do you see broken results? I'm asking because i did run > this test with japanese locale at the time I touched it last time. Please see https://testbot.winehq.org/JobDetails.pl?Key=21902#k207 ( WXPPROJASP3 ) Thanks!

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

2012-10-04 Thread Dmitry Timoshkov
Qian Hong wrote: > --- > dlls/gdi32/tests/font.c | 16 > 1 files changed, 8 insertions(+), 8 deletions(-) On what system do you see broken results? I'm asking because i did run this test with japanese locale at the time I touched it last time. -- Dmitry.