Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.

2012-10-03 Thread Dmitry Timoshkov
Christian Costa wrote: > +/* Read memory from the client process memory */ > +if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + > mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), > mdl->ByteCount, &bytes)) This kind of casts is broken. -- Dm

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.

2012-10-03 Thread Dmitry Timoshkov
Christian Costa wrote: > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > -FIXME("() stub\n"); > -return NULL; > +TRACE("()\n"); > + > +/* Return current process id since PEPROCESS is opaque and drivers > should not access the struct directly */ > +return (PEPROCESS)PsGetCu

Help getting amd64 assembly patch into wine?

2012-10-03 Thread Dan Kegel
As you might know from watching too many of my patches scroll by, I've been working on adding support for OpenMP to wine. (A handful of games, and a lot of serious apps, seem to use that api.) After getting it nicely organized and cleaned up to the point where it passed all the tests I could thro

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21999 Your paranoid android

Re: shell32/tests: Write proper tests for CommandLineToArgvW(). (try2)

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22000 Your paranoid android

Re: shell32/tests: Simplify shlexec's test_argify() and test_lpFile_parsed() and avoid numeric literals.

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21998 Your paranoid android

Re: AppDB: Could someone please block this Spammer (UCE)

2012-10-03 Thread Joerg Schiermeier
On Wednesday, October 3, 2012 at 17:13:21 Rosanne DiMesio wrote: > My Preferences screen has an option to "Disable global e-mail > notifications (only send for maintained apps)", but I'm not sure if > that's something only admins have. I (just) filed this under the bug #31880 in wines Bugzilla.

Re: Overriding the check for ownership of a prefix

2012-10-03 Thread Scott Ritchie
On 9/19/12 5:23 PM, Scott Ritchie wrote: So, I believe I have a legitimate use case for ignoring this, and want to know what sort of patch would go forward. Imagine a distro package containing a Windows game in the form of a read-only copy of an installed prefix (into, say, /opt). When the use

Re: AppDB: Could someone please block this Spammer (UCE)

2012-10-03 Thread Joerg Schiermeier
Hello Rosanne, you wrote: RD> My Preferences screen has an option to "Disable global e-mail RD> notifications (only send for maintained apps)", but I'm not sure RD> if that's something only admins have. I think you're right: in my prefs I only see 'Send email notifications' with 'yes' and 'no'.

Re: [PATCH] advapi32: avoid memory leaks (Coverity)

2012-10-03 Thread Alexandre Julliard
Marcus Meissner writes: > @@ -530,8 +530,10 @@ static void test_enum_providers(void) > /* alloc provider to half the size required >* cbName holds the size required */ > providerLen = cbName / 2; > - if (!(provider = LocalAlloc(LMEM_ZEROINIT, providerLen))) > + if (!(p

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

2012-10-03 Thread Jacek Caban
On 10/03/12 14:57, Marcus Meissner wrote: > On Tue, Oct 02, 2012 at 01:19:37PM +0200, Jacek Caban wrote: >> Hi Marcus, >> >> On 10/01/12 23:00, Marcus Meissner wrote: >>> Hi, >>> >>> Various coverity issues complain about user-after-free scenarios, >>> all involving this code path. >>> >>> I strong

Re: [PATCH 2/2] vbscript: Added Right() implementation

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21987 Your paranoid android

Re: ImmIsUIMessageA/W

2012-10-03 Thread André Hentschel
Am 03.10.2012 17:19, schrieb Aric Stewart: > Great! > > Looking at the application I have that was requiring this i have found that > by adding the "IME" window class it has actually corrected its behavior. > > You are correct to have removed that redirection and I will not submit a > patch to

Re: ImmIsUIMessageA/W

2012-10-03 Thread Aric Stewart
Great! Looking at the application I have that was requiring this i have found that by adding the "IME" window class it has actually corrected its behavior. You are correct to have removed that redirection and I will not submit a patch to re-add it as it is incorrect. thanks for the help! -aric

Re: AppDB: Could someone please block this Spammer (UCE)

2012-10-03 Thread Rosanne DiMesio
On Wed, 3 Oct 2012 16:24:54 +0200 "Joerg Schiermeier" wrote: > Hello André, > > AH> In the meantime you could change your preferences in the appdb (Send > email notifications) > > Than I'm in peace - that's right. > > But this have a side-effect: > I also will not be informed by AppDB if some

Re: AppDB: Could someone please block this Spammer (UCE)

2012-10-03 Thread Joerg Schiermeier
Hello André, AH> In the meantime you could change your preferences in the appdb (Send email notifications) Than I'm in peace - that's right. But this have a side-effect: I also will not be informed by AppDB if someone add a new test or a comment in my attended applications: the mails to remain

Re: AppDB: Could someone please block this Spammer (UCE)

2012-10-03 Thread Joerg Schiermeier
Hello Rosanne, sorry for misspelling your first name in my mail before. > I tried deleting the spammer's account, and the system asked me if > I really wanted to, but it didn't delete it even after I said yes. > I'm not sure that would have helped anyway, as he could easily just > create a new ac

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

2012-10-03 Thread Marcus Meissner
On Tue, Oct 02, 2012 at 01:19:37PM +0200, Jacek Caban wrote: > Hi Marcus, > > On 10/01/12 23:00, Marcus Meissner wrote: > > Hi, > > > > Various coverity issues complain about user-after-free scenarios, > > all involving this code path. > > > > I strongly think if call_ret signals error, we also ne

Re: AppDB: Could someone please block this Spammer (UCE)

2012-10-03 Thread André Hentschel
Am 03.10.2012 05:01, schrieb Rosanne DiMesio: > On Tue, 2 Oct 2012 23:48:22 +0200 > "newsletter [at] Schiermeier-Software" > wrote: > >> >> Please Rosane, help us...! >> >> Thanks a lot! >> > > I'd love to, but if the AppDB has a way to ban users, I don't have access to > it. I've already dele

Re: imm32: have IMM class return TRUE for WM_QUERYENDSESSION

2012-10-03 Thread Aric Stewart
Looking over my documentation it is explicit about many messages that cannot be passed to DefWndProc, but it looks like we can us it. I will revise the patch and send that. -aric On 10/3/12 4:31 AM, Alexandre Julliard wrote: > Aric Stewart writes: > >> resolves bug 31832 >> --- >> dlls/im

Re: [2/2] vbscript: Support vb* constants for message box return value (try2)

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21981 Your paranoid android

Re: [1/2] vbscript: Support vb* constants for message box buttons (try2)

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21980 Your paranoid android

Re: [1/2] vbscript: Support vb* constants for message box buttons

2012-10-03 Thread Nikolay Sivov
On 10/3/2012 13:54, Jacek Caban wrote: Hi Nikolay, On 10/03/12 13:34, Nikolay Sivov wrote: Support vb* constants for message box buttons How about using MB_* constants from winuser.h instead of hardcoding them here? Other than that, the patch looks good to me. Jacek Sure, that would be clean

Re: [1/2] vbscript: Support vb* constants for message box buttons

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21978 Your paranoid android

Re: [2/2] oledb32: Add support for IDBInitialize interface in IDataInitialize

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21975 Your paranoid android

Re: [1/2] vbscript: Support vb* constants for message box buttons

2012-10-03 Thread Jacek Caban
Hi Nikolay, On 10/03/12 13:34, Nikolay Sivov wrote: > Support vb* constants for message box buttons How about using MB_* constants from winuser.h instead of hardcoding them here? Other than that, the patch looks good to me. Jacek

Re: [2/2] vbscript: Support vb* constants for message box return value

2012-10-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21979 Your paranoid android

Re: wininet: Fixed failing test

2012-10-03 Thread Dmitry Timoshkov
Piotr Caban wrote: > -ok(ret, "GetUrlCacheEntryInfoExW failed with error %d\n", > GetLastError()); > +ok(ret || broken(!ret) /* IE6 */, "GetUrlCacheEntryInfoExW failed with > error %d\n", GetLastError()); This kind of blanket test results coverage is broken from the start. -- Dmitry.

Re: imm32: have IMM class return TRUE for WM_QUERYENDSESSION

2012-10-03 Thread Alexandre Julliard
Aric Stewart writes: > resolves bug 31832 > --- > dlls/imm32/imm.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Is there any reason why we are not simply calling DefWindowProc? -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails.

2012-10-03 Thread Jacek Caban
On 10/02/12 23:02, Erich E. Hoover wrote: > If a cleanup occurs because HTML Help window creation fails then > list_remove() causes a crash, since the window was never added to the > window list. The attached patch fixes this issue, allowing safe > reloading of files (needed for part 2). This loo

Re:cmd: /r is equivalent to /c

2012-10-03 Thread Ann and Jason Edmeades
Concept of patch is fine (and we ought to support it), but I dont think this would work as coded (if (tolowerW(c)=='c'||'r') will always be true). Also, can you add a quick test for it (there's cmd.exe /c tests - just add a cmd.exe /r echo test worked). PS You might want to just hold off until t