Re: [PATCH] scsiport.sys: Add stub implementaton of scsiport.sys.

2012-10-01 Thread Christian Costa
Le 02/10/2012 00:26, André Hentschel a écrit : Am 02.10.2012 00:10, schrieb Christian Costa: This is needed by prosync1.sys (StarForce protection) used in Obscure. --- configure | 284 +-- configure.ac|1

Re: [PATCH] scsiport.sys: Add stub implementaton of scsiport.sys.

2012-10-01 Thread André Hentschel
Am 02.10.2012 00:10, schrieb Christian Costa: > This is needed by prosync1.sys (StarForce protection) used in Obscure. > --- > configure | 284 > +-- > configure.ac|1 > dlls/scsiport.sys/Makefile.in |

Wine Mono 0.0.8 Release

2012-10-01 Thread Vincent Povirk
Since I messed up the 0.0.6 release, here's another one, almost identical. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.8.tar.gz/download The binary is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.8/wine-mono-0.0.8.msi/downlo

Re: ws2_32: Fix TRACE format in WS_getsockname (try 2)

2012-10-01 Thread Bruno Jesus
On Mon, Oct 1, 2012 at 12:37 AM, Dmitry Timoshkov wrote: > Bruno Jesus <00cp...@gmail.com> wrote: > >> -TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); >> +TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, namelen?*namelen:0); > > Adding some spaces to make this slightly mo

Re: [PATCH 6/6] wininet/tests: Remove all temporary files

2012-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21929 Your paranoid android

Re: [PATCH 5/6] wininet: Set entry type based on container type

2012-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21928 Your paranoid android

Re: [PATCH 4/6] wininet: Added support for cache entries overwritting

2012-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21927 Your paranoid android

Re: [1/4] Assorted spelling fixes.

2012-10-01 Thread Piotr Caban
Hi, On 10/01/12 13:07, Julian Rüger wrote: Hi Francois, - * size [I] How much percent of cache space should be free. + * size [I] How many percents of the cache should be free. Maybe something like "Precentage of cache that should be free" would sound more natural. Howe

Re: [PATCH 1/2] vbscript: Added Left() implementation

2012-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21919 Your paranoid android

Re: [1/4] Assorted spelling fixes.

2012-10-01 Thread Julian Rüger
Hi Francois, > - * size [I] How much percent of cache space should be free. > + * size [I] How many percents of the cache should be free. Maybe something like "Precentage of cache that should be free" would sound more natural. However I'm not sure of the intended meaning her

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

2012-10-01 Thread Jacek Caban
Hi Marcus, On 09/29/12 11:44, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if no

Re: mshtml: Implement IHTMLFrameBase_put_name()

2012-10-01 Thread Nikolay Sivov
On 10/1/2012 11:14, Jacek Caban wrote: Hi Nikolay, On 09/30/12 20:36, Nikolay Sivov wrote: http://bugs.winehq.org/show_bug.cgi?id=31835 The code may be simple and obvious, but I'd still like to see a test. A simple call should be enough just to make sure it's executed when I test new Gecko bui

Re: mshtml: Implement IHTMLFrameBase_put_name()

2012-10-01 Thread Jacek Caban
Hi Nikolay, On 09/30/12 20:36, Nikolay Sivov wrote: > http://bugs.winehq.org/show_bug.cgi?id=31835 The code may be simple and obvious, but I'd still like to see a test. A simple call should be enough just to make sure it's executed when I test new Gecko builds. Jacek

Re: d3dx9_36 [patch 2/5, try 4]: Speed-up some tests.

2012-10-01 Thread Rico Schüller
On 01.10.2012 03:28, Nozomi Kodama wrote: +for (order = 0; order <= D3DXSH_MAXORDER + 1 ; order++) Well, I'm not sure what you are doing with the spaces ... I say it again, if you got a comment, read it carefully take a look at your code and fix it. I mentioned white space issues a couple

Re: d3dx9_36 [patch 1/5, try 4]: Implement D3DXSHMultiply4

2012-10-01 Thread Rico Schüller
On 01.10.2012 03:27, Nozomi Kodama wrote: I used FLOAT * WINAPI, though I don't like it. Yeah, that's not much of an issue... and this is not the showstopper. +TRACE("(out %p, a %p, b %p)\n", out, a, b); What I'm a bit curious about is, why do you reinvent a new style in a new patch (see