Re: comctl32: use GetWindowLong to check for scrollbar (try 2)

2012-09-28 Thread Nikolay Sivov
On 9/28/2012 20:43, Daniel Jelinski wrote: Corrected from first try: - uses GetWindowLong instead of GetWindowLongPtr - does not touch dwStyle Sorry, was busy to reply earlier. I think this fix is ok if it really helps, thanks for working on this.

Re: [PATCH] configure: use -Wp, -D_FORTIFY_SOURCE=0 instead of -D_FORTIFY_SOURCE=0

2012-09-28 Thread Anssi Hannula
28.09.2012 18:14, Alexandre Julliard kirjoitti: > Anssi Hannula writes: > >> Some Linux distributions (at least Mageia) build packages with >> -Wp,-D_FORTIFY_SOURCE=2 by default. There is a check in configure which >> checks for enabled fortify and adds "-U_FORTIFY_SOURCE >> -D_FORTIFY_SOURCE=0".

Re: [PATCH] configure: use -Wp, -D_FORTIFY_SOURCE=0 instead of -D_FORTIFY_SOURCE=0

2012-09-28 Thread Alexandre Julliard
Anssi Hannula writes: > Some Linux distributions (at least Mageia) build packages with > -Wp,-D_FORTIFY_SOURCE=2 by default. There is a check in configure which > checks for enabled fortify and adds "-U_FORTIFY_SOURCE > -D_FORTIFY_SOURCE=0". Unfortunately, -Wp,-Dfoo are applied after -Dfoo, > so

Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame. Take 2.

2012-09-28 Thread Vincent Povirk
Looks good, thanks.

Re: [PATCH 2/2] vbscript: Added MonthName implementation

2012-09-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21880 Your paranoid android

Re: gdi32: Fixed freetype working function

2012-09-28 Thread Alexandre Julliard
Сергей Мосин writes: > The function WineEngAddFontMemResourceEx in gdi32/fretype.c contained > strange XOR operation with some random number 0x87654321, instead of > returning the real font handle. Do you have an app that depends on this? What does it do with the handle? -- Alexandre Julliard

Re: [PATCH] msi: Use next cabinet from the media table instead of failing when there is a mismatch with continuous cabinet.

2012-09-28 Thread Hans Leidekker
On Thu, 2012-09-27 at 23:07 +0200, Christian Costa wrote: > >> if (!(cabinet_file = get_cabinet_filename(mi))) > > The requirement that the continuous cabinet name matches the next cabinet > > in the media table > > might simply be too strict. Perhaps we need to try them one by one and let