Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-24 Thread Per Johansson
Hi, I should probably add a note that when I wrote this I had some doubts it it belongs in start.exe, and I still somewhat do. The alternative would be to write a new program. The advantage to that is: 1. start.exe is left more similar to it's windows counterpart. 2. This other program could han

Re: Overriding the check for ownership of a prefix

2012-09-24 Thread Scott Ritchie
On 9/24/12 2:48 AM, joerg-cyril.hoe...@t-systems.com wrote: Scott, I don't think you need to override this check, esp. given that there's a good reason for it being there: The good reason doesn't apply in this use case. Overriding it fixes every problem I'm facing without having to do anythi

d3dx9: Implement D3DXSHEvalDirectionalLight

2012-09-24 Thread Nozomi Kodama
Hello, do it remain problems with this patch? Nozomi

Wine Mono 0.0.6 Release - Because hey, why not?

2012-09-24 Thread Vincent Povirk
I have published version 0.0.6 of Wine Mono on Sourceforge, because it's probably not good to let it get too stale. The source tarball is at http://sourceforge.net/projects/wine/files/Wine%20Mono/0.0.6/wine-mono-0.0.6.tar.gz/download The binary is at http://sourceforge.net/projects/wine/files/Win

Re: ImmIsUIMessageA/W

2012-09-24 Thread André Hentschel
Am 21.09.2012 18:46, schrieb Aric Stewart: > Hi Andre, > > I have a quick question for you. I am looking into why IME unaware > applications are no longer showing their composition window and found it was > because of: > > commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 > Author: André Hentsche

Re: [PATCH] dmusic: Add master clock tests.

2012-09-24 Thread Andrew Eikum
On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote: > @@ -66,6 +68,11 @@ static void test_dmusic(void) > return; > } > > +hr = IDirectMusic_GetMasterClock(dmusic, &guid_clock, &clock); > +ok(hr == S_OK, "IDirectMusic_GetMasterClock returned: %x\n", hr); > +o

Re: [PATCH 1/2] jscript: Added support for limit argument in String.split

2012-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21756 Your paranoid android

Re: [PATCH 2/2] mshtml: Added function overriding tests

2012-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21757 Your paranoid android

Re: Assorted spelling fixes.

2012-09-24 Thread Julian Rüger
Hi Francois, > -/* if we set the bufferpointer to NULL here UrlUnescape fails and > string gets not converted */ > +/* if we set the buffer pointer to NULL here UrlUnescape fails and > the string is not converted */ for consistency with the other buffer pointer comments and be

Re: [PATCH 4/4] mshtml: Added IHTMLElement::contains implementation

2012-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21753 Your paranoid android

Re: [PATCH 2/4] mshtml: Added function overriding tests

2012-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21751 Your paranoid android

RFC: Locale-independent case-insensitive string comparison

2012-09-24 Thread Francois Gouget
diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 28f82a3..f465ad7 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -640,7 +640,7 @@ static void HTTP_FixURL(http_request_t *request) } } -if(CSTR_EQUAL != CompareStringW( LOCALE_SYSTEM_DEFAULT, NORM_IGNORE

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.

2012-09-24 Thread Christian Costa
2012/9/24 Józef Kucia > Hi, > > > On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa wrote: > >> +hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, >> D3DLOCK_READONLY); >> +ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, >> expected %#x\n", hr, D3D_OK); >>

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.

2012-09-24 Thread Henri Verbeet
On 23 September 2012 22:40, Ričardas Barkauskas wrote: > > +struct refresh_rates { Formatting. > +struct refresh_rates refresh_list[] = This should be static const. > +ok(hr == E_INVALIDARG, "GetDesc unexpectedly returend %#x.\n", hr); "returned". > +for (i = 0; i < sizeof(refresh_list)

Re: [3/4] dxgi: Avoid division by zero. Based on patch by Eduard - Gabriel Munteanu.

2012-09-24 Thread Henri Verbeet
On 23 September 2012 22:40, Ričardas Barkauskas wrote: > +static UINT dxgi_rational_to_uint(DXGI_RATIONAL *rational) "rational" should be const.

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.

2012-09-24 Thread Józef Kucia
On Sun, Sep 23, 2012 at 10:40 PM, Ričardas Barkauskas wrote: > +struct refresh_rates refresh_list[] = > +{ > +{60, 60, FALSE, FALSE}, > +{60, 0, TRUE, FALSE}, > +{60, 1, TRUE, TRUE}, > +{ 0, 60, TRUE, FALSE}, > +{ 0, 0, TRUE, FALSE}, > +}; It's probably better to decl

Re: [4/4] dxgi/tests: Test IDXGISwapChain_CreateSwapchain and IDXGISwapChain_GetDesc a bit.

2012-09-24 Thread Alexandre Julliard
Ričardas Barkauskas writes: > --- > dlls/dxgi/tests/Makefile.in |2 +- > dlls/dxgi/tests/device.c| 147 > +++ > 2 files changed, 148 insertions(+), 1 deletion(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dxgi.dll -T ../../.. -p

Overriding the check for ownership of a prefix

2012-09-24 Thread Joerg-Cyril.Hoehle
Scott, I don't think you need to override this check, esp. given that there's a good reason for it being there: >Note that there is a problem with this setup if the app modifies the >registry and we then need to update the prefix-default registry I've excellent experience with symbolic links. In

Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.

2012-09-24 Thread Józef Kucia
Hi, On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa wrote: > +hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL, > D3DLOCK_READONLY); > +ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x, > expected %#x\n", hr, D3D_OK); > +if (SUCCEEDED(hr)) > +

Re: Assorted spelling fixes.

2012-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21742 Your paranoid android