Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight

2012-09-14 Thread Henri Verbeet
On 14 September 2012 14:04, Rico Schüller wrote: > +FLOAT s, temp[max( 1, order * order )]; > Is this allowed in c and does it really work the way one would expect? > It is in C99 (look into VLAs), but Wine doesn't allow C99 features.

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).

2012-09-14 Thread Alexandre Julliard
Sergey Guralnik writes: > I've sent next patch more than month ago, and have no comments about > it. > > From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 > From: Sergey Guralnik > Date: Thu, 9 Aug 2012 17:12:56 +0400 > Subject: user32/tests: Add test for SetFocus() (with fe

Re: d3dx9_36 [patch 1/2]: Implement D3DXSHEvalDirectionalLight

2012-09-14 Thread Rico Schüller
On 14.09.2012 11:07, Nozomi Kodama wrote: Hello one remark about this patch. Test in real windows shows that D3DXSHEvalDirectionalLight accepts order > D3DXSH_MAXORDER or order < D3DXSH_MINORDER. But in these cases, the colour outputs are unpredictable. For the same calling arguments, D3DSXHEv

Re: [PATCH] advapi32: Eliminate dead stores (Clang).

2012-09-14 Thread Alexandre Julliard
Charles Davis writes: > @@ -615,9 +613,9 @@ static DWORD mac_write_credential(const CREDENTIALW > *credential, BOOL preserve_b > attr_list.count = 0; > attr_list.attr = NULL; > } > -status = SecKeychainItemModifyAttributesAndData(keychain_item, > &attr_list, > -