Re: [4/5] vcomp: better stubs for _vcomp_for_static_simple_init, _vcomp_for_static_end

2012-09-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21419 Your paranoid android

Re: [3/5] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next

2012-09-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21418 Your paranoid android

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

2012-09-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21417 Your paranoid android

Re: [1/2] gdiplus: Add some tests for scaling an image with various pixel offset modes. Take 2.

2012-09-06 Thread Dmitry Timoshkov
I hope that I've addressed Vincent's concern about todo_wine blanket coverage, is there anything else that prevents these 2 patches from being accepted? -- Dmitry.

Re: [PATCH 4/5] gdi32: Added font name tests on non English locale.

2012-09-06 Thread Alexandre Julliard
Qian Hong writes: > @@ -4110,7 +4120,9 @@ static void test_fullname2_helper(const char *Family) > > bufW[0] = 0; > bufA[0] = 0; > -ok(get_ttf_nametable_entry(hdc, TT_NAME_ID_FONT_FAMILY, bufW, > buf_size), "FAMILY (family name) could not be read\n"); > +ok(get

Re: [PATCH 4/6] msvcp60: Fixed RTTI structure on 64-bit systems (try2)

2012-09-06 Thread Alexandre Julliard
Piotr Caban writes: > try2: > - fixed base pointer offset calculation (patches 4,5,6) You should pass the module handle from DllMain instead. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 2/2] kernel32: Return correct drive type for empty drives (try2)

2012-09-06 Thread Alexandre Julliard
Alexandre Goujon writes: > @@ -2544,7 +2544,8 @@ static NTSTATUS DVD_ReadStructure(int dev, const > DVD_READ_STRUCTURE *structure, > } > > if (ioctl(dev, DVD_READ_STRUCT, &s) < 0) > - return STATUS_INVALID_PARAMETER; > +/* Will be converted into ERROR_INVALID_FUNCTION *

Re: [PATCH 1/3] [cmd] move issues when overwriting files

2012-09-06 Thread Alexandre Julliard
Ann and Jason Edmeades writes: > @@ -1709,8 +1709,13 @@ void WCMD_move (void) > WINE_TRACE("Source '%s'\n", wine_dbgstr_w(src)); > WINE_TRACE("Dest '%s'\n", wine_dbgstr_w(dest)); > > -/* If destination exists, prompt unless /Y supplied */ > -if (GetFileAttributesW(dest) != I

Re: [PATCH 6/6] msvcrt: Fixed RTTI structure on 64-bit systems

2012-09-06 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/msvcrt/cpp.c | 129 > ++-- > dlls/msvcrt/cxx.h | 114 +-- > 2 files changed, 155 insertions(+), 88 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q

Re: wined3d: Add AMD Radeon HD 7700 series and HD 7800 series graphics cards

2012-09-06 Thread Henri Verbeet
On 6 September 2012 15:27, Jiang Yike wrote: > This patch adds the recognition of AMD Radeon HD 7700 series and HD 7800 > series graphics cards. > This patch has whitespace errors.

Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests

2012-09-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21412 Your paranoid android

Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests

2012-09-06 Thread Jacek Caban
Hi, Here is proper run: https://testbot.winehq.org/JobDetails.pl?Key=21409 Jacek

Re: Wine, fullscreen applications, and RandR 1.2

2012-09-06 Thread Henri Verbeet
On 5 September 2012 22:45, Andy Ritger wrote: > On Wed, Sep 05, 2012 at 11:26:23AM -0700, Henri Verbeet wrote: >> From Wine's point of view, we'd just get a bunch of extra code to maintain >> because nvidia does things differently from everyone else. > > Eventually, I hope NVIDIA isn't unique abou