Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next (resend)

2012-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21408 Your paranoid android

Re: [2/3] vcomp: better stub for _vcomp_fork (resend)

2012-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21407 Your paranoid android

Re: [3/3] vcomp: better stubs for _vcomp_for_dynamic_init, _vcomp_for_dynamic_next

2012-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21405 Your paranoid android

Re: [2/3] vcomp: better stub for _vcomp_fork

2012-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21404 Your paranoid android

Re: Wine, fullscreen applications, and RandR 1.2

2012-09-05 Thread Andy Ritger
On Wed, Sep 05, 2012 at 11:26:23AM -0700, Henri Verbeet wrote: > On 5 September 2012 18:52, Andy Ritger wrote: > > At first glance, I agree that would be easier for applications, but that > > approach has some drawbacks: > > > > * lies to the user/application about what timings are actually being

Re: Wine, fullscreen applications, and RandR 1.2

2012-09-05 Thread Henri Verbeet
On 5 September 2012 18:52, Andy Ritger wrote: > At first glance, I agree that would be easier for applications, but that > approach has some drawbacks: > > * lies to the user/application about what timings are actually being > driven to the monitor > * the above bullet causes confusion: the timi

Re: Wine, fullscreen applications, and RandR 1.2

2012-09-05 Thread Andy Ritger
Thanks, Henri. On Wed, Sep 05, 2012 at 01:34:47AM -0700, Henri Verbeet wrote: > On 5 September 2012 08:07, Andy Ritger wrote: > > Questions: > > > > * Looking at dlls/winex11.drv/xrandr.c, the first RandR CRTC/output's > > modelist is used to populate Wine's list of available modes. Is the >

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate

2012-09-05 Thread Nozomi Kodama
Your mail makes me thing two or three remarks. I agree that in the plain wine, code must be optimized to use less memory as possible and to be the fastest as possible. But, the tests are here to check that the implemented function behaves like the windows one. So, they don't need to be optimized

Re: d3dx9_36 [try 3]: Implement D3DXSHRotate

2012-09-05 Thread Nozomi Kodama
I agree with Rico. It's hard to find issues in your own code, which makes it all the more important to check it thoroughly. Still, at least try to be careful with the code style: +static void RotateX(FLOAT *out, UINT order, FLOAT a, FLOAT *in) I think it's better to only use lower case for th

Re: [PATCH 3/3] hhctrl.ocx: Resize the window when HH_SET_WIN_TYPE is called (try 3, resend 2).

2012-09-05 Thread Alexandre Julliard
"Erich E. Hoover" writes: > @@ -266,7 +266,7 @@ void MergeChmProperties(HH_WINTYPEW *src, HHInfo *info) > if (merge & HHWIN_PARAM_PROPERTIES) dst->fsWinProperties = > src->fsWinProperties; > if (merge & HHWIN_PARAM_STYLES) dst->dwStyles = src->dwStyles; > if (merge & HHWIN_PARAM_E

Re: Building winetest-latest.exe?

2012-09-05 Thread Francois Gouget
On Tue, 4 Sep 2012, Dan Kegel wrote: > On Tue, Sep 4, 2012 at 3:18 PM, Francois Gouget > wrote: > >> (But as it turns out, the code I needed to fix was in buildbot, > >> not winetest.) > > > > Maybe the WineTestBot code needs a similar fix? > > In testbot/src/TestLauncher/TestLauncher.c? > > Ye

Re: Wine, fullscreen applications, and RandR 1.2

2012-09-05 Thread Henri Verbeet
On 5 September 2012 08:07, Andy Ritger wrote: > Questions: > > * Looking at dlls/winex11.drv/xrandr.c, the first RandR CRTC/output's > modelist is used to populate Wine's list of available modes. Is the > data flow between Wine and Windows applications always such that you > need to adverti

Re: d3dx9_36 [try 4 ]: Implement D3DXSHRotate

2012-09-05 Thread Rico Schüller
On 05.09.2012 08:02, Nozomi Kodama wrote: +out[15] = -0.9682458639f * in[13] + 0.25f * in[15]; ! You didn't find all trailing white spaces. I made a !, so it could be seen. You could easily get around that by changing your editors preference. Most editors are able to remove that automatic