Re: Building winetest-latest.exe?

2012-09-03 Thread Dan Kegel
On Mon, Sep 3, 2012 at 2:28 PM, Austin English wrote: > On Sun, Sep 2, 2012 at 9:52 PM, Vincent Povirk wrote: >> As I understand it, you need to set up a mingw build as in >> http://wiki.winehq.org/CompilingDLLsUsingMingw > > Sort of. You don't need a separate build tree for building the tests. >

Re: Building winetest-latest.exe?

2012-09-03 Thread Austin English
On Sun, Sep 2, 2012 at 9:52 PM, Vincent Povirk wrote: > As I understand it, you need to set up a mingw build as in > http://wiki.winehq.org/CompilingDLLsUsingMingw Sort of. You don't need a separate build tree for building the tests. Just have mingw32 installed, run ./configure, then 'make crosst

Re: wined3d: Use backup swapchain DC for devices created with desktop window. (try 2)

2012-09-03 Thread Adam Jakubek
On Mon, Sep 3, 2012 at 6:29 PM, Stefan Dösinger wrote: > I skimmed bug #18490, and I'm wondering about two things: Does the app > create > a D3DDEVTYPE_REF or D3DDEVTYPE_NULLREF device? Once the device is created, > what does it to with it? A +d3d log would provide some answers. > Ok, this needs

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-09-03 Thread Dan Kegel
On Sun, Sep 2, 2012 at 1:14 PM, Dan Kegel wrote: > On Wed, Aug 8, 2012 at 7:27 AM, Dan Kegel wrote: >> Testing vcomp100 does work, but I shouldn't need to >> do that until there's some vcomp100-specific code. >> >> msvcr90/tests just adds a manifest, and that works. > > Heh. It does add a manife

Re: wined3d: Use backup swapchain DC for devices created with desktop window. (try 2)

2012-09-03 Thread Stefan Dösinger
Am Montag, 3. September 2012, 04:06:01 schrieb Adam Jakubek: > Previous version failed on test bots. > Added test case skipping when no device can be created with normal > (non-desktop) window. I skimmed bug #18490, and I'm wondering about two things: Does the app create a D3DDEVTYPE_REF or D3DDEV

Re: [PATCH] msctf: also free the sink in the non-source branch (Coverity)

2012-09-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21357 Your paranoid android

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

2012-09-03 Thread Alexandre Julliard
Jacek Caban writes: > On 09/03/12 16:13, Alexandre Julliard wrote: >> Jacek Caban writes: >> >>> --- >>> dlls/mshtml/htmlwindow.c | 127 >>> ++ >>> 1 files changed, 72 insertions(+), 55 deletions(-) >> gcc -m32 -c -I. -I. -I../../include -I../../incl

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-09-03 Thread Alexandre Julliard
Alex Henrie writes: > 2012/9/3 Alexandre Julliard : >> You don't have a single test with an explicit source length, so >> obviously you are not going to find problems in that area. Like I said, >> you need a lot more tests. > > example_2 already tests an explicit source length. In all the other >

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-09-03 Thread Alex Henrie
2012/9/3 Alexandre Julliard : > You don't have a single test with an explicit source length, so > obviously you are not going to find problems in that area. Like I said, > you need a lot more tests. example_2 already tests an explicit source length. In all the other examples srclen = strlen(src) +

Re: wined3d: Use backup swapchain DC for devices created with desktop window.

2012-09-03 Thread Matteo Bruni
2012/9/3 Henri Verbeet : > On 3 September 2012 00:51, Adam Jakubek wrote: >> Hi, >> >> This patch causes wined3d to use backup swapchain DC when >> IDirect3DDevice9 is created using the desktop window. >> Windows allows to create such device as long its type is >> D3DDEVTYPE_REF or D3DDEVTYPE_NULL

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

2012-09-03 Thread Jacek Caban
On 09/03/12 16:13, Alexandre Julliard wrote: > Jacek Caban writes: > >> --- >> dlls/mshtml/htmlwindow.c | 127 >> ++ >> 1 files changed, 72 insertions(+), 55 deletions(-) > gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -DCOM_NO_

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

2012-09-03 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/mshtml/htmlwindow.c | 127 > ++ > 1 files changed, 72 insertions(+), 55 deletions(-) gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-al

Re: [PATCH 6/6] mshtml: Added IHTMLIFrameElement3 stub implementation

2012-09-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21355 Your paranoid android

Re: d3dx9_36: Implement D3DXSHRotate

2012-09-03 Thread Henri Verbeet
On 3 September 2012 12:02, Rico Schüller wrote: > +sinb = sqrt( 1.0f - matrix->u.m[2][2] * matrix->u.m[2][2] ); > > I'd prefer to declare the variables as locally as possible. > As an aside, you'll probably want to use floating point functions like sqrtf() instead of ones operating on doub

Re: d3dx9_36: Implement D3DXSHRotate

2012-09-03 Thread Rico Schüller
I had another look and like to give some suggestion. On 02.09.2012 22:28, Nozomi Kodama wrote: +sinb = sqrt( 1.0f - matrix->u.m[2][2] * matrix->u.m[2][2] ); I'd prefer to declare the variables as locally as possible. +D3DXSHRotateZ(temp5, order, alpha, temp4); +memcpy(out, temp

Re: Wine Gecko 1.8-beta1

2012-09-03 Thread Jacek Caban
On 09/02/12 20:52, Vincent Povirk wrote: >> On related note, I seriously consider dropping debug builds and replace >> them by unstripped release build or even just a separated package >> containing only debug symbols for the release build. > No one has complained about the debugging symbols in Win

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-09-03 Thread Alexandre Julliard
Alex Henrie writes: > I was asked to split this patch up, so I did. The complaint about the > last version was "You are still overflowing the source." I have not > been able to find any test case that my implementation handled > incorrectly, however, I did find that (*src == 0 && srclen < 0) will

Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)

2012-09-03 Thread Francois Gouget
On Sun, 2 Sep 2012, Vincent Povirk wrote: > >> Probably this should be a win_slip(). > > > > The function exists only since Windows 7/Vista (not XP) and is not yet > > in Wine (and might take a while, as my time is limited currently > > and my knowledge of this specific function same). > > > > So

Re: d3dx9_36: Implement D3DXSHRotate

2012-09-03 Thread Rico Schüller
On 02.09.2012 23:46, Nozomi Kodama wrote: For instance, D3DXSHAdd and D3DXSHDot accept order>D3DXSH_MAXORDER. So we must check whether it is acceptable for other D3DXSH functions to give such an order. If it is not acceptable, then we must know what the function returns. Yes, they do and I agre