Re: msxml3: Implement xmldecl-version property for a reader

2012-08-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21252 Your paranoid android

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.

2012-08-26 Thread Vincent Povirk
>> > +GdipFree(backup); >> >> I think you want GdipDeletePath. > > Other places of GdipAddPathString implementation need this fixed as well then. Nope, the existing use of GdipFree on backup is correct because the extra data associated with it has been copied to the original path (which ha

Re: kernel32: Handle neutral locale names better in GetLocaleInfoEx

2012-08-26 Thread Nikolay Sivov
On 8/27/2012 07:20, Dmitry Timoshkov wrote: Hi, Are you sure that GetLocaleInfo can't handle these cases on its own? I already added a test for that - for neutral LCID for English for example it still returns en-US as locale name and the rest of the locale entries I tested are from US locale a

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.

2012-08-26 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > +GdipFree(backup); > > I think you want GdipDeletePath. Other places of GdipAddPathString implementation need this fixed as well then. > This seems very convoluted. Couldn't we just skip the size conversion > in get_log_fontW when graphics is NULL? Any cases w

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.

2012-08-26 Thread Vincent Povirk
> +GdipFree(backup); I think you want GdipDeletePath. This seems very convoluted. Couldn't we just skip the size conversion in get_log_fontW when graphics is NULL? Any cases where the scaling would produce a size other than the em size need to be fixed in GdipAddPathString anyway.

Re: kernel32: Handle neutral locale names better in GetLocaleInfoEx

2012-08-26 Thread Dmitry Timoshkov
Hi, Are you sure that GetLocaleInfo can't handle these cases on its own? -- Dmitry.

Unused msvcp100 functions?

2012-08-26 Thread Francois Gouget
There are a lot of msvcp100 functions that look like they are unused: * In string.c all of the MSVCP__String_base_*(), MSVCP_basic_string_*(), MSVCP_basic_string_wchar_*() and MSVCP_char_traits_*() functions, basic_string_w?char_replace_helper(). * In locale.c _Locinfo__Locinfo_cto

Re: msvcr100: Add wmemmove_s and wmemcpy_s

2012-08-26 Thread Dan Kegel
On Sun, Aug 26, 2012 at 1:29 AM, Alexandre Julliard wrote: >> But msvcr100's wmemmove_s/wmemcpy_s are different; they >> do not change errno. Tests in my patch confirm this. > > They do set errno, the tests are broken. Aw, foo. Thanks, resent with fixes.

Re: About WineHQ Wiki

2012-08-26 Thread Kyle Auble
Sorry if my replies come in large batches, I'm subscribed to the mailing list digest. Sun, 26 Aug 2012 10:08, Cheer Xiao wrote: > Hi all, > I'm a MoinMoin contributor, one of MoinMoin's participating students > in this year's Summer of Code. > 2012/8/26 Kyle Auble : >> Sat, 25 Aug 2012 14:44, O

Re: po: Update German translation

2012-08-26 Thread Julian Rüger
I'm very sorry for sending another private mail to the list... When I chose "Answer to sender" my Mailclient asked if I wanted to send a private mail, but the sender is wine-devel. Damn. Am Sonntag, den 26.08.2012, 17:47 +0200 schrieb Julian Rüger: > Hi André, > > war ich zu langsam? ;) > > Da

Re: po: Update German translation

2012-08-26 Thread Julian Rüger
Hi André, war ich zu langsam? ;) Das Komma ist an der Stelle grammatikalisch falsch, glaube ich. "Die verbundenen Controller" sollten auch Plural bleiben. Mein Vorschlag wäre irgendwie so etwas: "Nach dem De-/Aktivieren eines Gerätes wird die Liste der verbundenen Controller bis zum Neustart die

Re: winhttp: disable TLSv1.1/1.2 by default

2012-08-26 Thread Marcus Meissner
On Sun, Aug 26, 2012 at 11:50:15AM +0900, Hiroshi Miura wrote: > > Windows 7 disables TLSv1.1/1.2 by default. > This patch intend to behave same as Windows. Please do not... The newer TLSv1.x fix some shortcomings of the older TLS versions. Is there a specific problem you see? Otherwis

Re: About WineHQ Wiki

2012-08-26 Thread Cheer Xiao
2012/8/26 André Hentschel : > Am 26.08.2012 07:16, schrieb Cheer Xiao: >> 2012/8/26 Cheer Xiao : >>> ... snip ... >>> Try out MoinMoin 2.0 at this minefield[5]. The last Summer of Code[6] >>> saw a few interesting enhancements like greatly improved themes, >>> support for blog and ticket system (di

Re: About WineHQ Wiki

2012-08-26 Thread André Hentschel
Am 26.08.2012 07:16, schrieb Cheer Xiao: > 2012/8/26 Cheer Xiao : >> ... snip ... >> Try out MoinMoin 2.0 at this minefield[5]. The last Summer of Code[6] >> saw a few interesting enhancements like greatly improved themes, >> support for blog and ticket system (disclaimer: ticket system is my >> pr

Re: msvcr100: Add wmemmove_s and wmemcpy_s

2012-08-26 Thread Alexandre Julliard
Dan Kegel writes: > I asked Alexandre what > http://source.winehq.org/patches/data/88732 > needed before it could be reviewed. He said it needed to adapt > to the recent parameter checking changes. I see that > when he took my patch > http://www.winehq.org/pipermail/wine-patches/attachments/201