Re: Have there been any problems with Wine on GCC 4.7?

2012-08-13 Thread Scott Ritchie
On 8/13/12 12:55 PM, Eric Pouech wrote: diff --git a/configure.ac b/configure.ac index 4bd43d1..c80fd8a 100644 --- a/configure.ac +++ b/configure.ac @@ -1746,6 +1746,8 @@ then WINE_TRY_CFLAGS([-Wtype-limits]) WINE_TRY_CFLAGS([-Wunused-but-set-parameter]) WINE_TRY_CFLAGS([-Wwrite-strings]) + WIN

Re: user32: search more aggressively for a window under a tooltip

2012-08-13 Thread Daniel Jelinski
2012/7/23 Alexandre Julliard : > Daniel Jelinski writes: > >> 2012/7/23, Alexandre Julliard : >>> You can't assume that the other Wine window is directly underneath the >>> transparent one, there may be some other X windows in between that >>> should receive the click instead. >> >> I just determi

Re: Have there been any problems with Wine on GCC 4.7?

2012-08-13 Thread Eric Pouech
diff --git a/configure.ac b/configure.ac index 4bd43d1..c80fd8a 100644 --- a/configure.ac +++ b/configure.ac @@ -1746,6 +1746,8 @@ then WINE_TRY_CFLAGS([-Wtype-limits]) WINE_TRY_CFLAGS([-Wunused-but-set-parameter]) WINE_TRY_CFLAGS([-Wwrite-strings]) + WINE_TRY_CFLAGS([-gdwarf-2]) +

Re: Have there been any problems with Wine on GCC 4.7?

2012-08-13 Thread Austin English
On Mon, Aug 13, 2012 at 2:29 PM, Eric Pouech wrote: > In the meantime, I suppose I could enable the -gdwarf-2 compiler option. > > > yes (but it's a bit more tricky than it sounds) > something like this will do > > A+ > > diff --git a/configure.ac b/configure.ac > index 4bd43d1..2624dc1 100644 > -

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

2012-08-13 Thread Eric Pouech
Le 13/08/2012 09:51, Dmitry Timoshkov a écrit : Eric Pouech wrote: It would look much better without all those 'ret' + 'else' things. well, wine doesn't have coding guidelines... so I don't know what "look much better" means (project wise) For this particalr patch it means: 1. less code 2.

Re: Have there been any problems with Wine on GCC 4.7?

2012-08-13 Thread Eric Pouech
In the meantime, I suppose I could enable the -gdwarf-2 compiler option. yes (but it's a bit more tricky than it sounds) something like this will do A+ diff --git a/configure.ac b/configure.ac index 4bd43d1..2624dc1 100644 --- a/configure.ac +++ b/configure.ac @@ -236,6 +236,12 @@ then AC

Re: [PATCH 2/4] wined3d: Fix pixel format alpha/red masks.

2012-08-13 Thread Henri Verbeet
On 13 August 2012 20:20, Matteo Bruni wrote: > + * Pixel formats with more than 4 bpp do not have correct masks, because the > + * high masks do not fit into the 32 bit values needed for ddraw. The masks > + * are only used for ddraw mostly, and to figure out if the format has an > alpha > + * co

Re: joy.cpl: Corrected misplaced elements when using high DPIs

2012-08-13 Thread Alexandre Julliard
Lucas Zawacki writes: > From: Lucas Zawacki > > Fixes bug #31316 > > joy.cpl uses CreateWindow and SetWindowPos to draw some elements > and the hardcoded coordinates where wrong when the dpi was set to anything > bigger than 96px in winecfg. My approach to solve is normalize the > coordinates ba

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

2012-08-13 Thread Dmitry Timoshkov
Eric Pouech wrote: > > It would look much better without all those 'ret' + 'else' things. > well, wine doesn't have coding guidelines... > so I don't know what "look much better" means (project wise) For this particalr patch it means: 1. less code 2. simpler code 3. more readable code and has

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

2012-08-13 Thread Eric Pouech
> It would look much better without all those 'ret' + 'else' things. well, wine doesn't have coding guidelines... so I don't know what "look much better" means (project wise) A+ -- Eric Pouech