_vcomp_fork stack frame puzzle

2012-08-08 Thread Dan Kegel
Having fun trying to figure out what's in the black box of _vcomp_fork(), the helper function that spawns threads in Visual C's OpenMP support library. The C source code #include #include int main(int argc, char **argv) { double d; double e; int i; printf("&d is %p, &e is %p\n",

Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.

2012-08-08 Thread Dmitry Timoshkov
Vincent Povirk wrote: > Yes, but gdip_format_string still uses the HDC to do measurements for > the layout calculation. (And draw_string_callback uses it to decide > where to draw underlines.) You are right, this patch can be dropped then, #16 and #17 don't depend on this one. -- Dmitry.

Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.

2012-08-08 Thread Vincent Povirk
Yes, but gdip_format_string still uses the HDC to do measurements for the layout calculation. (And draw_string_callback uses it to decide where to draw underlines.) On Wed, Aug 8, 2012 at 11:53 PM, Dmitry Timoshkov wrote: > Vincent Povirk wrote: > >> This will break text rendering. We need the c

Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.

2012-08-08 Thread Dmitry Timoshkov
Vincent Povirk wrote: > This will break text rendering. We need the correct font to be > selected on the hdc during the call to gdip_format_string. GdipDrawDriverString creates and selects the font on the DC. -- Dmitry.

Re: [15/17] gdiplus: Delete GDI objects once they are not needed anymore.

2012-08-08 Thread Vincent Povirk
This will break text rendering. We need the correct font to be selected on the hdc during the call to gdip_format_string.

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-08 Thread Dan Kegel
Andre wrote: > i'd something like in my attachment Sorry, I should have linked to http://testbot.winehq.org/JobDetails.pl?Key=20684 where I verified that testing vcomp100 did indeed work around the problem. I guess that's where I'll put the tests until somebody hits me with a cluestick.

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-08 Thread André Hentschel
Am 08.08.2012 16:27, schrieb Dan Kegel: > Testing vcomp100 does work, but I shouldn't need to > do that until there's some vcomp100-specific code. > > msvcr90/tests just adds a manifest, and that works. > > not sure why this works for msvcr90, maybe just for a minor version? anyway, always vcom

Re: [1/4] gdiplus: Add a test for GdipDrawImage scaling.

2012-08-08 Thread Vincent Povirk
This series looks good to me.

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-08 Thread Dan Kegel
Testing vcomp100 does work, but I shouldn't need to do that until there's some vcomp100-specific code. msvcr90/tests just adds a manifest, and that works.

Re: __wine_uuidof causing a wall of "warning: returning reference to temporary" on g++

2012-08-08 Thread Ilya Konstantinov
Hi Jacek, I just realized what was the difference in my case. I was including the system headers manually with -I/usr/include/wine/windows as opposed to -isystem/usr/include/wine/windows (as winegcc/wineg++ does it). gcc suppresses warnings in system headers (when using -isystem): http://gcc.gnu.