Re: mpr/tests: Сheck the return values of the WNetGetUniversalNameA.

2012-07-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20174 Your paranoid android

Re: fusion: Don't assume a specific compiler behaviour

2012-07-19 Thread Ruslan Kabatsayev
Hello, > Most likely it's rotated on x86 and hardly shifted on ARM, damn compilers. No, it's not compilers, it's intel's "shr" instruction behavior: it masks bit count lower 5 bits, thus making 33 effectively 1. Corresponding ARM instruction most likely does true 33 bit shift giving you zero resul

Re: start: Support getting the file to open by AppleEvent.

2012-07-19 Thread Per Johansson
19 jul 2012 kl. 18:11 skrev Alexandre Julliard : > Per Johansson writes: > >> Uses a private API. > > You really don't want to do that. Alright, but like I said earlier there's really no other good way to support associations without using Objective-C. I'll send a new version without associ

Re: mshtml: Set outgoing pass-by-address variable in an error case case within confirm_safety_load.

2012-07-19 Thread Gerald Pfeifer
On Thu, 8 Mar 2012, Gerald Pfeifer wrote: >>> I noticed we return in this case, without initializing this variable. >>> Visual inspection indicates we do not seem to access the variable in >>> this error case, but a) better safe than sorry, and b) GCC 4.8 currently >>> warns about it. >> I generall

Re: fusion: Don't assume a specific compiler behaviour

2012-07-19 Thread André Hentschel
Am 19.07.2012 22:06, schrieb Ruslan Kabatsayev: > Hello, > >> Most likely it's rotated on x86 and hardly shifted on ARM, damn compilers. > No, it's not compilers, it's intel's "shr" instruction behavior: it > masks bit count lower 5 bits, thus making 33 effectively 1. > Corresponding ARM instructi

Re: wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.

2012-07-19 Thread Austin English
On Thu, Jul 19, 2012 at 7:23 AM, Alex Henrie wrote: > 2012/7/19 Austin English : >> Why didn't you include the tests in the patch? > > The "tests" I wrote always fail in order to output the result of the > function to the console for comparison by hand. ICU_ESCAPE is clearly > not meant to be used

Re: [1/2]usp10: cache OUTLINETEXTMETRICW instead of just TEXTMETRICW

2012-07-19 Thread Dmitry Timoshkov
Aric Stewart wrote: > +sc->tm = heap_alloc(size); > +GetOutlineTextMetricsW(hdc, size, sc->tm); otmSize exists for a reason, if GetOutlineTextMetrics currently doesn't check it this doesn't mean it won't at some point in future. -- Dmitry.

Re: start: Support getting the file to open by AppleEvent.

2012-07-19 Thread Alexandre Julliard
Per Johansson writes: > Series goal: Implement app bundle start menu / file type associations on OS X. > > > From 681ea02fb9e3df819f812e359d3fe76c77423e32 Mon Sep 17 00:00:00 2001 > From: Per Johansson > Date: Tue, 17 Apr 2012 21:29:13 +0200 > Subject: start: Support getting the file to open by

Re: wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.

2012-07-19 Thread Alex Henrie
2012/7/19 Austin English : > Why didn't you include the tests in the patch? The "tests" I wrote always fail in order to output the result of the function to the console for comparison by hand. ICU_ESCAPE is clearly not meant to be used with InternetCanonicalizeUrl, so I'm not sure a test for it is

Re: [PATCH 4/4] ieframe: Avoid useless QI(IID_IWebBrowser2) calls in tests by passing IWebBrowser2 interface where possible

2012-07-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20160 Your paranoid android

Re: include/winhttp.h: Make strings in WINHTTP_PROXY_INFO non-const

2012-07-19 Thread Hans Leidekker
On Thu, 2012-07-19 at 07:27 +, Heiko Hund wrote: > The strings shouldn't be const according to the docs at [1] and > declaring them as LPWSTR removes some false warnings when > compiling code GlobalFree()ing them with mingw. Please also remove unnecessary casts from Wine.