Re: Dmitry Timoshkov : gdiplus: GdipMeasureString operates internally in pixels but in/ out rectangles are in device units.

2012-07-18 Thread Vincent Povirk
OK, this is starting to make sense to me. If I'm understanding this, the point of your series is that the font has a consistent size based on the unit stored in the font. If it's a physical unit like inches then the font's size in world coordinates changes based on the graphics page unit, so that i

Re: wininet: Support ICU_ENCODE_PERCENT, ICU_ENCODE_SPACES_ONLY, and ICU_NO_META.

2012-07-18 Thread Austin English
On Wed, Jul 18, 2012 at 6:33 PM, Alex Henrie wrote: > Without this patch, Internet Explorer 6 produces a lot of messages like > "fixme:wininet:InternetCanonicalizeUrlW Unhandled flags 0x0400" > > Wine's wininet.h was missing ICU_ENCODE_PERCENT, which is present in > the wininet.h from the Wind

Re: Dmitry Timoshkov : gdiplus: GdipMeasureString operates internally in pixels but in/ out rectangles are in device units.

2012-07-18 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I still don't understand this patch. > > Your subject implies that device units and pixels are not the same > thing, but my understanding is that except for metafile HDCs (which we > don't handle correctly anyway, and I suspect native doesn't either), > they are. Device

Re: [PATCH 01/10] dsound/tests: Add IDirectSound refcount and COM aggregation tests.

2012-07-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20152 Your paranoid android

Re: Dmitry Timoshkov : gdiplus: GdipMeasureString operates internally in pixels but in/ out rectangles are in device units.

2012-07-18 Thread Vincent Povirk
> gdiplus: GdipMeasureString operates internally in pixels but in/out > rectangles are in device units. I still don't understand this patch. Your subject implies that device units and pixels are not the same thing, but my understanding is that except for metafile HDCs (which we don't handle corr

Re: ole32: Forward BSTR functions to oleaut32

2012-07-18 Thread Jacek Caban
On 07/18/12 15:00, Alexandre Julliard wrote: > Jacek Caban writes: > >> @@ -1244,6 +1244,9 @@ static void COMPOBJ_InitProcess( void ) >> static void COMPOBJ_UninitProcess( void ) >> { >> UnregisterClassW(wszAptWinClass, hProxyDll); >> + >> +if(oleaut32_instance) >> +FreeLibrary(

Re: ole32: Forward BSTR functions to oleaut32

2012-07-18 Thread Alexandre Julliard
Jacek Caban writes: > @@ -1244,6 +1244,9 @@ static void COMPOBJ_InitProcess( void ) > static void COMPOBJ_UninitProcess( void ) > { > UnregisterClassW(wszAptWinClass, hProxyDll); > + > +if(oleaut32_instance) > +FreeLibrary(oleaut32_instance); Since oleaut32 imports ole32 you'l

Re: mshtml: Set outgoing pass-by-address variable in an error case case within confirm_safety_load.

2012-07-18 Thread Jacek Caban
On 07/17/12 22:51, Gerald Pfeifer wrote: > On Thu, 8 Mar 2012, Gerald Pfeifer wrote: I noticed we return in this case, without initializing this variable. Visual inspection indicates we do not seem to access the variable in this error case, but a) better safe than sorry, and b) GCC 4

Re: d3dx9_36: Implementation of D3DXSHRotateZ

2012-07-18 Thread Matteo Bruni
2012/7/18 Nozomi Kodama : > Minor nitpicks, but nevertheless: > -@ stub D3DXSHRotateZ(ptr long long ptr) > +@ stdcall D3DXSHRotateZ(ptr long long ptr) ... > +FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT > *in) I guess using "float" in the spec file for the third

Re: [PATCH 2/2] vbscript: Added LCase implementation

2012-07-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20130 Your paranoid android