RE: msvcp90: handle npos as a len in basic_string<>::replace

2012-07-16 Thread Daniel Lehman
> -Original Message- > From: daniel.r.ke...@gmail.com [mailto:daniel.r.ke...@gmail.com] On > Behalf Of Dan Kegel > Sent: Monday, July 16, 2012 12:27 PM > To: Daniel Lehman > Cc: wine-devel@winehq.org > Subject: re: msvcp90: handle npos as a len in basic_string<>::replace > > Daniel Lehman

re: msvcp90: handle npos as a len in basic_string<>::replace

2012-07-16 Thread Dan Kegel
Daniel Lehman wrote: @@ -1949,7 +1949,7 @@ basic_string_char* __thiscall basic_string_char_replace_cstr_len(basic_string_ch -if(off+len > this->size) +if(off+len < off || off+len > this->size) len = this->size-off; Wouldn't this be more elegant: if(num > this->size-pos)

Re: Build failure of "[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test (try 4)" ?

2012-07-16 Thread GOUJON Alexandre
On 07/16/2012 06:12 PM, Alexandre Julliard wrote: There's nothing mystic about it, but when you are changing the Mac code, testing the build on a Mac is recommended ;-) gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-ali

Re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-16 Thread GOUJON Alexandre
On 07/16/2012 09:44 AM, Eduard Hasenleithner wrote: [...] Maybe I should have mentioned it, but I'm using Ubuntu 12.04 and the SD card is mounted automatically as soon as I put it into the slot. My current hypothesis why the symlink in dosdevices is missing is that the partition is added using

Re: msi/tests: Mark some test results as broken.

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20071 Your paranoid android

Re: kernel32: Also report empty drives as available in GetLogicalDrives

2012-07-16 Thread Alexandre Julliard
Alexandre Goujon writes: > --- > dlls/kernel32/volume.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 8377e41..67e2eb1 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -14

Re: [PATCH 3/9] hhctrl.ocx: Centralize merging HH_WINTYPE data (resend).

2012-07-16 Thread Alexandre Julliard
"Erich E. Hoover" writes: > @@ -28,6 +28,13 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(htmlhelp); > > +#define HHWIN_PARAM_MASK > (HHWIN_PARAM_PROPERTIES|HHWIN_PARAM_STYLES|HHWIN_PARAM_EXSTYLES|HHWIN_PARAM_RECT\ > + > |HHWIN_PARAM_NAV_WIDTH|HHWIN_PARAM_SHOWSTATE|HHW

Re: Build failure of "[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test (try 4)" ?

2012-07-16 Thread Alexandre Julliard
GOUJON Alexandre writes: > Hi, > > My patch (http://source.winehq.org/patches/data/88072) is marked as > "Build failure". > I tried with the latest (today) HEAD and I successfully applied it. > Compilation also works for me at least on my x86 and x86_64 computers. > Moreover, the Wine Test Bot te

Re: [PATCH 6/6] jscript: Don't set constructor property to each object instance, it belongs to their prototypes

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20070 Your paranoid android

Re: [PATCH 2/6] jscript: Properly handle constructor property for most builtin constructors

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20066 Your paranoid android

Re: [PATCH 3/6] jscript: Properly set Function constructor's constructor property

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20067 Your paranoid android

Re: [PATCH 4/6] jscript: Properly set Error object's constructor property

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20068 Your paranoid android

Re: [PATCH 5/6] jscript: Expose RegExpError constructor in global object

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20069 Your paranoid android

Re: [PATCH 1/6] jscript: Properly set Number.prototyp.constructor

2012-07-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=20065 Your paranoid android

Re: mshtml: Always set the URL policy in the error cases?

2012-07-16 Thread Francois Gouget
On Tue, 3 Jul 2012, Jacek Caban wrote: [...] > It would probably be more appropriate to add > assert(SUCCEEDED(hres)); after IsClassOfCategories calls, which can't fail. Ok. Would something like this be ok? It seems like this single assert() is enough to make gcc happy here. commit 2c47407d6e11

Re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-16 Thread Eduard Hasenleithner
On 2012-07-16 09:39, Marcus Meissner wrote: On Mon, Jul 16, 2012 at 07:12:59AM +0200, Eduard Hasenleithner wrote: Am 2012-07-15 22:04, schrieb GOUJON Alexandre: Does http://source.winehq.org/patches/data/88280 solve your GetLogicalDrives issue ? Well yes, with the patch all the drive letters

Re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-16 Thread Marcus Meissner
On Mon, Jul 16, 2012 at 07:12:59AM +0200, Eduard Hasenleithner wrote: > Am 2012-07-15 22:04, schrieb GOUJON Alexandre: > >On 07/14/2012 09:14 PM, Eduard Hasenleithner wrote: > >>[...] > >>This means that the drive letter assigned for the sd card will not be > >>returned in GetLogicalDrives(). When