Re: Comdlg32: Select initial text in edit control (try 2)

2012-07-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19988 Your paranoid android

Re: Comdlg32: Select initial text in edit control (try 2)

2012-07-12 Thread Dmitry Timoshkov
Suresh Murty wrote: > Sends a EM_SETSEL message after the initial text has been set. This is wrong place for both a test and a fix. The text should be selected on focus by a dialog control itself. -- Dmitry.

Re: [1/2] gdiplus: Make sure that 1bpp bitmap images get loaded in native format.

2012-07-12 Thread Dmitry Timoshkov
Vincent Povirk wrote: > Uh, this is going to cause regressions if you don't give the image a palette. I'd like to avoid adding pixel format conversions (and new palettes) in gdiplus, instead once this patch is committed I'm planning to make gdiplus use WIC format converters, then missing and wid

Re: [1/2] gdiplus: Make sure that 1bpp bitmap images get loaded in native format.

2012-07-12 Thread Vincent Povirk
Uh, this is going to cause regressions if you don't give the image a palette.

Re: Wine automated testing update

2012-07-12 Thread Francois Gouget
I have pushed my libvirt development branch to GitHub so you can see what's brewing: https://github.com/fgouget/winetestbot/commits/libvirt or git://github.com/fgouget/winetestbot.git Note that I still rebase the libvirt branch regularly as I realize my mistakes or want to reorganize th

Re: joy.cpl: Correct joystick testing thread behavior

2012-07-12 Thread Alexandre Julliard
Lucas Zawacki writes: > @@ -419,14 +421,19 @@ static INT_PTR CALLBACK test_dlgproc(HWND hwnd, UINT > msg, WPARAM wparam, LPARAM > SendDlgItemMessageW(hwnd, IDC_TESTSELECTCOMBO, > CB_SETCURSEL, 0, 0); > test_handle_joychange(hwnd, data); > > -

Re: [2/2] scrrun: Added IDispatch support for IFileSystem3

2012-07-12 Thread Alistair Leslie-Hughes
On 13/07/2012 7:38 AM, Nikolay Sivov wrote: On 7/12/2012 23:35, Alistair Leslie-Hughes wrote: On 12/07/2012 5:02 PM, Nikolay Sivov wrote: For http://bugs.winehq.org/show_bug.cgi?id=9638 and similar cases I have already submitted a patch for this http://source.winehq.org/patches/data/87925 I

Re: [2/2] scrrun: Added IDispatch support for IFileSystem3

2012-07-12 Thread Nikolay Sivov
On 7/12/2012 23:35, Alistair Leslie-Hughes wrote: On 12/07/2012 5:02 PM, Nikolay Sivov wrote: For http://bugs.winehq.org/show_bug.cgi?id=9638 and similar cases I have already submitted a patch for this http://source.winehq.org/patches/data/87925 I see, and what happened then? P.S. I didn't s

Re: [2/2] scrrun: Added IDispatch support for IFileSystem3

2012-07-12 Thread Alistair Leslie-Hughes
On 12/07/2012 5:02 PM, Nikolay Sivov wrote: For http://bugs.winehq.org/show_bug.cgi?id=9638 and similar cases I have already submitted a patch for this http://source.winehq.org/patches/data/87925 Best Regards Alistair Leslie-Hughes

Re: [PATCH 4/5] winex11: Release memory on xrandr cleanup.

2012-07-12 Thread Henri Verbeet
On 12 July 2012 18:46, Alexandre Julliard wrote: > It's not worth adding complexity to free memory, in practice the > graphics driver is never going to be unloaded except at process exit. > I suppose, although I think in principle we'd also want to clean things up when e.g. switching to virtual de

Re: [PATCH 4/5] winex11: Release memory on xrandr cleanup.

2012-07-12 Thread Alexandre Julliard
Henri Verbeet writes: > diff --git a/dlls/winex11.drv/xrandr.c b/dlls/winex11.drv/xrandr.c > index 83137a4..a8dccd4 100644 > --- a/dlls/winex11.drv/xrandr.c > +++ b/dlls/winex11.drv/xrandr.c > @@ -289,6 +289,12 @@ done: > wine_tsx11_unlock(); > } > > +void X11DRV_XRandR_Cleanup(void) > +{

Re: [2/2] windowscodecs: Add a test for palette associated with black&white TIFF image.

2012-07-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19971 Your paranoid android

Re: msi: fix incorrect decoding of msi stream-names

2012-07-12 Thread Hans Leidekker
On Wed, 2012-07-11 at 15:03 +, Oleg Jakobsen wrote: > @@ -203,6 +203,7 @@ BOOL decode_streamname(LPCWSTR in, LPWSTR out) > *out++ = mime2utf(ch&0x3f); > count++; > ch = mime2utf((ch>>6)&0x3f); > + continue; >