user32: Add test for ComboBox repositioning behavior (try 2).

2012-07-02 Thread Sergey Guralnik
Alexandre Julliard writes: @@ -5807,6 +5814,13 @@ static void test_combobox_messages(void) log_all_parent_messages--; ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); +SetWindowLongPtr(combo, GWLP_WNDPROC, (LONG_PTR)combobox_hook_proc_2); +SendMes

Wine on the front page of Reddit

2012-07-02 Thread Caleb Hearon
Hi all, In a conversation between myself (MaggotBrain on the forums) and Jarrex, I expressed some frustration that Blizzard had been banning Diablo III users who used Wine. He posted some of the excerpts I sent him from WineHQ, and it quickly got to 17 pages on Blizzard's forums. http://us.

Fwd: [GSoC Mentors] [Announce] 2012 GSoC Mentor Midterm Evaluations 9 July - 13 July

2012-07-02 Thread Austin English
A friendly reminder for GSOC people. If you won't be able to submit your evaluation during the specified timeline, or have any other questions, please contact me privately. Cheers, Austin -- Forwarded message -- From: Carol Smith Date: Fri, Jun 29, 2012 at 11:41 AM Subject: [GSoC

[1/2] comctl32: Fix message sequence when right-clicking a treeview

2012-07-02 Thread Daniel Jelinski
Resend from last month From e9d9c543589ea2120ac39962d9820699b220a576 Mon Sep 17 00:00:00 2001 From: Daniel Jelinski Date: Thu, 19 Apr 2012 22:02:25 +0200 Subject: comctl32: Fix message sequence when right-clicking a treeview The message sequence obtained from testing native comctl32 was: - first

Re: msvcp90: Fix __cdecl functions definitions that returns structures

2012-07-02 Thread Alexandre Julliard
Piotr Caban writes: > I'm not sure how to write tests for these functions. I see two > possibilities in case of functions returning "big" structures > (e.g. _Getctype). Should I write a test that calls the function in a > loop to make sure the tests are crashing if it corrupts the stack? Or > may

Re: Integer overflow problem in string::compare()

2012-07-02 Thread Dan Kegel
On Mon, Jul 2, 2012 at 2:51 AM, Piotr Caban wrote: > This patch looks correct. It's also good to fix other functions with similar > bug. Great, I'll have a bigger patchset for review in a few days. Thanks, Dan

Re: msvcp90: Fix __cdecl functions definitions that returns structures

2012-07-02 Thread Piotr Caban
On 06/29/12 19:33, Alexandre Julliard wrote: Piotr Caban writes: In code produced by gcc callee removes hidden return argument. In code produced by MS Visual Studio caller is responsible for removing the hidden argument. That's only for structures larger than 8 bytes, which isn't the case at

Re: [PATCH] wined3d: Add a switch to preserve vertex buffer copy in system memory.

2012-07-02 Thread Stefan Dösinger
Am 01.07.2012 12:43 schrieb "Henri Verbeet" > In general we don't do hacks like this. The VBOs in question might be managed pool buffers, which would make keeping the sysmem around less hacky. The unforunate issue is that other games(namely Source Engine games, probably others too) allocate hundre

Re: user32: Add test for ComboBox repositioning behavior (try 2).

2012-07-02 Thread Alexandre Julliard
Sergey Guralnik writes: > @@ -5807,6 +5814,13 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", > FALSE); > > +SetWindowLongPtr(combo, GWLP_WNDPROC, (LONG_PTR)combobox_hook_proc_2); > +

Re: Integer overflow problem in string::compare()

2012-07-02 Thread Piotr Caban
Hi, On 07/02/12 04:13, Dan Kegel wrote: could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ? If you like it, I'll submit it to wine-patches. It passes winetestbot and gets pulsen and stepmania past the splash screen abort. This patch looks correct. It's also good to fix