Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.

2012-06-28 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I think it's most likely not keeping the input stream in the new image at all. > > It's probably also worth testing SelectActiveFrame, GetPropertyItem, > and GetImageRawFormat with clones of images. Maybe they don't work. A quick test shows that SelectActiveFrame called

Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.

2012-06-28 Thread Vincent Povirk
I think it's most likely not keeping the input stream in the new image at all. It's probably also worth testing SelectActiveFrame, GetPropertyItem, and GetImageRawFormat with clones of images. Maybe they don't work.

Re: include: fix mingw64 build

2012-06-28 Thread Nicolas Le Cam
2012/6/29 Austin English : > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam wrote: >> 2012/6/29 Austin English : >>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>> >>> -- >>> -Austin >>> >>> >>> >> Hi Austin, >> >> I already tried to fix it on Wine side, see [1], >> but Alexandre told me

Re: include: fix mingw64 build

2012-06-28 Thread Austin English
On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam wrote: > 2012/6/29 Austin English : >> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >> >> -- >> -Austin >> >> >> > Hi Austin, > > I already tried to fix it on Wine side, see [1], > but Alexandre told me on IRC that the bug needs to be fixed in

Re: include: fix mingw64 build

2012-06-28 Thread Nicolas Le Cam
2012/6/29 Austin English : > Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 > > -- > -Austin > > > Hi Austin, I already tried to fix it on Wine side, see [1], but Alexandre told me on IRC that the bug needs to be fixed in mingw-w64, as it shouldn't include crtdefs.h by default. BTW, won't tha

Re: wbemprox: Add a Win32_LogicalDisk class stub.

2012-06-28 Thread Hans Leidekker
On Thu, 2012-06-28 at 22:22 +0300, John Yani wrote: > On 28 June 2012 22:17, Hans Leidekker wrote: > > On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > > That's better. Does NFS actually query the Caption and Description > > properties? > > > > > Well, no. I just thought the output should be

Re: wbemprox: Add a Win32_LogicalDisk class stub.

2012-06-28 Thread Hans Leidekker
On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > +static const WCHAR caption[] = > +{'C',':',0}; > +static const WCHAR description[] = > +{'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; > +

Re: user32: Add a test for ComboBox WM_WINDOWPOSCHANGED handling.

2012-06-28 Thread Alexandre Julliard
Sergey Guralnik writes: > @@ -5807,6 +5830,25 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", > FALSE); > > +wp.hwnd = combo; > +wp.hwndInsertAfter = HWND_TOP; > +wp.cx = wp.cy =

Re: [2/2] gdiplus: Increase refcount of the source stream when loading a bitmap instead of cloning it.

2012-06-28 Thread Vincent Povirk
This looks good to me. (I didn't think it was necessary to comment, but this is an important fix and I was surprised it was still New.)

Re: Unused msvcp60 functions

2012-06-28 Thread Piotr Caban
On 06/28/12 16:33, Francois Gouget wrote: Actually there are some implementation differences between msvcp60's and msvcp90's misc.c code. In particular for the init_lockit(), free_lockit() and various _Lockit_ctor_*() functions. Are the two implementations supposed to be identical? I forgot that

Re: Unused msvcp60 functions

2012-06-28 Thread Francois Gouget
On Thu, 28 Jun 2012, Piotr Caban wrote: [...] > The function were not removed to make msvcp60 and msvcp90 more similar > (and probably because I didn't use -Wunused-function option). Thanks to > it one can copy misc.c file between the dlls when it's modified. Actually there are some implementati

Re: windowscodecs: Make sure that stream is not reused once the decoder is initialized.

2012-06-28 Thread Vincent Povirk
Looks good to me.

mshtml: Always set the URL policy in the error cases?

2012-06-28 Thread Francois Gouget
gcc 4.7 is complaining that policy may be used uninitialized in InternetHostSecurityManager_QueryCustomPolicy() and indeed there are many error cases in confirm_safety_load() and confirm_safety() where the policy is not set. The patch belowe seems to plug all these holes but I don't know if it

Re: kernel32/tests: Remove an unused variable in the sync tests.

2012-06-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19638 Your paranoid android

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
On 06/28/2012 01:50 PM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >>> truncating from double to float while gcc keeps silence for instance. >> I never looked at that but I assume the same holds true as above. > > The following thread has some interesting details: > http://www.daniweb.

Re: [4/5] d3dx9: Implement D3DXCreateVolumeTextureFromFileInMemoryEx.

2012-06-28 Thread Matteo Bruni
2012/6/27 Józef Kucia : > --- > +    for (mip_level = 0; mip_level < mip_levels; mip_level++) > +    { > +        hr = calculate_dds_surface_size(src_info, width, height, &src_pitch, > &mip_level_size); > +        if (FAILED(hr)) return hr; ... > +        hr = D3DXLoadVolumeFromMemory(volume, pal

Re: [1/5] d3dx9: Implement D3DXLoadVolumeFromMemory.

2012-06-28 Thread Matteo Bruni
2012/6/27 Józef Kucia : > --- Hi Józef, > +void copy_simple_data(const BYTE *src, UINT srcpitch, SIZE src_size, const > PixelFormatDesc *srcformat, > +BYTE *dest, UINT destpitch, SIZE dst_size, const PixelFormatDesc > *destformat, D3DCOLOR colorkey) DECLSPEC_HIDDEN; > + You are not act

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Dmitry Timoshkov
Michael Stefaniuc wrote: > > truncating from double to float while gcc keeps silence for instance. > I never looked at that but I assume the same holds true as above. The following thread has some interesting details: http://www.daniweb.com/software-development/c/threads/114052/warning-c4305-tru

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
On 06/28/2012 01:00 PM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >> afair the fix is to disable the int truncation warnings in MSVC. For >> whatever reason they seem to enable those bogus warnings. > > The warnings are not bogus, the PSDK compiler also emits a warning when They are b

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Dmitry Timoshkov
Michael Stefaniuc wrote: > afair the fix is to disable the int truncation warnings in MSVC. For > whatever reason they seem to enable those bogus warnings. The warnings are not bogus, the PSDK compiler also emits a warning when truncating from double to float while gcc keeps silence for instance

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
Dmitry, afair the fix is to disable the int truncation warnings in MSVC. For whatever reason they seem to enable those bogus warnings. bye michael On 06/28/2012 12:12 PM, Dmitry Timoshkov wrote: > --- > include/basetsd.h | 16 > 1 file changed, 8 insertions(+), 8 deleti

Re: [2/2] msvcp90: Sync spec files

2012-06-28 Thread Owen Rudge
On 28/06/2012 11:33, Owen Rudge wrote: --- dlls/msvcp60/msvcp60.spec | 638 ++-- Sorry, I ran the make_specfiles script without realising that msvcp60.spec shouldn't have been updated. I've resent the patch without these changes. -- Owen Rudge http:

Re: [2/2] msvcp90: Sync spec files

2012-06-28 Thread Piotr Caban
First patch looks correct. On 06/28/12 12:33, Owen Rudge wrote: dlls/msvcp60/msvcp60.spec | 638 ++-- You can't update msvcp60.spec file this way (most of functions there should not be forwarded to msvcp90).

Re: Unused msvcp60 functions

2012-06-28 Thread Piotr Caban
On 06/28/12 09:30, Francois Gouget wrote: I get the following warnings when compiling msvcp60: main.c:108:51: warning: ‘std_BADOFF_func’ defined but not used [-Wunused-function] misc.c:66:40: warning: ‘mutex_mutex_lock’ defined but not used [-Wunused-function] misc.c:73:40: warning: ‘mutex_mut

Unused msvcp60 functions

2012-06-28 Thread Francois Gouget
I get the following warnings when compiling msvcp60: main.c:108:51: warning: ‘std_BADOFF_func’ defined but not used [-Wunused-function] misc.c:66:40: warning: ‘mutex_mutex_lock’ defined but not used [-Wunused-function] misc.c:73:40: warning: ‘mutex_mutex_unlock’ defined but not used [-Wunused-