Re: d3dx9_36 [patch 3 of 4, try 2]: Implemetation of D3DXSHMultiply2

2012-06-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19429 Your paranoid android

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHScale

2012-06-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19428 Your paranoid android

Re: d3dx9_36 [patch 1 of 4, try 2]: Implemetation of D3DXSHDot

2012-06-21 Thread Dmitry Timoshkov
Hello, Please follow http://wiki.winehq.org/SubmittingPatches instructions for naming patches when sending a patch series. Usually 'git format-patch -n' will do it for you. Otherwise testbot won't recognize the series. -- Dmitry.

Re: wintrust/tests: Fix build with MSVC.

2012-06-21 Thread David Laight
On Thu, Jun 21, 2012 at 12:56:43PM +0200, Thomas Faber wrote: > On 2012-06-21 12:34, Dmitry Timoshkov wrote: > > > Thomas Faber wrote: > > > >> FIELD_OFFSET isn't constant "enough". > > > > The problem is not with FIELD_OFFSET, but with applying shift and mask > > operations to a constant. > >

re: [PATCH 2/5] ddraw: Use wined3d_get_adapter_display_mode() in CreateSurface().

2012-06-21 Thread Dan Kegel
Henri wrote: -hr = wined3d_device_get_display_mode(ddraw->wined3d_device, 0, &mode); -if (FAILED(hr)) +if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) Seems like a step back in readability to combine setting and testing hr. - Dan

Re: Wine automated testing update

2012-06-21 Thread André Hentschel
Am 21.06.2012 16:21, schrieb Francois Gouget: > On Wed, 1 Feb 2012, Jeremy White wrote: > [...] >> However, Alexandre has persuaded me that we should first explore >> integrating the dotest.sh functionality into the existing WineTestBot, >> as that would allow us to have a very simple clean web pag

Re: Examples of AJ silently improving patches?

2012-06-21 Thread Stefan Dösinger
Hi, Here's another one where AJ implemented a suggestion I sent 3 days later: http://source.winehq.org/git/wine.git/commitdiff/5523820b810d16fd17da86fcf7930fd3f27acdf4 http://www.winehq.org/pipermail/wine-patches/2012-June/115180.html Am Mittwoch, 20. Juni 2012, 17:52:31 schrieb Daniel Lehman: >

Re: [PATCH 1/7] ntdll: Add support for junction point creation.

2012-06-21 Thread Hans Leidekker
On Thu, 2012-06-21 at 09:57 -0600, Erich E. Hoover wrote: > On Thu, Jun 21, 2012 at 4:28 AM, Hans Leidekker wrote: > > ... > > > > This is not an atomic operation since you need two Unix calls. So you would > > need locking or rollback to deal with possible races. > > It is my understanding that

Re: [PATCH 1/7] ntdll: Add support for junction point creation.

2012-06-21 Thread Erich E. Hoover
On Thu, Jun 21, 2012 at 4:28 AM, Hans Leidekker wrote: > ... > > This is not an atomic operation since you need two Unix calls. So you would > need locking or rollback to deal with possible races. It is my understanding that directories only support advisory locks, are you aware of a way to lock

Re: Wine automated testing update

2012-06-21 Thread Michael Stefaniuc
Francois, On 06/21/2012 04:21 PM, Francois Gouget wrote: > --- Network trouble > > I'm having trouble getting the network to work fine in the QEmu VMs. > > Eventually I discovered that if I bridged to eth0 then it's just the > communication between the host and the VM that does not work. >

[1/5] windowscodecs: Implement PixelFormatInfo_GetBitsPerPixel.

2012-06-21 Thread Vincent Povirk
From e5de341b990be3bb2c9c9016f3c11fe3681620cc Mon Sep 17 00:00:00 2001 From: Vincent Povirk Date: Mon, 16 Apr 2012 15:40:35 -0500 Subject: [PATCH 01/17] windowscodecs: Implement PixelFormatInfo_GetBitsPerPixel. --- dlls/windowscodecs/info.c | 29 +++-- 1 file changed,

Re: Wine automated testing update

2012-06-21 Thread Julius Schwartzenberg
Francois Gouget wrote: > All replacements involve installing some application in the Windows VM. > So given that we want to run Winetest too I have the following > requirements: > * The application should run on everything from Windows 8 down to NT4. > * It should not bring in dependencies that

Re: Incompatibility in Kernel32

2012-06-21 Thread Ben Peddell
On 21/06/2012 7:11 PM, Dmitry Timoshkov wrote: > Hans Leidekker wrote: > >>> Is there any reason that you call DeleteFile() on a still being opened file? >> >> That's the whole point of this test. The observed behavior is that you can >> pass a >> filename to MsiRecordSetStream, successfully del

Re: Wine automated testing update

2012-06-21 Thread Francois Gouget
On Wed, 1 Feb 2012, Jeremy White wrote: [...] > However, Alexandre has persuaded me that we should first explore > integrating the dotest.sh functionality into the existing WineTestBot, > as that would allow us to have a very simple clean web page, and would > also allow us to integrate most cleanl

Re: kernel32: Add a test for deleting an opened for reading file. Take 2.

2012-06-21 Thread Eric Pouech
one tricky question... could it be that on windows this test behaves differently on ntfs vs FAT filesystem ? or what would give re-opening the file after the deletefile call ? A+ 2012/6/21, Dmitry Timoshkov : > Previous version had a typo in file name. > --- > dlls/kernel32/tests/file.c | 26 +++

Re: wintrust/tests: Fix build with MSVC.

2012-06-21 Thread Thomas Faber
On 2012-06-21 12:34, Dmitry Timoshkov wrote: > Thomas Faber wrote: > >> FIELD_OFFSET isn't constant "enough". > > The problem is not with FIELD_OFFSET, but with applying shift and mask > operations to a constant. You're right, it's actually a combination of multiple factors. I'm not sure what

Re: wintrust/tests: Fix build with MSVC.

2012-06-21 Thread Dmitry Timoshkov
Thomas Faber wrote: > FIELD_OFFSET isn't constant "enough". The problem is not with FIELD_OFFSET, but with applying shift and mask operations to a constant. -- Dmitry.

Re: [PATCH 1/7] ntdll: Add support for junction point creation.

2012-06-21 Thread Hans Leidekker
On Wed, 2012-06-20 at 17:26 -0600, Erich E. Hoover wrote: > +TRACE("Linking %s to %s\n", unix_src.Buffer, unix_dest.Buffer); > +if (rmdir( unix_src.Buffer ) < 0) > +{ > +status = FILE_GetNtStatus(); > +goto cleanup; > +} > +if (symlink( unix_dest.Buffer, unix_src

Re: wintrust/tests: Fix build with MSVC.

2012-06-21 Thread Dmitry Timoshkov
Thomas Faber wrote: > Empty braces are no valid initializer. > FIELD_OFFSET isn't constant "enough". > +/* add 'jmp ExitProcess' instruction */ > +count = 2; > +bin.text_section[count++] = 0xFF; > +bin.text_section[count++] = 0x25; > +bin.text_section[count++] = EXIT_PROCESS&

Re: Incompatibility in Kernel32

2012-06-21 Thread Dmitry Timoshkov
Hans Leidekker wrote: > > Is there any reason that you call DeleteFile() on a still being opened file? > > That's the whole point of this test. The observed behavior is that you can > pass a > filename to MsiRecordSetStream, successfully delete the file, and keep on > using the > stream. > >

Re: Incompatibility in Kernel32

2012-06-21 Thread Hans Leidekker
On Thu, 2012-06-21 at 16:03 +0900, Dmitry Timoshkov wrote: > > Shall I file a bug report? > > Try to add a test case to dlls/kenel32/tests/file.c,test_file_sharing(). > > > HANDLE h2 = CreateFileA(filename, GENERIC_READ, FILE_SHARE_DELETE | > > FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); > >

Re: kernel32: Add a test for deleting an opened for reading file.

2012-06-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19407 Your paranoid android

Re: Incompatibility in Kernel32

2012-06-21 Thread Dmitry Timoshkov
"robert.van.h...@serioustoys.com" wrote: > I feel hesitation towards starting to hack in kernel32 myself. Though this > bug seems to be blocking me to implement msi.dll completely compatible with > the MS implementation... You shouldn't look how native msi.dll behaves internally. > Shall I file